login
Header Space

 
 

Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Rafael J. Wysocki <rjw@...>
Cc: Alexey Starikovskiy <astarikovskiy@...>, pm list <linux-pm@...>, ACPI Devel Maling List <linux-acpi@...>, Alan Stern <stern@...>, Greg KH <greg@...>, Len Brown <lenb@...>, LKML <linux-kernel@...>, David Brownell <david-b@...>, Pavel Machek <pavel@...>, Oliver Neukum <oliver@...>
Date: Wednesday, March 26, 2008 - 8:06 pm

> > There is absolutely no point getting a second struct anymore.

Well, what does it bring you ? Why can't it be one struct ? To save
space in the data area ? I don't think it makes things much cleaner. But
I won't fight a war for it, now that they are clearly named differently
and things like prepare/complete are no longer in "noirq", it's
semantically the same thing as having the fields in one structure, so
it's mostly cosmetic.

Ben.



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/3] PM: Rework suspend and hibernation code for..., Rafael J. Wysocki, (Wed Mar 26, 6:53 pm)
[RFC][PATCH 3/3] PM: New suspend and hibernation callbacks f..., Rafael J. Wysocki, (Wed Mar 26, 7:06 pm)
[RFC][PATCH 1/3] PM: Introduce new top level suspend and hib..., Rafael J. Wysocki, (Wed Mar 26, 7:03 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Wed Mar 26, 9:12 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Thu Mar 27, 12:24 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Alexey Starikovskiy, (Wed Mar 26, 7:27 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Wed Mar 26, 7:59 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Benjamin Herrenschmidt, (Wed Mar 26, 7:43 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Wed Mar 26, 7:54 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Benjamin Herrenschmidt, (Wed Mar 26, 8:06 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Wed Mar 26, 9:23 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Benjamin Herrenschmidt, (Wed Mar 26, 10:52 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and..., Rafael J. Wysocki, (Thu Mar 27, 12:33 pm)
[RFC][PATCH 2/3] PM: New suspend and hibernation callbacks f..., Rafael J. Wysocki, (Wed Mar 26, 7:05 pm)
speck-geostationary