Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 4)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Wednesday, March 26, 2008 - 5:06 pm

> > There is absolutely no point getting a second struct anymore.

Well, what does it bring you ? Why can't it be one struct ? To save
space in the data area ? I don't think it makes things much cleaner. But
I won't fight a war for it, now that they are clearly named differently
and things like prepare/complete are no longer in "noirq", it's
semantically the same thing as having the fields in one structure, so
it's mostly cosmetic.

Ben.



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RFC][PATCH 0/3] PM: Rework suspend and hibernation code f ..., Rafael J. Wysocki, (Wed Mar 26, 3:53 pm)
[RFC][PATCH 1/3] PM: Introduce new top level suspend and h ..., Rafael J. Wysocki, (Wed Mar 26, 4:03 pm)
[RFC][PATCH 2/3] PM: New suspend and hibernation callbacks ..., Rafael J. Wysocki, (Wed Mar 26, 4:05 pm)
[RFC][PATCH 3/3] PM: New suspend and hibernation callbacks ..., Rafael J. Wysocki, (Wed Mar 26, 4:06 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Alexey Starikovskiy, (Wed Mar 26, 4:27 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Benjamin Herrenschmidt, (Wed Mar 26, 4:43 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Wed Mar 26, 4:54 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Wed Mar 26, 4:59 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Benjamin Herrenschmidt, (Wed Mar 26, 5:06 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Wed Mar 26, 6:12 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Wed Mar 26, 6:23 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Benjamin Herrenschmidt, (Wed Mar 26, 7:52 pm)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Thu Mar 27, 9:24 am)
Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend a ..., Rafael J. Wysocki, (Thu Mar 27, 9:33 am)