login
Header Space

 
 

Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ivan Kokshaysky <ink@...>
Cc: Gary Hade <garyhade@...>, Ingo Molnar <mingo@...>, Thomas Meyer <thomas@...>, Stefan Richter <stefanr@...>, Thomas Gleixner <tglx@...>, Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Natalie Protasevich <protasnb@...>, Benjamin Herrenschmidt <benh@...>, <pm@...>
Date: Wednesday, March 26, 2008 - 7:43 pm

On Thu, 27 Mar 2008, Ivan Kokshaysky wrote:

Adding an alignment field should be a non-issue: the size of this 
structure is not likely to be a big deal (yeah, we have something like 12 
of them in each PCI device etc, so smaller is better, but it's still not 
going to be something anybody really notices).

And yeah, it might be nice to have "size" instead of "end", but the real 
problem with that one is actually that on 32-bit (without the 64-bit 
resource configuration) we want it to be "size-1" in order to be able to 
fit a whole 0-0xffffffff resource into a resource.

And *that* would be really ugly with "size": at least right now it makes a 
certain amount of sense with "end" pointing to the last entry.

So while I can understand your wish for "start+len" rather than 
"start+end", I don't think it's really practical.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 21, 9:59 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Linus Torvalds, (Mon Mar 31, 2:21 pm)
2.6.25-rc7/8: Another resume regression, Mark Lord, (Thu Apr 3, 3:06 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Fri Apr 4, 10:27 pm)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 6:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Mon Apr 7, 11:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 1:40 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Tue Apr 8, 11:35 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:04 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:26 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:45 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Linus Torvalds, (Wed Mar 26, 7:43 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 5:57 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:17 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:29 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:54 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:18 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:27 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 8:17 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 11:39 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 7:25 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 7:33 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 8:12 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Rafael J. Wysocki, (Sat Mar 22, 1:58 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Jeff Garzik, (Fri Mar 21, 10:52 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:11 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Romano Giannetti, (Thu Mar 27, 6:18 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Wed Mar 26, 6:11 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Adrian Bunk, (Wed Mar 26, 1:02 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Heiko Carstens, (Sat Mar 22, 12:32 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:56 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Andrew Morton, (Sat Mar 22, 1:33 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:15 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:53 pm)
speck-geostationary