login
Header Space

 
 

[PATCH] don't suspend/resume 8xx chips

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: lkml <linux-kernel@...>
Cc: Linus Torvalds <torvalds@...>, Dave Airlie <airlied@...>
Date: Wednesday, March 26, 2008 - 7:28 pm

Recent testing has turned up some bugs in the new Intel suspend/resume code 
for old, 8xx chipsets.  So for 2.6.25 it probably makes sense to apply this 
patch, which should prevent the new code from getting called on those 
chipsets.  We should have this fixed soon, but not in time for 2.6.25 
unfortunately.  Note that this patch (along with the suspend/resume code in 
general) could use more testing.

Signed-off-by:  Jesse Barnes <jesse.barnes@intel.com>

diff --git a/drivers/char/drm/i915_dma.c b/drivers/char/drm/i915_dma.c
index e9d6663..6964a28 100644
--- a/drivers/char/drm/i915_dma.c
+++ b/drivers/char/drm/i915_dma.c
@@ -762,6 +762,11 @@ int i915_driver_load(struct drm_device *dev, unsigned 
long
        unsigned long base, size;
        int ret = 0, mmio_bar = IS_I9XX(dev) ? 0 : 1;

+       if (!IS_I9XX(dev)) {
+               dev->driver->suspend = NULL;
+               dev->driver->resume = NULL;
+       }
+
        /* i915 has 4 more counters */
        dev->counters += 4;
        dev->types[6] = _DRM_STAT_IRQ;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] don't suspend/resume 8xx chips, Jesse Barnes, (Wed Mar 26, 7:28 pm)
Re: [PATCH] don't suspend/resume 8xx chips, Pavel Machek, (Fri Mar 28, 10:40 am)
Re: [PATCH] don't suspend/resume 8xx chips, Jesse Barnes, (Fri Mar 28, 4:13 pm)
Re: [PATCH] don't suspend/resume 8xx chips, Soren Hansen, (Thu Mar 27, 4:38 am)
Re: [PATCH] don't suspend/resume 8xx chips, Jesse Barnes, (Mon May 5, 6:07 pm)
speck-geostationary