login
Header Space

 
 

Re: [patch] pci: revert "PCI: remove transparent bridge sizing"

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Ivan Kokshaysky <ink@...>, Linus Torvalds <torvalds@...>, Thomas Meyer <thomas@...>, Stefan Richter <stefanr@...>, Thomas Gleixner <tglx@...>, Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Natalie Protasevich <protasnb@...>, Benjamin Herrenschmidt <benh@...>, Gary Hade <garyhade@...>, <pm@...>
Date: Wednesday, March 26, 2008 - 2:07 pm

On Wed, Mar 26, 2008 at 02:54:58PM +0100, Ingo Molnar wrote:

As the author of the "PCI: remove transparent bridge sizing" change,
I apologize for the trouble it seems to have caused.  The same change
had also exposed an issue reported by Paul Martin that has been causing
an Oops while hotplugging ThinkPads to a ThinkPad Dock II.
 re: http://lkml.org/lkml/2008/2/19/405
     http://bugzilla.kernel.org/show_bug.cgi?id=9961
I have a fix for the ThinkPad docking Oops but if the issue being
discussed here is caused by the transparent bridge sizing removal
change I totally agree that it should be reverted.  

The transparent bridge sizing removal change was motivated by
insufficient PCI memory resource for a transparent bridge window
that was being created as a result of expansion ROM(s) being included
in the transparent bridge sizing calculations.  A later
"PCI: Remove default PCI expansion ROM memory allocation" change
( re: http://lkml.org/lkml/2007/12/11/361 ) removes the expansion
ROM(s) from the transparent bridge sizing calculations which actually
resolves the original issue in a different manner.  So, even if the
"PCI: remove transparent bridge sizing" is not problematic it is
no longer needed anyway.

Gary

-- 
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503  IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 21, 9:59 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Linus Torvalds, (Mon Mar 31, 2:21 pm)
2.6.25-rc7/8: Another resume regression, Mark Lord, (Thu Apr 3, 3:06 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Fri Apr 4, 10:27 pm)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 6:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Mon Apr 7, 11:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 1:40 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Tue Apr 8, 11:35 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:04 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:26 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Gary Hade, (Wed Mar 26, 2:07 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:45 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 5:57 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:17 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:29 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:54 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:18 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:27 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 8:17 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 11:39 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 7:25 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 7:33 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 8:12 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Rafael J. Wysocki, (Sat Mar 22, 1:58 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Jeff Garzik, (Fri Mar 21, 10:52 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:11 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Romano Giannetti, (Thu Mar 27, 6:18 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Wed Mar 26, 6:11 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Adrian Bunk, (Wed Mar 26, 1:02 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Heiko Carstens, (Sat Mar 22, 12:32 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:56 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Andrew Morton, (Sat Mar 22, 1:33 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:15 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:53 pm)
speck-geostationary