login
Header Space

 
 

Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpatch.pl

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andy Whitcroft <apw@...>
Cc: <rdunlap@...>, <jschopp@...>, <jes@...>, <linux-kernel@...>, <tony.luck@...>, <linux-ia64@...>
Date: Wednesday, March 26, 2008 - 12:58 pm

On Wed, Mar 26, 2008 at 10:03:36AM +0000, Andy Whitcroft wrote:

You're welcome and thanks for the quick fix to checkpatch.pl.
I used the new version and it fixed the problem except for ones that were of
the following form:

enum xp_retval (*xp_set_amo_with_interrupt) (u64 *amo_va, int op, u64 operand,
                                             int remote, int nasid,
                                             int phys_cpuid, int vector);
EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

which still generated the false positive:

WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#70: FILE: misc/xp/xp_main.c:70:
+EXPORT_SYMBOL_GPL(xp_set_amo_with_interrupt);

Thanks,
Dean
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [Patch 5/5] run drivers/misc/xp through scripts/checkpat..., Dean Nelson, (Wed Mar 26, 12:58 pm)
speck-geostationary