login
Login / Register
Header Space

 
 

Home » Mailing list archives » linux-kernel » 2008 » March » 26

Re: use of preempt_count instead of in_atomic() at leds-gpio.c

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Henrique de Moraes Holschuh <hmh@...>
To: Alan Stern <stern@...>
Cc: David Brownell <david-b@...>, <rpurdie@...>, <gitster@...>, <corbet@...>, <mingo@...>, <mb@...>, <linux-kernel@...>, <khali@...>, <geert@...>, <akpm@...>
Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c
Date: Wednesday, March 26, 2008 - 12:17 pm

On Wed, 26 Mar 2008, Alan Stern wrote:

I have changed the thinkpad-acpi leds code to always assume an atomic
context, but I too would appreciate a proper flag (or secondary hook)
from the LED class to know when I am in an atomic context or not.

LED Triggers also need to be modified, they are mostly called from an
atomic context so we have to assume that by default, but we'd do well to
add a way to call them from non-atomic contexts.

Richard?  AFAIK, the ball *is* in your court as the LED maintainer.  You
have to decide which way to go and tell us.  I suppose either I or Alan
could write up patches to implement it, but I have better things to do
than to write patches that would be rejected anyway... OTOH, I don't
mind writing ones that I know are at least attempting to implement an
approved idea and would be rejected only if they need some fixing.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Sun Mar 16, 2:43 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, David Brownell, (Sun Mar 16, 3:46 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Tue Mar 18, 3:14 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Thu Mar 20, 6:56 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Thu Mar 20, 7:47 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Richard Purdie, (Thu Mar 20, 8:56 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Thu Mar 20, 10:10 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Thu Mar 20, 8:36 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Thu Mar 20, 9:08 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, David Brownell, (Fri Mar 21, 1:04 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Fri Mar 21, 5:21 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Fri Mar 21, 8:37 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Fri Mar 21, 9:16 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Sat Mar 22, 7:29 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Fri Mar 21, 5:27 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Alan Stern, (Thu Mar 20, 9:31 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Michael Buesch, (Thu Mar 20, 9:36 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Thu Mar 20, 10:27 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Heiko Carstens, (Fri Mar 21, 9:47 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Greg KH, (Fri Mar 21, 12:54 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Fri Mar 21, 3:59 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Michael Buesch, (Fri Mar 21, 4:16 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Michael Buesch, (Fri Mar 21, 4:20 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Alan Stern, (Thu Mar 20, 11:07 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Thu Mar 20, 11:17 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Tetsuo Handa, (Fri Mar 21, 11:11 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Fri Mar 21, 12:54 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Stefan Richter, (Fri Mar 21, 1:02 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Tetsuo Handa, (Sun Mar 23, 1:53 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Jean Delvare, (Fri Mar 21, 5:53 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Fri Mar 21, 1:37 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Alan Stern, (Fri Mar 21, 2:05 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio..., Jonathan Corbet, (Mon Mar 24, 3:34 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Mon Mar 24, 3:42 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio..., Jonathan Corbet, (Mon Mar 24, 3:53 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Junio C Hamano, (Tue Mar 25, 4:52 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio..., Jonathan Corbet, (Tue Mar 25, 9:44 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, David Brownell, (Tue Mar 25, 7:20 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Alan Stern, (Wed Mar 26, 10:28 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Henrique de Moraes Holschuh..., (Wed Mar 26, 12:17 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, David Brownell, (Thu Mar 27, 2:51 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Richard Purdie, (Wed Mar 26, 12:46 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Jean Delvare, (Tue Mar 25, 6:39 am)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, David Brownell, (Tue Mar 18, 3:06 pm)
Re: use of preempt_count instead of in_atomic() at leds-gpio.c, Andrew Morton, (Tue Mar 18, 4:07 pm)

Mail archive search
Enter your search terms.
Optionally limit your search to a specific mailing list.
advanced
Colocation donated by:
Who's online
There are currently 5 users and 1058 guests online.

Online users

Syndicate
Syndicate content
© 2007 KernelTrap.  |  Powered by Drupal.  |  Legal statement.
speck-geostationary