[patch] pci: revert "PCI: remove transparent bridge sizing"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Wednesday, March 26, 2008 - 6:54 am

* Ivan Kokshaysky <ink@jurassic.park.msu.ru> wrote:


alternatively, try x86.git/latest which has the revert below included.

	Ingo

------------------>
Subject: pci: revert "PCI: remove transparent bridge sizing"
From: Ingo Molnar <mingo@elte.hu>
Date: Wed Mar 26 14:38:07 CET 2008

revert commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f as it is wrong.

Requested by Ivan Kokshaysky.

Signed-off-by-if-Thomas-reports-success: Ingo Molnar <mingo@elte.hu>
---
 drivers/pci/setup-bus.c |    5 -----
 1 file changed, 5 deletions(-)

Index: linux-x86.q/drivers/pci/setup-bus.c
===================================================================
--- linux-x86.q.orig/drivers/pci/setup-bus.c
+++ linux-x86.q/drivers/pci/setup-bus.c
@@ -486,12 +486,7 @@ void __ref pci_bus_size_bridges(struct p
 		break;
 
 	case PCI_CLASS_BRIDGE_PCI:
-		/* don't size subtractive decoding (transparent)
-		 * PCI-to-PCI bridges */
-		if (bus->self->transparent)
-			break;
 		pci_bridge_check_ranges(bus);
-		/* fall through */
 	default:
 		pbus_size_io(bus);
 		/* If the bridge supports prefetchable range, size it
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 21, 6:59 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Jeff Garzik, (Fri Mar 21, 7:52 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Andrew Morton, (Fri Mar 21, 10:33 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 4:11 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 4:15 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Heiko Carstens, (Sat Mar 22, 9:32 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 10:53 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 10:56 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Rafael J. Wysocki, (Sat Mar 22, 10:58 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Benjamin Herrenschmidt, (Tue Mar 25, 4:33 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Benjamin Herrenschmidt, (Tue Mar 25, 5:12 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Benjamin Herrenschmidt, (Tue Mar 25, 8:39 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Benjamin Herrenschmidt, (Wed Mar 26, 5:17 am)
[patch] pci: revert "PCI: remove transparent bridge sizing", Ingo Molnar, (Wed Mar 26, 6:54 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Adrian Bunk, (Wed Mar 26, 10:02 am)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 2:57 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Wed Mar 26, 3:11 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 3:27 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 3:29 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 3:54 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 4:17 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 4:18 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: R ..., Benjamin Herrenschmidt, (Wed Mar 26, 4:25 pm)
Re: [patch] pci: revert &quot;PCI: remove transparent bridge si ..., Benjamin Herrenschmidt, (Wed Mar 26, 4:45 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Romano Giannetti, (Thu Mar 27, 3:18 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Linus Torvalds, (Mon Mar 31, 11:21 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 2:04 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 2:26 pm)
2.6.25-rc7/8: Another resume regression, Mark Lord, (Thu Apr 3, 12:06 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Fri Apr 4, 7:27 pm)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 3:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Mon Apr 7, 8:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 10:40 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Tue Apr 8, 8:35 am)