Re: why so many unexported headers checking __KERNEL__?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Woodhouse <dwmw2@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, March 26, 2008 - 8:53 am

On Wed, 26 Mar 2008, David Woodhouse wrote:


not surprisingly, the only reason i noticed the above was because i
hacked together a short script that went looking for all of the above
and i was surprised at the number of files it identified.  (i've
already submitted a few patches to clean up the obviously erroneous
cases, like being miscategorized or being in both categories at once
so, after the next merge window, those should all be gone.)

rday

p.s. the other case that could be identified is when a header file has
its *entire* contents encased in a __KERNEL__ test, (either ifdef or
ifndef).  AFAICT, unless that kind of test is partitioning *some* of a
header file content from the remainder, there's little value in a
__KERNEL__test if the end result is to either:

  a) leave the file exactly as is, or
  b) reduce it to empty

--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Sun Mar 23, 2:31 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 8:08 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 8:53 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 9:10 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:16 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 9:19 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:37 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:23 am)