Re: why so many unexported headers checking __KERNEL__?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Robert P. J. Day <rpjday@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, March 26, 2008 - 8:08 am

On Sun, 2008-03-23 at 02:31 -0400, Robert P. J. Day wrote:

There's no point -- we just haven't got round to removing it yet. 

We should probably make headers_check or some other automated check
catch these two cases:

If a header is exported by header-y or not exported at all, it shouldn't
contain any #ifdef __KERNEL__.

And if it's exported and doesn't contain any #ifdef __KERNEL__, it
should be header-y not unifdef-y (and that's the case we should be
moving towards, by cleaning up headers to have separate files for the
user-visible parts).

-- 
dwmw2

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Sun Mar 23, 2:31 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 8:08 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 8:53 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 9:10 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:16 am)
Re: why so many unexported headers checking __KERNEL__?, David Woodhouse, (Wed Mar 26, 9:19 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:37 am)
Re: why so many unexported headers checking __KERNEL__?, Robert P. J. Day, (Wed Mar 26, 9:23 am)