login
Header Space

 
 

Re: sparc64 BUG: using smp_processor_id() in preemptible

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <m.kozlowski@...>
Cc: <torvalds@...>, <linux-kernel@...>, <sparclinux@...>
Date: Wednesday, March 26, 2008 - 7:51 am

From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Wed, 26 Mar 2008 12:46:53 +0100


Here ya go:

commit f6a843d939ade435e060d580f5c56d958464f8a5
Author: David S. Miller <davem@davemloft.net>
Date:   Wed Mar 26 04:51:12 2008 -0700

    [SPARC64]: flush_ptrace_access() needs preemption disable.
    
    Based upon a report by Mariusz Kozlowski.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/arch/sparc64/kernel/ptrace.c b/arch/sparc64/kernel/ptrace.c
index bcf58ec..aaae865 100644
--- a/arch/sparc64/kernel/ptrace.c
+++ b/arch/sparc64/kernel/ptrace.c
@@ -70,6 +70,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
 	if (tlb_type == hypervisor)
 		return;
 
+	preempt_disable();
+
 #ifdef DCACHE_ALIASING_POSSIBLE
 	/* If bit 13 of the kernel address we used to access the
 	 * user page is the same as the virtual address that page
@@ -108,6 +110,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,
 		for (; start < end; start += icache_line_size)
 			flushi(start);
 	}
+
+	preempt_enable();
 }
 
 enum sparc_regset {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.25-rc7, Linus Torvalds, (Tue Mar 25, 10:07 pm)
Re: Linux 2.6.25-rc7 sparc64 loops forever on cat /proc/&lt;..., Mariusz Kozlowski, (Wed Mar 26, 8:02 am)
Re: Linux 2.6.25-rc7 sparc64 loops forever on cat /proc/&lt;..., Mariusz Kozlowski, (Fri Mar 28, 7:33 am)
sparc64 BUG: using smp_processor_id() in preemptible, Mariusz Kozlowski, (Wed Mar 26, 6:42 am)
Re: sparc64 BUG: using smp_processor_id() in preemptible, Andrew Morton, (Wed Mar 26, 11:25 pm)
Re: sparc64 BUG: using smp_processor_id() in preemptible, Mariusz Kozlowski, (Wed Mar 26, 7:46 am)
Re: sparc64 BUG: using smp_processor_id() in preemptible, David Miller, (Wed Mar 26, 7:51 am)
Re: sparc64 BUG: using smp_processor_id() in preemptible, Mariusz Kozlowski, (Wed Mar 26, 8:10 am)
speck-geostationary