Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Wednesday, March 26, 2008 - 4:28 am

* Christoph Hellwig <hch@infradead.org> wrote:


same for me.

and PLEASE, folks, even if you _dont_ find that line unreadable, and 
even if you have full power and control over your own subsystem that you 
maintain and can NAK cleanup patches at whim, still _PLEASE_ follow the 
Linux coding style because it inconsistency hurts the eyes of a 
substantial proportion of kernel developers. Other folks might have to 
fix bugs in your code, other folks might want to reuse your code or you 
might go into a different subsystem and give maintainership to someone 
else, etc. etc. Consistent coding style is one of the few concepts that 
only has advantages and no disadvantages at all.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch c ..., Paolo Ciarrocchi, (Tue Mar 25, 11:23 am)
[patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 3:14 am)
Re: [patch] bkl2mtd: cleanup, Al Viro, (Wed Mar 26, 3:48 am)
Re: [patch] bkl2mtd: cleanup, Jörn, (Wed Mar 26, 3:57 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 4:00 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 4:02 am)
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch c ..., Christoph Hellwig, (Wed Mar 26, 4:09 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 4:10 am)
Re: [patch] bkl2mtd: cleanup, Jiri Slaby, (Wed Mar 26, 4:14 am)
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch c ..., Ingo Molnar, (Wed Mar 26, 4:28 am)
Re: [patch] bkl2mtd: cleanup, Joe Perches, (Wed Mar 26, 9:30 am)