Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andy Whitcroft <apw@...>
Cc: Ingo Molnar <mingo@...>, David Miller <davem@...>, <jirislaby@...>, <viro@...>, <joe@...>, <tglx@...>, <linux-kernel@...>
Date: Wednesday, March 26, 2008 - 6:26 am

On Wed, 26 March 2008 09:52:49 +0000, Andy Whitcroft wrote:

Then I'll happily ignore it.  Not having the space gains me one column.
It is absolutely minimal, sure.  But when the alternative is based on
pure whim...


Fairly weak grounds to argue on.  Not that mine are much stronger, I
just default to less (shorter, fewer indentations, etc.) when lacking a
reason to use more (characters, lines, indentations, etc.).


Or breaking the line.  Either of those choices sucks.  Well, breaking
the line is often the lesser of those evils, but in this particular
function it looks worse to me - and I have to stare at it often enough
to care.

The best strategy usually is to rethink the code and reduce the
indentation, number of arguments or length of identifiers.  I just don't
see a good way of doing that without resorting to
		ret = logfs_segment_read(i, p, w->o, b, l);

Probably nothing checkpatch should worry about.  Although I would have
been happy to have finer-grained options to enable/disable particular
warnings on the command line.  Right now I commented out several lines
in checkpatch.pl.

Jörn

-- 
Joern's library part 7:
http://www.usenix.org/publications/library/proceedings/neworl/full_papers/mckusick.a
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Christoph Hellwig, (Wed Mar 26, 7:09 am)
[patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 6:14 am)
Re: [patch] bkl2mtd: cleanup, Al Viro, (Wed Mar 26, 6:48 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:10 am)
Re: [patch] bkl2mtd: cleanup, Joe Perches, (Wed Mar 26, 12:30 pm)
Re: [patch] bkl2mtd: cleanup, Jiri Slaby, (Wed Mar 26, 7:14 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:02 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:00 am)
Re: [patch] bkl2mtd: cleanup, Jörn, (Wed Mar 26, 6:57 am)
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Jörn, (Wed Mar 26, 6:26 am)