Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Thomas Meyer <thomas@...>, Ingo Molnar <mingo@...>, Stefan Richter <stefanr@...>, Thomas Gleixner <tglx@...>, Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Natalie Protasevich <protasnb@...>, Benjamin Herrenschmidt <benh@...>, Gary Hade <garyhade@...>
Date: Wednesday, March 26, 2008 - 6:14 am

On Tue, Mar 25, 2008 at 02:47:35PM -0700, Linus Torvalds wrote:

Note that 'Memory at 100000000' is totally bogus as this is 32-bit BAR
and respective PCI bridge is 32-bit either.

Most interesting thing is that under 2.6.24 Tomas had

PCI: Bridge: 0000:00:1e.0
  IO window: disabled.
  MEM window: 8c000000-8c0fffff
  PREFETCH window: disabled.

but with 2.6.25

PCI: Bridge: 0000:00:1e.0
  IO window: disabled.
  MEM window: 0x00000000-0x000fffff
  PREFETCH window: disabled.

I'm sure that MEM window was actually 0x100000000-0x1000fffff as that
printk shows only 8 hex digits.


Yeah, it's resource issue for sure. The 00:1e.0 is a transparent bridge,
so I blame commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f
(PCI: remove transparent bridge sizing). It's wrong for two reasons:
- we cannot ignore standard windows of a transparent bridge as they
  always positive decode, so they are potential source of address conflicts;
- that patch just broke whole bridge setup logic in unpredictable way.

What confused me a lot initially is that the patch was already there
in 2.6.24. But I think that issue was somehow masked by 'unsigned
longs' used in setup-bus.c all over the place instead of resource_size_t,
which has been fixed by Ben in 2.6.25...
I think that's why Thomas has everything working again without
CONFIG_RESOURCES_64BIT.

Thomas, can you put CONFIG_RESOURCES_64BIT=y back and either
revert commit 8fa5913d54f3b1e09948e6a0db34da887e05ff1f, or
just comment out these two lines in drivers/pci/setup-bus.c:

		if (bus->self->transparent)
			break;

and check if it helps?

Ivan.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 21, 9:59 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Linus Torvalds, (Mon Mar 31, 2:21 pm)
2.6.25-rc7/8: Another resume regression, Mark Lord, (Thu Apr 3, 3:06 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Fri Apr 4, 10:27 pm)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 6:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Mon Apr 7, 11:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 1:40 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Tue Apr 8, 11:35 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:04 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:26 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Ivan Kokshaysky, (Wed Mar 26, 6:14 am)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:45 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 5:57 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:17 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:29 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:54 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:18 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:27 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 8:17 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 11:39 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 7:25 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 7:33 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 8:12 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Rafael J. Wysocki, (Sat Mar 22, 1:58 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Jeff Garzik, (Fri Mar 21, 10:52 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:11 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Romano Giannetti, (Thu Mar 27, 6:18 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Wed Mar 26, 6:11 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Adrian Bunk, (Wed Mar 26, 1:02 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Heiko Carstens, (Sat Mar 22, 12:32 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:56 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Andrew Morton, (Sat Mar 22, 1:33 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:15 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:53 pm)