login
Header Space

 
 

Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cleanups - formatting only

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jörn <joern@...>
Cc: Ingo Molnar <mingo@...>, David Miller <davem@...>, <jirislaby@...>, <viro@...>, <joe@...>, <tglx@...>, <linux-kernel@...>
Date: Wednesday, March 26, 2008 - 5:52 am

On Tue, Mar 25, 2008 at 05:07:35PM +0100, Jörn Engel wrote:

It really gains us nothing, however that is not really the point.
The point is that consistancy is good, with the space is the more normal
'C' usage, without for 'C++'; something to do with the implication that
(foo *) is a pointer to a foo (separate things), and (foo*) is a thing
of type pointer to foo (one thing) which is more object oriented.

The "norm" is with and so it makes sense to maintain it that way.  A lot
of the layout and style choises are arbitrary, and disliked by many of us,
but we follow the style to maintain that common feel.


Yes that is a false positive.  I'll have a look at fixing it.


"else if" is at least creating an additional arm of the same control
structure.  else while is mixing two different paradigms.


Because to add the space would mean breaking the line to avoid exceeding
80 characters?


That is a false positive triggered by the '    |S' at the start of
the line.  This one is fixed in the head of my tree.  The more normal
form would be for that leading | to be on the end of the previous line,
and the exception for that was already there.


-apw
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Christoph Hellwig, (Wed Mar 26, 7:09 am)
[patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 6:14 am)
Re: [patch] bkl2mtd: cleanup, Al Viro, (Wed Mar 26, 6:48 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:10 am)
Re: [patch] bkl2mtd: cleanup, Joe Perches, (Wed Mar 26, 12:30 pm)
Re: [patch] bkl2mtd: cleanup, Jiri Slaby, (Wed Mar 26, 7:14 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:02 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:00 am)
Re: [patch] bkl2mtd: cleanup, Jörn, (Wed Mar 26, 6:57 am)
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Andy Whitcroft, (Wed Mar 26, 5:52 am)
speck-geostationary