Re: [PATCH] acpi_unlazy_tlb only on C3 entry

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Venki Pallipadi <venkatesh.pallipadi@...>
Cc: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>, linux-kernel <linux-kernel@...>
Date: Wednesday, March 26, 2008 - 12:35 am

Yes, this was causeed by a merge error -- the checked-in patch
did not match the e-mailed patch.

I found that I could reproduce the error if I used patch(1)
and ignored this:

patching file drivers/acpi/processor_idle.c
Hunk #1 succeeded at 534 with fuzz 2 (offset 4 lines).
Hunk #2 succeeded at 1420 (offset -66 lines).

The 2nd hunk is what failed:
Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c
===================================================================
--- linux-2.6.24-rc.orig/drivers/acpi/processor_idle.c
+++ linux-2.6.24-rc/drivers/acpi/processor_idle.c
@@ -530,6 +530,7 @@ static void acpi_processor_idle(void)
                break;

        case ACPI_STATE_C3:
+               acpi_unlazy_tlb(smp_processor_id());
                /*
                 * disable bus master
                 * bm_check implies we need ARB_DIS
@@ -1485,6 +1486,7 @@ static int acpi_idle_enter_bm(struct cpu
                return 0;
        }

+       acpi_unlazy_tlb(smp_processor_id());
        /*
         * Must be done before busmaster disable as we might need to
         * access HPET !


As this touches just acpi/processor_idle.c, I'll send this with
a batch of acpi patches I've got.

applied.

thanks,
-Len

On Monday 24 March 2008, Venki Pallipadi wrote:


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] acpi_unlazy_tlb only on C3 entry, Venki Pallipadi, (Mon Mar 24, 5:24 pm)
Re: [PATCH] acpi_unlazy_tlb only on C3 entry, Len Brown, (Wed Mar 26, 12:35 am)