ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --

On Wed, 26 Mar 2008 10:50:41 +1100 Acked-by: Alan Cox <alan@redhat.com> --

While I have no desire to defend that particular design, saying "tasteless" without suggesting an alternate approach does appear somewhat unhelpful. NeilBrown --

Hello! Current Kernels (2.6.25-rc6, commit d2532dd20a126020de407c1c2476a75b53fce7ac) results in the following link errors: CC arch/alpha/lib/udelay.o AR arch/alpha/lib/lib.a LD vmlinux.o MODPOST vmlinux.o WARNING: "saved_config" [vmlinux] is COMMON symbol WARNING: modpost: Found 22 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' GEN .version CHK include/linux/compile.h UPD include/linux/com...

here are some (probably more or less minor) issues i have found in /var/log/messages & dmesg after some bigger module load/unload session - maybe someone wants to take a closer look. this one looks more serious (happened with modprobe -r ac), because kernel has problems afterwards (cannot load/anload any other module afterwards) ACPI: ACPI0007:00 is registered as cooling_device0 ACPI: Processor [CPU0] (supports 8 throttling states) BUG: unable to handle kernel paging request at 1b563b0c IP: [&l...

Well, Andrew should be CCed too ... Thanks, Rafael --

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Tue, 25 Mar 2008 15:11:15 -0700 (PDT) --

What we need is for the "filehandle" to be stable and unique. By 'stable' I mean that every time I get the filehandle for a particular file, I get the same string of bytes. By 'uniqie' I mean that if I get two filehandles for two different files, they must differ in at least one bit. If a file is deleted and the inode is re-used for a new file, then the old and new files are different and must have different file handles. The filehandle is traditionally generated from the inode number and a gene...

* Change the following static arrays sized by NR_CPUS to per_cpu data variables: _cpuid4_info *cpuid4_info[NR_CPUS]; _index_kobject *index_kobject[NR_CPUS]; kobject * cache_kobject[NR_CPUS]; * Remove the local NR_CPUS array with a kmalloc'd region in show_shared_cpu_map(). Also some minor complaints from checkpatch.pl fixed. Based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git Cc: Thom...

Change fixed size arrays to per_cpu variables or dynamically allocated arrays in sched_init() and sched_init_smp(). (1) static struct sched_entity *init_sched_entity_p[NR_CPUS]; (1) static struct cfs_rq *init_cfs_rq_p[NR_CPUS]; (1) static struct sched_rt_entity *init_sched_rt_entity_p[NR_CPUS]; (1) static struct rt_rq *init_rt_rq_p[NR_CPUS]; static struct sched_group **sched_group_nodes_bycpu[NR_CPUS]; char str[NR_CPUS]; int ints[NR_CPUS], i; (1 - these arrays are allocated via alloc_boo...

Change cpu_sys_devices from array to per_cpu variable in drivers/base/cpu.c. Based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git (MAINTAINER unknown) Signed-off-by: Mike Travis <travis@sgi.com> --- drivers/base/cpu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux.trees.git.orig/drivers/base/cpu.c +++ linux.trees.git/drivers/base/cpu.c @@ -18,7 +18,7 @@ struc...

Change cpufreq_policy and cpufreq_governor pointer tables from arrays to per_cpu variables in the cpufreq subsystem. Also some minor complaints from checkpatch.pl fixed. Based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git Cc: Dave Jones <davej@codemonkey.org.uk> Signed-off-by: Mike Travis <travis@sgi.com> --- drivers/cpufreq/cpufreq.c | 45 +++++++++++++++++++++----------------...

Cleanup references to the early cpu maps for the non-SMP configuration and remove some functions called for SMP configurations only. Based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git Cc: Andi Kleen <ak@suse.de> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Christoph Lameter <clameter@sgi.com> Signed-off-by: Mike Travis <travis@sgi.com>...

What means Hugepage? Does it mean 8KiB? 16KiB? 32KiB? 64KiB? 2MiB? 4MiB? The real page sizes of x86 and x86-64 are 4 KiB for this linux kernel. But the page sizes can be soft 8 KiB or 16 KiB or 32 KiB or 64 KiB if it is implemented in the memory manager of the kernel. But too they exist real page sizes of 2 MiB and 4 MiB that they have some reserved entries of TLB in the specs of Intel/AMD processors for these gigant pages. --

From: Daniel Yeisley <dan.yeisley@unisys.com> Commit 556a169dab38b5100df6f4a45b655dddd3db94c1 ("slab: fix bootstrap on memoryless node") introduced bootstrap-time cache_cache list3s for all nodes but forgot that initkmem_list3 needs to be accessed by [somevalue + node]. This patch fixes list_add() corruption in mm/slab.c seen on the ES7000. Cc: Mel Gorman <mel@csn.ul.ie> Cc: Olaf Hering <olaf@aepfle.de> Cc: Christoph Lameter <clameter@sgi.com> Signed-off-by: Dan Yeisley &...

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Tue, 25 Mar 2008 14:22:51 -0700 (PDT) So it's not an ill-advised disable_irq(). I guess the first question is: did the ifdown just kill the keyboard, or did more things die? Perhaps you could try ifdown eth0 ; sleep 5 ; ifup eth0 and see if the machine recovers? (I am just maxed out on bug reports at present - could someone please take this up and see if we can get it fixed?) ...

$ cat /proc/cpuinfo processor : 0 vendor_id : AuthenticAMD cpu family : 15 model : 47 model name : AMD Athlon(tm) 64 Processor 3200+ ... cache size : 512 KB ... The cache size is currently misinformed. It's not the real size because it's 64+64+512 KiB = 640 KiB, not 512 KB. How can i know what hw-caches use the processors? The current kernel doesn't know well what hw-caches uses. The good proposal is by example (the data below are not real): * In old ...

Thanks, but there is not easier manner to print the properties of hw-caches unless printing recursively this tree /sys/devices/system/cpu/cpu[0-9]+/cache/ that they are only numbers without symbolic fields. /proc/cpuinfo doesn't give a general summary because it gives superfluous info. I think that it's better to refactorize /proc/cpuinfo still more. ( ... fields common to all present processors known by the kernel .... [ to warn if the values are differents between cores ] ) ( ...

Well, i understand as if this cosmetic data formatting can break the grep of some applications. But if the modern PC has 6 or 8 cores then it prints an equivalent to x6 or x8 common pages in a small xterm console of 80x25 although the panoramic TFT is bigger as 23' 1900x1200 pixels. Tomorrow, 32 cores, it prints x32 instead of x8. Soon, it will need cosmetic data formatting. Hahahaha ;) --

We provide a map_error function in pci-base_32.c to make sure i386 keeps with the same behaviour it used to. Signed-off-by: Glauber Costa <gcosta@redhat.com> --- arch/x86/kernel/pci-base_32.c | 7 +++++++ include/asm-x86/dma-mapping.h | 8 ++++++++ include/asm-x86/dma-mapping_32.h | 6 ------ include/asm-x86/dma-mapping_64.h | 8 -------- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/arch/x86/kernel/pci-base_32.c b/arch/x86/kernel/pci-base_32.c index ...

all the code that is left is ready to be merged as-is in dma-mapping.h Signed-off-by: Glauber Costa <gcosta@redhat.com> --- include/asm-x86/dma-mapping.h | 19 +++++++++++++------ include/asm-x86/dma-mapping_32.h | 23 ----------------------- include/asm-x86/dma-mapping_64.h | 17 ----------------- 3 files changed, 13 insertions(+), 46 deletions(-) delete mode 100644 include/asm-x86/dma-mapping_32.h delete mode 100644 include/asm-x86/dma-mapping_64.h diff --git a/include/asm-...

This is the way x86_64 does, so this make them equal. They have to be extern now in the header, and the extern definition is moved to the common dma-mapping.h header Signed-off-by: Glauber Costa <gcosta@redhat.com> --- arch/x86/kernel/pci-dma_32.c | 33 +++++++++++++++++++++++++++++++++ include/asm-x86/dma-mapping.h | 3 +++ include/asm-x86/dma-mapping_32.h | 29 ----------------------------- include/asm-x86/dma-mapping_64.h | 4 ---- 4 files changed, 36 insertions(+), 33 ...

It's initially 0, since we don't expect any DMA there. Signed-off-by: Glauber Costa <gcosta@redhat.com> --- arch/x86/kernel/pci-dma_32.c | 4 ++++ include/asm-x86/dma-mapping.h | 2 ++ include/asm-x86/dma-mapping_64.h | 1 - 3 files changed, 6 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/pci-dma_32.c b/arch/x86/kernel/pci-dma_32.c index 453b4bd..55ab3c8 100644 --- a/arch/x86/kernel/pci-dma_32.c +++ b/arch/x86/kernel/pci-dma_32.c @@ -14,6 +14,10 @@ #inclu...

They are similar enough to do this move. the macro version is ugly, and we use inline functions instead Signed-off-by: Glauber Costa <gcosta@redhat.com> --- include/asm-x86/dma-mapping.h | 14 ++++++++++++++ include/asm-x86/dma-mapping_32.h | 15 --------------- include/asm-x86/dma-mapping_64.h | 4 ---- 3 files changed, 14 insertions(+), 19 deletions(-) diff --git a/include/asm-x86/dma-mapping.h b/include/asm-x86/dma-mapping.h index 3ea3802..b5a413a 100644 --- a/include/asm-x...

i386 gets an empty function Signed-off-by: Glauber Costa <gcosta@redhat.com> --- arch/x86/kernel/pci-base_32.c | 1 + include/asm-x86/dma-mapping.h | 9 +++++++++ include/asm-x86/dma-mapping_32.h | 6 ------ include/asm-x86/dma-mapping_64.h | 11 ----------- 4 files changed, 10 insertions(+), 17 deletions(-) diff --git a/arch/x86/kernel/pci-base_32.c b/arch/x86/kernel/pci-base_32.c index 4512c30..d876600 100644 --- a/arch/x86/kernel/pci-base_32.c +++ b/arch/x86/kernel/...