Home » Mailing list archives » linux-kernel » 2008 » March » 25

Re: [PATCH] pata_sil680: Only enable MMIO on Cell blades

Previous thread: none

Next thread: [PATCH] x86 floppy: kill off the 'register' keyword from header by Jesper Juhl on Tuesday, March 25, 2008 - 9:16 pm. (2 messages)
[view original message]
From: Benjamin Herrenschmidt <benh@...>
To: <jgarzik@...>
Cc: Linux IDE <linux-ide@...>, <linux-kernel@...>
Subject: [PATCH] pata_sil680: Only enable MMIO on Cell blades
Date: Tuesday, March 25, 2008 - 7:50 pm

There have been reported regressions of the SIL 680 driver when

using MMIO, so this makes it only try MMIO on Cell blades where

it's known to be necessary (the host bridge doesn't do PIO on these).


We'll try to find the root problem with MMIO separately.


Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

---


 drivers/ata/pata_sil680.c |    6 +++++-

 1 file changed, 5 insertions(+), 1 deletion(-)


--- linux-work.orig/drivers/ata/pata_sil680.c	2008-03-26 10:43:20.000000000 +1100

+++ linux-work/drivers/ata/pata_sil680.c	2008-03-26 10:43:34.000000000 +1100

@@ -269,7 +269,11 @@ static u8 sil680_init_chip(struct pci_de

 	dev_dbg(&pdev->dev, "sil680: BA5_EN = %d clock = %02X\n",

 		tmpbyte & 1, tmpbyte & 0x30);


-	*try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);

+	*try_mmio = 0;

+#ifdef CONFIG_PPC

+	if (machine_is(cell))

+		*try_mmio = (tmpbyte & 1) || pci_resource_start(pdev, 5);

+#endif


 	switch(tmpbyte & 0x30) {

 		case 0x00:

--
[view original message]
From: Alan Cox <alan@...>
To: Benjamin Herrenschmidt <benh@...>
Cc: <jgarzik@...>, Linux IDE <linux-ide@...>, <linux-kernel@...>
Subject: Re: [PATCH] pata_sil680: Only enable MMIO on Cell blades
Date: Tuesday, March 25, 2008 - 7:49 pm

On Wed, 26 Mar 2008 10:50:41 +1100


Acked-by: Alan Cox <alan@redhat.com>

--
Previous thread: none

Next thread: [PATCH] x86 floppy: kill off the 'register' keyword from header by Jesper Juhl on Tuesday, March 25, 2008 - 9:16 pm. (2 messages)