Re: [PATCH 019/148] include/asm-x86/cpufeature.h: checkpatch cleanups - formatting only

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Joe Perches <joe@...>
Cc: Thomas Gleixner <tglx@...>, <linux-kernel@...>
Date: Tuesday, March 25, 2008 - 4:15 pm

* Joe Perches wrote:

> On Tue, 2008-03-25 at 16:30 +0100, Ingo Molnar wrote:

both :) Line-breaking in macros isnt done like that. And the _CF thing:

+#if defined _CF
+#undef _CF
+#endif
+#define _CF(word, bit) ((word) * 32 + (bit))

looks quite ugly - either we have such a macro in which case it should
be a generic define somewhere that doesnt override anything else, or we
shouldnt do it.

I also had to fix some other typos that broke the 64-bit build. I ended
up skipping the whole cpufeatures.h patch - could you please re-do and
re-send it?

Ingo
--

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 019/148] include/asm-x86/cpufeature.h: checkpatch..., Ingo Molnar, (Tue Mar 25, 4:15 pm)
Re: [PATCH 109/148] include/asm-x86/serial.h: checkpatch cle..., Christoph Hellwig, (Wed Mar 26, 7:09 am)
[patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 6:14 am)
Re: [patch] bkl2mtd: cleanup, Al Viro, (Wed Mar 26, 6:48 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:10 am)
Re: [patch] bkl2mtd: cleanup, Joe Perches, (Wed Mar 26, 12:30 pm)
Re: [patch] bkl2mtd: cleanup, Jiri Slaby, (Wed Mar 26, 7:14 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:02 am)
Re: [patch] bkl2mtd: cleanup, Ingo Molnar, (Wed Mar 26, 7:00 am)
Re: [patch] bkl2mtd: cleanup, Jörn, (Wed Mar 26, 6:57 am)