login
Header Space

 
 

[PATCH] list_add corruption in slab.c

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: <akpm@...>
Date: Tuesday, March 25, 2008 - 12:57 pm

I've been seeing list_add corruption in slab.c on the ES7000 since the
2.6.24.1 kernel.  There are several places where the initkmem_list3
array is access by [somevalue + node].  This also needs to be done in
kmem_cache_init().  

Signed-off-by: Dan Yeisley <dan.yeisley@unisys.com>

---
diff -Naur linux-2.6.25-rc5/mm/slab.c linux-2.6.25-rc5-new/mm/slab.c
--- linux-2.6.25-rc5/mm/slab.c	2008-03-10 01:22:27.000000000 -0400
+++ linux-2.6.25-rc5-new/mm/slab.c	2008-03-20 13:59:24.000000000 -0400
@@ -1481,7 +1481,7 @@
 	list_add(&cache_cache.next, &cache_chain);
 	cache_cache.colour_off = cache_line_size();
 	cache_cache.array[smp_processor_id()] = &initarray_cache.cache;
-	cache_cache.nodelists[node] = &initkmem_list3[CACHE_CACHE];
+	cache_cache.nodelists[node] = &initkmem_list3[CACHE_CACHE + node];
 
 	/*
 	 * struct kmem_cache size depends on nr_node_ids, which

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] list_add corruption in slab.c, Daniel Yeisley, (Tue Mar 25, 12:57 pm)
Re: [PATCH] list_add corruption in slab.c, Pekka Enberg, (Tue Mar 25, 2:45 pm)
Re: [PATCH] list_add corruption in slab.c, Daniel Yeisley, (Tue Mar 25, 4:44 pm)
Re: [PATCH] list_add corruption in slab.c, Pekka Enberg, (Tue Mar 25, 5:13 pm)
Re: [PATCH] list_add corruption in slab.c, Mel Gorman, (Wed Mar 26, 10:16 am)
Re: [PATCH] list_add corruption in slab.c, Oliver Pinter, (Tue Mar 25, 5:27 pm)
Re: [PATCH] list_add corruption in slab.c, Pekka Enberg, (Tue Mar 25, 5:38 pm)
Re: [PATCH] list_add corruption in slab.c, Oliver Pinter, (Tue Mar 25, 5:42 pm)
speck-geostationary