login
Header Space

 
 

Re: [git pull] vfs patches

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Al Viro <viro@...>
Cc: <linux-kernel@...>
Date: Tuesday, March 25, 2008 - 12:05 pm

On Tue, 25 Mar 2008, Al Viro wrote:

Pulled.

And looking at the diffs, I see sequences like

	dget(save.dentry);
	mntget(save.mnt);
	...
	path_put(&save);

which looks very strange compared to the natural sequence:

	path_get(&save);
	..
	path_put(&save);

and yes, I realize the code was just moved (and the reason for the mixing 
is that the "path_put()" conversion was done much more aggressively, as 
the ordering matters), but I'm bringing this up in the hope somebody has 
the energy to clean things like up some day...

			Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] vfs patches, Al Viro, (Tue Mar 25, 4:17 am)
Re: [git pull] vfs patches, Linus Torvalds, (Tue Mar 25, 12:05 pm)
Re: [git pull] vfs patches, Al Viro, (Tue Mar 25, 2:00 pm)
speck-geostationary