login
Header Space

 
 

Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Reported regressions from 2.6.24)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stefan Richter <stefanr@...>
Cc: Thomas Meyer <thomas@...>, Linus Torvalds <torvalds@...>, Thomas Gleixner <tglx@...>, Ivan Kokshaysky <ink@...>, Rafael J. Wysocki <rjw@...>, LKML <linux-kernel@...>, Adrian Bunk <bunk@...>, Andrew Morton <akpm@...>, Natalie Protasevich <protasnb@...>
Date: Tuesday, March 25, 2008 - 3:31 am

* Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:


64-bit ioremaps never worked on 32-bit, so we are in totally unchartered 
waters now - but due to the unification we have a realistic chance to 
make them work. At minimum we need the fix below in addition to Linus' 
patch - does it make any difference?

	Ingo

---
 arch/x86/mm/ioremap.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: v/arch/x86/mm/ioremap.c
===================================================================
--- v.orig/arch/x86/mm/ioremap.c
+++ v/arch/x86/mm/ioremap.c
@@ -39,7 +39,7 @@ EXPORT_SYMBOL(__phys_addr);
 
 int page_is_ram(unsigned long pagenr)
 {
-	unsigned long addr, end;
+	resource_size_t addr, end;
 	int i;
 
 	/*
@@ -109,7 +109,8 @@ static int ioremap_change_attr(unsigned 
 static void __iomem *__ioremap(resource_size_t phys_addr, unsigned long size,
 			       enum ioremap_mode mode)
 {
-	unsigned long pfn, offset, last_addr, vaddr;
+	unsigned long pfn, offset, vaddr;
+	resource_size_t last_addr;
 	struct vm_struct *area;
 	pgprot_t prot;
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Fri Mar 21, 9:59 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Linus Torvalds, (Mon Mar 31, 2:21 pm)
2.6.25-rc7/8: Another resume regression, Mark Lord, (Thu Apr 3, 3:06 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Fri Apr 4, 10:27 pm)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 6:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Mon Apr 7, 11:51 am)
Re: 2.6.25-rc7/8: Another resume regression, Rafael J. Wysocki, (Mon Apr 7, 1:40 pm)
Re: 2.6.25-rc7/8: Another resume regression, Mark Lord, (Tue Apr 8, 11:35 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:04 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Tino Keitel, (Mon Mar 31, 5:26 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Ingo Molnar, (Tue Mar 25, 3:31 am)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:45 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 5:57 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:17 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:29 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:54 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 7:18 pm)
Re: [patch] pci: revert "PCI: remove transparent bridge sizi..., Benjamin Herrenschmidt, (Wed Mar 26, 6:27 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 8:17 am)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 11:39 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Wed Mar 26, 7:25 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 7:33 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Benjamin Herrenschmidt, (Tue Mar 25, 8:12 pm)
Re: ohci1394 problem (MMIO broken) (was 2.6.25-rc6-git6: Rep..., Rafael J. Wysocki, (Sat Mar 22, 1:58 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Jeff Garzik, (Fri Mar 21, 10:52 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:11 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Romano Giannetti, (Thu Mar 27, 6:18 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Wed Mar 26, 6:11 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Adrian Bunk, (Wed Mar 26, 1:02 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Heiko Carstens, (Sat Mar 22, 12:32 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:56 pm)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Andrew Morton, (Sat Mar 22, 1:33 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Ingo Molnar, (Sat Mar 22, 7:15 am)
Re: 2.6.25-rc6-git6: Reported regressions from 2.6.24, Rafael J. Wysocki, (Sat Mar 22, 1:53 pm)
speck-geostationary