Re: [SCSI] fix media change events for polled devices

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff Garzik
Date: Friday, March 21, 2008 - 3:35 pm

James Bottomley wrote:

No, it's not.  This information is published to userspace EVEN WHEN AN 
SUPPORT IS ABSENT.  As any sane interface would do -- report a zero value.

Thus, the interface is useful even in the absence of AN.

Anyway, to recap...

before your "fix":

	userspace interface always reflected list of events sent
	via my new API

after your "fix":

	events may or may not be reflected in userspace interface,
	who knows?

Is that distinction so difficult to see?

This interface, like it or not, is in 2.6.24, which means its published 
and "out there."

This is a clear regression from 2.6.24.

supported_events' value was accurate in 2.6.24.  Now it is not.

	Jeff


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 10:12 am)
Re: [SCSI] fix media change events for polled devices, Linus Torvalds, (Fri Mar 21, 10:31 am)
Re: [SCSI] fix media change events for polled devices, Kay Sievers, (Fri Mar 21, 11:33 am)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 12:38 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 12:44 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 1:36 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 1:39 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 1:42 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 1:54 pm)
Re: [SCSI] fix media change events for polled devices, Kay Sievers, (Fri Mar 21, 1:57 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 2:01 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 2:04 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 2:04 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 2:09 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 2:10 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 2:13 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 2:49 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Fri Mar 21, 3:35 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Fri Mar 21, 3:52 pm)
Re: [SCSI] fix media change events for polled devices, Jeff Garzik, (Mon Mar 24, 8:09 pm)
Re: [SCSI] fix media change events for polled devices, James Bottomley, (Mon Mar 24, 8:18 pm)