Home » Mailing list archives » linux-kernel » 2008 » March » 21

Re: [PATCH] [5/7] Readd rdmsrl_safe

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Thomas Gleixner <tglx@...>
To: Andi Kleen <andi@...>
Cc: <andreas.herrmann3@...>, <mingo@...>, <linux-kernel@...>
Subject: Re: [PATCH] [5/7] Readd rdmsrl_safe
Date: Friday, March 21, 2008 - 2:14 pm

On Fri, 21 Mar 2008, Andi Kleen wrote:

inlines are generally preferred and the existing macro pile is no
excuse to add more.


Yeah, I signed up for maintaining. And review is one of the tasks of a
maintainer. So when I do a review and ask for a macro -> inline change
I don't see that this means that I have to do the change myself.

Thanks,

	tglx
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [1/7] Implement true end_pfn_mapped for 32bit, Andi Kleen, (Tue Mar 11, 10:53 pm)
[PATCH] [7/7] CPA: Add statistics about state of direct mapp..., Andi Kleen, (Tue Mar 11, 10:53 pm)
Re: [PATCH] [7/7] CPA: Add statistics about state of direct ..., Thomas Gleixner, (Fri Mar 21, 1:41 pm)
Re: [PATCH] [7/7] CPA: Add statistics about state of direct ..., Andi Kleen, (Fri Mar 21, 1:55 pm)
[PATCH] CPA: Add statistics about state of direct mapping v3, Andi Kleen, (Sat Mar 22, 5:50 am)
Re: [PATCH] CPA: Add statistics about state of direct mappin..., Thomas Gleixner, (Tue Mar 25, 11:40 am)
Re: [PATCH] CPA: Add statistics about state of direct mappin..., Andi Kleen, (Tue Mar 25, 12:14 pm)
Re: [PATCH] CPA: Add statistics about state of direct mappin..., Thomas Gleixner, (Tue Mar 25, 12:16 pm)
Re: [PATCH] CPA: Add statistics about state of direct mappin..., Andi Kleen, (Tue Mar 25, 1:01 pm)
[PATCH] [6/7] Split large page mapping for AMD TSEG, Andi Kleen, (Tue Mar 11, 10:53 pm)
Re: [PATCH] [6/7] Split large page mapping for AMD TSEG, Thomas Gleixner, (Tue Mar 25, 12:44 pm)
Re: [PATCH] [6/7] Split large page mapping for AMD TSEG, Andi Kleen, (Tue Mar 25, 12:54 pm)
Re: [PATCH] [6/7] Split large page mapping for AMD TSEG, Thomas Gleixner, (Fri Mar 21, 1:55 pm)
Re: [PATCH] [6/7] Split large page mapping for AMD TSEG, Joerg Roedel, (Tue Mar 25, 7:56 am)
[PATCH] [5/7] Readd rdmsrl_safe, Andi Kleen, (Tue Mar 11, 10:53 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Thomas Gleixner, (Fri Mar 21, 1:06 pm)
[PATCH] Readd rdmsrl_safe v2, Andi Kleen, (Sat Mar 22, 5:59 am)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Andi Kleen, (Fri Mar 21, 1:16 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Thomas Gleixner, (Fri Mar 21, 1:58 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Andi Kleen, (Fri Mar 21, 2:06 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Thomas Gleixner, (Fri Mar 21, 2:14 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe, Andi Kleen, (Fri Mar 21, 2:46 pm)
Re: [PATCH] [5/7] Readd rdmsrl_safe II, Andi Kleen, (Fri Mar 21, 2:48 pm)
[PATCH] [4/7] Don't use large pages to map the first 2/4MB o..., Andi Kleen, (Tue Mar 11, 10:53 pm)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Thomas Gleixner, (Fri Mar 21, 1:45 pm)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Andi Kleen, (Fri Mar 21, 1:59 pm)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Thomas Gleixner, (Fri Mar 21, 2:03 pm)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Andi Kleen, (Fri Mar 21, 2:44 pm)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Eric Dumazet, (Wed Mar 12, 1:38 am)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Andi Kleen, (Wed Mar 12, 5:19 am)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Joerg Roedel, (Tue Mar 25, 7:31 am)
Re: [PATCH] [4/7] Don't use large pages to map the first 2/4..., Andi Kleen, (Tue Mar 25, 7:39 am)
[PATCH] [3/7] Add set_memory_4k to pageattr.c, Andi Kleen, (Tue Mar 11, 10:53 pm)
[PATCH] [2/7] Account overlapped mappings in end_pfn_map, Andi Kleen, (Tue Mar 11, 10:53 pm)