Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Friday, March 21, 2008 - 11:12 am

On Fri, 21 Mar 2008 11:12:30 -0500 Timur Tabi <timur@freescale.com> wrote:


I did:

--- a/drivers/video/fsl-diu-fb.c~fbdev-driver-for-freescale-8610-and-5121-diu-fix
+++ a/drivers/video/fsl-diu-fb.c
@@ -274,7 +274,7 @@ static struct mfb_info mfb_template[] = 
 
 static struct diu_hw dr = {
 	.mode = MFB_MODE1,
-	.reg_lock = __SPIN_LOCK_UNLOCKED(old_style_spin_init),
+	.reg_lock = __SPIN_LOCK_UNLOCKED(dr.reg_lock),
 };
 
 static struct diu_pool pool;


No, that's OK too.  It's just that GFP_DMA|GFP_ATOMIC is a bit redundant
and misleading.  GFP_DMA is already atomic; the only effect of adding
GFP_ATOMIC to GFP_DMA is to add __GFP_HIGH.

Don't wory about it ;)


Last time I grepped, no-space is a lot more common.


You snipped a bit.  Earlier, request_irq() failures were ignored.  So I
think there's a code path where free_irq_local() can free an IRQ which this
driver never owned.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
v2 patch for Freescale DIU driver, York Sun, (Wed Mar 19, 11:50 am)
Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU, Andrew Morton, (Thu Mar 20, 3:27 pm)
Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD, Andrew Morton, (Thu Mar 20, 3:33 pm)
Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU, Peter Zijlstra, (Thu Mar 20, 4:02 pm)
Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU, Andrew Morton, (Fri Mar 21, 11:12 am)
Re: [PATCH 1/2 v2] Driver for Freescale 8610 and 5121 DIU, Andrew Morton, (Mon Mar 24, 11:47 am)
Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD, Andy Whitcroft, (Tue Mar 25, 5:43 am)
Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD, Andrew Morton, (Tue Mar 25, 12:18 pm)