On Fri, 21 Mar 2008 11:12:30 -0500 Timur Tabi <timur@freescale.com> wrote:I did: --- a/drivers/video/fsl-diu-fb.c~fbdev-driver-for-freescale-8610-and-5121-diu-fix +++ a/drivers/video/fsl-diu-fb.c @@ -274,7 +274,7 @@ static struct mfb_info mfb_template[] = static struct diu_hw dr = { .mode = MFB_MODE1, - .reg_lock = __SPIN_LOCK_UNLOCKED(old_style_spin_init), + .reg_lock = __SPIN_LOCK_UNLOCKED(dr.reg_lock), }; static struct diu_pool pool; No, that's OK too. It's just that GFP_DMA|GFP_ATOMIC is a bit redundant and misleading. GFP_DMA is already atomic; the only effect of adding GFP_ATOMIC to GFP_DMA is to add __GFP_HIGH. Don't wory about it ;) Last time I grepped, no-space is a lot more common. You snipped a bit. Earlier, request_irq() failures were ignored. So I think there's a code path where free_irq_local() can free an IRQ which this driver never owned. --
| Linus Torvalds | Linux 2.6.27 |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Christoph Lameter | Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures |
| Rafael J. Wysocki | [Bug #10669] ACPI: kmemcheck: Caught 16-bit read from freed memory (f7c12ec6) |
git: | |
| Johannes Sixt | [PATCH 03/40] Add target architecture MinGW. |
| Eivind LM | Split a subversion repo into several git repos |
| Carl Baldwin | Revisiting large binary files issue. |
| Anatoly Yakovenko | GIT_SSL_NO_VERIFY=1 over http doesn't ignore a different ip address for the signed... |
| Linux Kernel Mailing List | i.MX3: make SoC devices globally available |
| Linux Kernel Mailing List | [MACVLAN]: Update Kconfig to refer to iproute |
| Linux Kernel Mailing List | MXC: Remove WD IRQ priority setting |
| Linux Kernel Mailing List | ARM: DaVinci: i2c setup |
| Marcos Laufer | dmesg IBM x3650 OpenBSD 4.3 |
| Richard Stallman | Real men don't attack straw men |
| Kevin Neff | Patching a SSH 'Weakness' |
| Pieter Verberne | Remove escape characters from file |
| How to make my PCIE ATA storage device running in Linux | 2 hours ago | Linux general |
| sata/ide timeout errors on asus server-mb | 5 hours ago | Linux kernel |
| Shared swap partition | 6 hours ago | Linux general |
| usb mic not detected | 10 hours ago | Applications and Utilities |
| Problem in Inserting a module | 11 hours ago | Linux kernel |
| Treason Uncloaked | 16 hours ago | Linux kernel |
| high memory | 2 days ago | Linux kernel |
| semaphore access speed | 3 days ago | Applications and Utilities |
| the kernel how to power off the machine | 3 days ago | Linux kernel |
| Easter Eggs in windows XP | 3 days ago | Windows |
