Re: [PATCH prototype] [0/8] Predictive bitmaps for ELF executables

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ulrich Drepper
Date: Friday, March 21, 2008 - 10:15 am

On Thu, Mar 20, 2008 at 2:00 AM, Andi Kleen <andi@firstfloor.org> wrote:

I didn't say that a separate file with the data is better.  In fact, I
agree, it's not much better.  What I referred to as the problem is
that this is an extension which is not part of the ELF spec and
doesn't fit in.  The ELF spec has rules how programs have to deal with
unknown parts of a binary.  Only this way programs like strip can work
in the presence of extensions.  There are ways to embed such a bitmap
but not ad-hoc as you proposed.



And that is only one advantage.  Let's not go done the path of invalid
ELF files.



This wasn't a comment about the size of the data but the type of data.
 The end of a binary contains data which is not used at runtime.  Now
you're mixing in data which is used.



Again, you misunderstand.  I'm not proposing to exclude pages which
are only used at startup time.  I mean the data collection should stop
some time after a process was started to account for possibly quite
different code paths which are taken by different runs of the program.
 I.e., don't record page faults for the entire runtime of the program
which, hopefully in most cases, will result in all the pages of a
program to be marked (unless you have a lot of dead code in the binary
and it's all located together).
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH prototype] [1/8] Give ELF shdr types a name, Andi Kleen, (Mon Mar 17, 6:09 pm)
[PATCH prototype] [8/8] Add mmap_full_slurp support, Andi Kleen, (Mon Mar 17, 6:09 pm)
Re: [PATCH prototype] [0/8] Predictive bitmaps for ELF exe ..., Ulrich Drepper, (Fri Mar 21, 10:15 am)