Yes, "__SPIN_LOCK_UNLOCKED(old_style_spin_init)" is wrong. We'll fix it.
Yes, this is better. Did you already make this change when you applied it to
your -mm repo?
So does that mean that "GFP_DMA | GFP_KERNEL" is always wrong? If so, this
combination is used a lot in the kernel today.
I had completely forgotten about __GFP_ZERO. Thanks.
I thought a space after a cast is the right thing to do?
Sorry, we forgot to run it again after our second version of the patch.
Sorry, but I don't understand what's wrong with this code.
We'll make the other changes you've suggested and repost.
--
Timur Tabi
Linux kernel developer at Freescale
--