Home » Mailing list archives » linux-kernel » 2008 » March » 21

r-o bind in nfsd

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Miklos Szeredi <miklos@...>
To: <haveblue@...>
Cc: <linux-fsdevel@...>, <linux-kernel@...>, <neilb@...>, <akpm@...>, <viro@...>, <hch@...>
Subject: r-o bind in nfsd
Date: Friday, March 21, 2008 - 10:59 am

Why is it that in fs/nfsd/vfs.c only vfs_mknod() and vfs_rename() are
surrounded by mnt_want_write/mnt_drop_write, and not the other
operations (vfs_create, vfs_mkdir, vfs_symlink, ...)?

I noticed this while looking at the AppArmor patches, which need to
pass the vfsmount down to the security module.  And I'm wondering, why
can't mnt_want_write() and mnt_drop_write() be done _inside_ vfs_foo()?

I know there are a few cases, where filesystems call vfs_foo()
internally, where the vfsmount isn't available, but I think the proper
solution is just to fix those places, and not recurse back into the
VFS (which is AFAICS in all those cases totally unnecessary anyway).
This would make everybody happy, no?

Miklos
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 10:59 am)
Re: r-o bind in nfsd, Al Viro, (Fri Mar 21, 11:54 am)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 12:24 pm)
Re: r-o bind in nfsd, Al Viro, (Fri Mar 21, 12:35 pm)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 12:54 pm)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 1:08 pm)
Re: r-o bind in nfsd, Al Viro, (Fri Mar 21, 2:11 pm)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 2:52 pm)
Re: r-o bind in nfsd, Dave Hansen, (Fri Mar 21, 5:08 pm)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 5:17 pm)
Re: r-o bind in nfsd, Al Viro, (Fri Mar 21, 3:49 pm)
Re: r-o bind in nfsd, Miklos Szeredi, (Fri Mar 21, 4:23 pm)
Re: r-o bind in nfsd, Tetsuo Handa, (Fri Mar 21, 10:20 pm)