Home » Mailing list archives » linux-kernel » 2008 » March » 21

[PATCH] x86_64: allcate e820 resource struct all together

Previous thread: [13/14] vcompound: Use vcompound for swap_map by Christoph Lameter on Friday, March 21, 2008 - 2:17 am. (8 messages)

Next thread: [PATCH] x86_64: early memtest to find bad ram by Yinghai Lu on Friday, March 21, 2008 - 2:58 am. (20 messages)
[view original message]
From: Yinghai Lu <yhlu.kernel.send@...>
To: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>
Cc: kernel list <linux-kernel@...>
Subject: [PATCH] x86_64: allcate e820 resource struct all together
Date: Friday, March 21, 2008 - 2:57 am

don't need to allocate that one by one


Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>


Index: linux-2.6/arch/x86/kernel/e820_64.c

===================================================================

--- linux-2.6.orig/arch/x86/kernel/e820_64.c

+++ linux-2.6/arch/x86/kernel/e820_64.c

@@ -237,9 +237,9 @@ unsigned long __init e820_end_of_ram(voi

 void __init e820_reserve_resources(void)

 {

 	int i;

+	struct resource *res;

+	res = alloc_bootmem_low(sizeof(struct resource) * e820.nr_map);

 	for (i = 0; i < e820.nr_map; i++) {

-		struct resource *res;

-		res = alloc_bootmem_low(sizeof(struct resource));

 		switch (e820.map[i].type) {

 		case E820_RAM:	res->name = "System RAM"; break;

 		case E820_ACPI:	res->name = "ACPI Tables"; break;

@@ -250,6 +250,7 @@ void __init e820_reserve_resources(void)

 		res->end = res->start + e820.map[i].size - 1;

 		res->flags = IORESOURCE_MEM | IORESOURCE_BUSY;

 		insert_resource(&iomem_resource, res);

+		res++;

 	}

 }


--
[view original message]
From: Ingo Molnar <mingo@...>
To: <yhlu.kernel@...>
Cc: Andrew Morton <akpm@...>, kernel list <linux-kernel@...>
Subject: Re: [PATCH] x86_64: allcate e820 resource struct all together
Date: Friday, March 21, 2008 - 8:04 am

nice one - applied.


(minor style nit: please keep a newline between variable definitions and

the first line of code, to make it a bit more readable.)


	Ingo

--
Previous thread: [13/14] vcompound: Use vcompound for swap_map by Christoph Lameter on Friday, March 21, 2008 - 2:17 am. (8 messages)

Next thread: [PATCH] x86_64: early memtest to find bad ram by Yinghai Lu on Friday, March 21, 2008 - 2:58 am. (20 messages)