login
Header Space

 
 

[PATCH 7/16][BUG] PCI slot: Remove compiler warnings (Not for mainline!)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alex Chiang <achiang@...>, Greg KH <gregkh@...>
Cc: Gary Hade <garyhade@...>, Kristen Carlson Accardi <kristen.c.accardi@...>, Matthew Wilcox <matthew@...>, <warthog19@...>, <rick.jones2@...>, <linux-kernel@...>, <linux-pci@...>, <linux-acpi@...>
Date: Friday, March 21, 2008 - 12:14 am

Remove following compiler warnings.

drivers/pci/slot.c: In function 'pci_create_slot':
drivers/pci/slot.c:146: warning: format '%d' expects type 'int', but argument 4 has type 'atomic_t'
drivers/pci/slot.c: In function 'pci_destroy_slot':
drivers/pci/slot.c:198: warning: format '%d' expects type 'int', but argument 4 has type 'atomic_t'

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

---
 drivers/pci/slot.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Index: linux-2.6.25-rc6/drivers/pci/slot.c
===================================================================
--- linux-2.6.25-rc6.orig/drivers/pci/slot.c
+++ linux-2.6.25-rc6/drivers/pci/slot.c
@@ -142,8 +142,8 @@ struct pci_slot *pci_create_slot(struct 
 		if (slot->number == slot_nr) {
 			kobject_get(&slot->kobj);
 			dbg("%s: bumped refcount to %d on %x:%d\n",
-				__func__, slot->kobj.kref.refcount,
-				parent->number, slot_nr);
+			    __func__, atomic_read(&slot->kobj.kref.refcount),
+			    parent->number, slot_nr);
 			goto out;
 		}
 	}
@@ -196,7 +196,8 @@ int pci_destroy_slot(struct pci_slot *sl
 	up_write(&pci_bus_sem);
 
 	dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
-		slot->kobj.kref.refcount, slot->bus->number, slot->number);
+	    atomic_read(&slot->kobj.kref.refcount), slot->bus->number,
+	    slot->number);
 	return 0;
 }
 EXPORT_SYMBOL_GPL(pci_destroy_slot);


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Alex Chiang, (Tue Mar 18, 5:05 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Fri Mar 21, 12:07 am)
[PATCH 7/16][BUG] PCI slot: Remove compiler warnings (Not f..., Kenji Kaneshige, (Fri Mar 21, 12:14 am)
[PATCH 1/3] Construct one fakephp slot per pci slot, Alex Chiang, (Tue Mar 18, 5:08 pm)
[PATCH 2/3] Introduce pci_slot, Alex Chiang, (Tue Mar 18, 5:09 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Matthew Wilcox, (Tue Mar 18, 8:55 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Tue Mar 18, 10:24 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Tue Mar 18, 10:34 pm)
[PATCH 3/3] ACPI PCI slot detection driver, Alex Chiang, (Tue Mar 18, 5:09 pm)
speck-geostationary