login
Header Space

 
 

[PATCH 3/16][BUG] ACPI pci_slot: Fix _STA evaluation (Not for mainline!)

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alex Chiang <achiang@...>, Greg KH <gregkh@...>
Cc: Gary Hade <garyhade@...>, Kristen Carlson Accardi <kristen.c.accardi@...>, Matthew Wilcox <matthew@...>, <warthog19@...>, <rick.jones2@...>, <linux-kernel@...>, <linux-pci@...>, <linux-acpi@...>
Date: Friday, March 21, 2008 - 12:11 am

Fix the problem that pci slots that doesn't have _STA are not
detected. If the device doesn't have _STA, we must assume it is always
there.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
 drivers/acpi/pci_slot.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.25-rc6/drivers/acpi/pci_slot.c
===================================================================
--- linux-2.6.25-rc6.orig/drivers/acpi/pci_slot.c
+++ linux-2.6.25-rc6/drivers/acpi/pci_slot.c
@@ -76,9 +76,8 @@ check_slot(acpi_handle handle, int *devi
 
 	if (check_sta_before_sun) {
 		/* If SxFy doesn't have _STA, we just assume it's there */
-		acpi_evaluate_integer(handle, "_STA", NULL, &sta);
-
-		if (!(sta & ACPI_STA_DEVICE_PRESENT)) {
+		status = acpi_evaluate_integer(handle, "_STA", NULL, &sta);
+		if (ACPI_SUCCESS(status) && !(sta & ACPI_STA_DEVICE_PRESENT)) {
 			retval = -1;
 			goto out;
 		}


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Alex Chiang, (Tue Mar 18, 5:05 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Fri Mar 21, 12:07 am)
[PATCH 3/16][BUG] ACPI pci_slot: Fix _STA evaluation (Not f..., Kenji Kaneshige, (Fri Mar 21, 12:11 am)
[PATCH 1/3] Construct one fakephp slot per pci slot, Alex Chiang, (Tue Mar 18, 5:08 pm)
[PATCH 2/3] Introduce pci_slot, Alex Chiang, (Tue Mar 18, 5:09 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Matthew Wilcox, (Tue Mar 18, 8:55 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Tue Mar 18, 10:24 pm)
Re: [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects, Kenji Kaneshige, (Tue Mar 18, 10:34 pm)
[PATCH 3/3] ACPI PCI slot detection driver, Alex Chiang, (Tue Mar 18, 5:09 pm)
speck-geostationary