Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64.c and smpboot.c

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Yinghai Lu <yhlu.kernel@...>

To: Glauber Costa <gcosta@...>

Cc: <linux-kernel@...>, <akpm@...>, <tglx@...>, <mingo@...>, <ak@...>

Subject: Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64.c and smpboot.c

Date: Thursday, March 20, 2008 - 2:00 pm

On Thu, Mar 20, 2008 at 7:25 AM, Glauber Costa <gcosta@redhat.com> wrote:
quoted text>
> Yinghai Lu wrote:
>  >>   10 files changed, 25 insertions(+), 16 deletions(-)
>  >
>  > please don't.
>  >
>  > before this patch
>  > include/asm-x86/mach_apic.h is only for x86_64 only
>  > include/asm-x86/mach-default/mach_apic.h is for i386 only.
>  >
>  > and both have __ASM_MACH_APIC_H defined.
>  >
>  > may need another name?
>  >
>  > YH
>  Another name is possible, but I'd prefer to get rid of the
>  asm-x86/mach_apic.h. The goal here is to have things integrated, so
>  unless really necessary, this is prefered.
>
>  Is this related to your problem anyhow? (just in curiosity)

No

YH
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/79] smpboot integration, Glauber de Oliveira Costa..., (Wed Mar 19, 1:24 pm)

Re: [PATCH 0/79] smpboot integration, Ingo Molnar, (Wed Mar 19, 1:35 pm)

Re: [PATCH 0/79] smpboot integration, Yinghai Lu, (Wed Mar 19, 10:18 pm)

Re: [PATCH 0/79] smpboot integration, Yinghai Lu, (Wed Mar 19, 11:00 pm)

Re: [PATCH 0/79] smpboot integration, Yinghai Lu, (Wed Mar 19, 11:32 pm)

Re: [PATCH 0/79] smpboot integration, Glauber Costa, (Thu Mar 20, 12:40 am)

Re: [PATCH 0/79] smpboot integration, Yinghai Lu, (Thu Mar 20, 12:59 am)

Re: [PATCH 0/79] smpboot integration, Ingo Molnar, (Wed Mar 19, 2:48 pm)

Re: [PATCH 0/79] smpboot integration, Ingo Molnar, (Wed Mar 19, 3:36 pm)

[PATCH 01/79] [PATCH] change var types in __inquire_remote_a..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:24 pm)

[PATCH 02/79] [PATCH] add loglevel to printks, Glauber de Oliveira Costa..., (Wed Mar 19, 1:24 pm)

[PATCH 03/79] [PATCH] use apic_*_around instead of apic_writ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:24 pm)

[PATCH 04/79] [PATCH] use start_ipi_hook in x86_64, Glauber de Oliveira Costa..., (Wed Mar 19, 1:24 pm)

[PATCH 05/79] [PATCH] add an smp_apply_quirks to smpboot_32.c, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 06/79] [PATCH] decouple call to print_cpu_info from s..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 07/79] [PATCH] provide specialized identification rou..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 08/79] [PATCH] use identify_boot_cpu, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 09/79] [PATCH] call identify_secondary_cpu in smp_sto..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 10/79] [PATCH] merge smp_store_cpu_info, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 11/79] [PATCH] always enable irqs when entering idle, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 12/79] [PATCH] don't call local_irq_enable before ent..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 13/79] [PATCH] move setup_secondary_clock a little bi..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 14/79] [PATCH] move state update out of ipi_lock, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 15/79] [PATCH] provide APIC_INTEGRATED definition for..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 16/79] [PATCH] use APIC_INTEGRATED tests in x86_64, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 17/79] [PATCH] add barriers statement, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 18/79] [PATCH] isolate sanity checking, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 19/79] [PATCH] isolate logic to disable smp, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 20/79] [PATCH] do tests before do_boot_cpu in i386, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 21/79] [PATCH] make __smp_prepare_cpu void, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 22/79] [PATCH] move assignment of CPU_PREPARE before ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 23/79] [PATCH] unify extern masks declaration, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 24/79] [PATCH] define bios to apicid mapping, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 25/79] [PATCH] initialize map pointers in setup_32.c, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 26/79] [PATCH] make node to apic mapping declarations..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 27/79] [PATCH] fix alloc_bootmem_pages_node macro, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 28/79] [PATCH] use specialized routine for setup per-..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 29/79] [PATCH] fill bios cpu to apicid maps, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 30/79] [PATCH] fill cpu to apicid and present map in ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 31/79] [PATCH] get rid of cpucount, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 32/79] [PATCH] allow user to impress friends., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 33/79] [PATCH] do smp tainting checks in a separate f..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 34/79] [PATCH] move impress_friends and smp_check to ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 35/79] [PATCH] add subarch support (for headers) to x..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 36/79] [PATCH] include mach_wakecpu.h in smpboot_64, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 37/79] [PATCH] include smpboot_hooks.h in smpboot_64.c, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 38/79] [PATCH] move smp_intr_init away from smpboot_3..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 39/79] [PATCH] don't set maps in native_smp_prepare_b..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 40/79] [PATCH] wipe get_nmi_reason out of nmi_64.h, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 41/79] [PATCH] unify nmi_32.h and nmi_64.h, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 42/79] [PATCH] call check_nmi_watchdog explicitly in ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 43/79] [PATCH] call nmi_watchdog_default in i386, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 44/79] [PATCH] don't initialize sibling and core maps..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 45/79] [PATCH] fix apic acking of irqs, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Maciej W. Rozycki, (Thu Mar 20, 6:28 am)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Glauber Costa, (Thu Mar 20, 11:04 am)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Maciej W. Rozycki, (Thu Mar 20, 6:27 pm)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Glauber Costa, (Mon Mar 24, 10:51 am)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Maciej W. Rozycki, (Mon Mar 24, 7:19 pm)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Glauber Costa, (Tue Mar 25, 9:42 am)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Maciej W. Rozycki, (Tue Mar 25, 11:48 am)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Glauber Costa, (Tue Mar 25, 6:39 pm)

Re: [PATCH 45/79] [PATCH] fix apic acking of irqs, Andi Kleen, (Tue Mar 25, 8:40 am)

[PATCH 46/79] [PATCH] schedule work only if keventd is alrea..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 47/79] [PATCH] do not zap_low_mappings in __smp_prepa..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 48/79] [PATCH] boot cpus from cpu_up, instead of prep..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 49/79] [PATCH] get rid of commenced mask., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 50/79] [PATCH] use create_idle struct in do_boot_cpu, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 51/79] [PATCH] don't span a new worker in __smp_prepa..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 52/79] [PATCH] modify smp_callin in x86_64 to look li..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 53/79] [PATCH] wrap esr setting up in i386 in lapic_s..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 54/79] [PATCH] provide an end_local_APIC_setup function, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 55/79] [PATCH] calibrate delay with irqs enabled, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 56/79] [PATCH] minor adjustments for do_boot_cpu, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 57/79] [PATCH] call do_boot_cpu directly from native_..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64.c an..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64...., Yinghai Lu, (Thu Mar 20, 2:56 am)

Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64...., Glauber Costa, (Thu Mar 20, 10:25 am)

Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64...., Yinghai Lu, (Fri Mar 21, 6:37 pm)

Re: [PATCH 58/79] [PATCH] include mach_apic.h in smpboot_64...., Yinghai Lu, (Thu Mar 20, 2:00 pm)

[PATCH 59/79] [PATCH] change wakeup_secondary name, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 60/79] [PATCH] add callin tests to cpu_up, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 61/79] [PATCH] move {un}map_cpu_to_logical_apicid to ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 62/79] [PATCH] move stack_start to smp.h, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 63/79] [PATCH] change boot_cpu_id to boot_cpu_physica..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 64/79] [PATCH] integrate do_boot_cpu, Glauber de Oliveira Costa..., (Wed Mar 19, 1:25 pm)

[PATCH 65/79] [PATCH] integrate start_secondary, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 66/79] [PATCH] merge smp_prepare_boot_cpu, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 67/79] [PATCH] merge native_smp_cpus_done, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 68/79] [PATCH] use physical id when disabling smp, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 69/79] [PATCH] get rid of smp_boot_cpus, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 70/79] [PATCH] additions to i386 native_smp_prepare_c..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 71/79] [PATCH] assign nr_ioapics = 0 in smpboot_hooks.h, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 72/79] [PATCH] change x86_64 native_smp_prepare_cpus ..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 73/79] [PATCH] add extra sanity check, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 74/79] [PATCH] change x86_64 sanity checks to match i..., Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 75/79] [PATCH] introduce smpboot_clear_io_apic, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 76/79] [PATCH] merge native_smp_prepare_cpus, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 77/79] [PATCH] merge cpu_exit_clear, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 78/79] [PATCH] move apicid mappings to smpboot.c, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

[PATCH 79/79] [PATCH] remove smpboot_32.c and smpboot_64.c, Glauber de Oliveira Costa..., (Wed Mar 19, 1:26 pm)

Navigation

Popular discussions


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Benjamin Herrenschmidt	Re: [PATCH] Remove process freezer from suspend to RAM pathway
Greg KH	[patch 00/73] 2.6.23-stable review
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
git:

linux-netdev:
Arjan van de Ven	Re: [GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by:

Online users

Syndicate