Home » Mailing list archives » linux-kernel » 2008 » March » 20

[patch 1/4] x86: vSMP: Fix is_vsmp_box()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ravikiran G Thirumalai <kiran@...>
To: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Glauber de Oliveira Costa <gcosta@...>, Andi Kleen <ak@...>, <shai@...>
Subject: [patch 1/4] x86: vSMP: Fix is_vsmp_box()
Date: Thursday, March 20, 2008 - 3:39 am

is_vsmp_box() currently does not work on vSMPowered systems,  as pci cfg
space is not read correctly -- This patch fixes it.

Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>

Index: linux.git.trees/arch/x86/kernel/vsmp_64.c
===================================================================
--- linux.git.trees.orig/arch/x86/kernel/vsmp_64.c	2008-03-19 13:30:35.116766719 -0700
+++ linux.git.trees/arch/x86/kernel/vsmp_64.c	2008-03-19 13:39:20.074685590 -0700
@@ -84,8 +84,10 @@ int is_vsmp_box(void)
 		return vsmp;
 
 	/* Check if we are running on a ScaleMP vSMP box */
-	if (read_pci_config(0, 0x1f, 0, PCI_VENDOR_ID) ==
-	     (PCI_VENDOR_ID_SCALEMP || (PCI_DEVICE_ID_SCALEMP_VSMP_CTL << 16)))
+	if ((read_pci_config_16(0, 0x1f, 0, PCI_VENDOR_ID) ==
+	     PCI_VENDOR_ID_SCALEMP) &&
+	    (read_pci_config_16(0, 0x1f, 0, PCI_DEVICE_ID) ==
+	    PCI_DEVICE_ID_SCALEMP_VSMP_CTL))
 		vsmp = 1;
 
 	return vsmp;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch 0/4] x86: vSMP updates, Ravikiran G Thirumalai, (Thu Mar 20, 3:37 am)
Re: [patch 0/4] x86: vSMP updates, Ingo Molnar, (Fri Mar 21, 4:54 am)
[patch 4/4] x86: apic_is_clustered_box to indicate unsynched..., Ravikiran G Thirumalai, (Thu Mar 20, 3:45 am)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Yinghai Lu, (Thu Mar 20, 3:53 am)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ravikiran G Thirumalai, (Thu Mar 20, 3:02 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ingo Molnar, (Fri Mar 21, 5:15 am)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ravikiran G Thirumalai, (Fri Mar 21, 2:52 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ingo Molnar, (Fri Mar 21, 2:58 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ravikiran G Thirumalai, (Sat Mar 22, 2:59 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ingo Molnar, (Sat Mar 22, 4:02 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ravikiran G Thirumalai, (Mon Mar 24, 5:48 pm)
Re: [patch 4/4] x86: apic_is_clustered_box to indicate unsyn..., Ingo Molnar, (Tue Mar 25, 11:50 am)
[patch 3/4] x86: vSMP: Use pvops only if platform has the ca..., Ravikiran G Thirumalai, (Thu Mar 20, 3:43 am)
[patch 2/4] x86: Fix build breakage when PCI is define and P..., Ravikiran G Thirumalai, (Thu Mar 20, 3:41 am)
Re: [patch 2/4] x86: Fix build breakage when PCI is define a..., Jeremy Fitzhardinge, (Fri Mar 21, 12:30 am)
Re: [patch 2/4] x86: Fix build breakage when PCI is define a..., Ravikiran G Thirumalai, (Fri Mar 21, 2:54 pm)
Re: [patch 2/4] x86: Fix build breakage when PCI is define a..., Jeremy Fitzhardinge, (Fri Mar 21, 10:19 pm)
Re: [patch 2/4] x86: Fix build breakage when PCI is define a..., Yinghai Lu, (Fri Mar 21, 2:28 am)
[patch 1/4] x86: vSMP: Fix is_vsmp_box(), Ravikiran G Thirumalai, (Thu Mar 20, 3:39 am)
Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box(), Yinghai Lu, (Thu Mar 20, 3:44 am)
Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box(), Ravikiran G Thirumalai, (Thu Mar 20, 2:40 pm)
Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box(), Ingo Molnar, (Fri Mar 21, 5:11 am)
Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box(), Ravikiran G Thirumalai, (Fri Mar 21, 1:59 pm)
Re: [patch 1/4] x86: vSMP: Fix is_vsmp_box(), Yinghai Lu, (Fri Mar 21, 5:17 am)