Home » Mailing list archives » linux-kernel » 2008 » March » 19

[PATCH 1/3] Fix misuse of wakeup flag accessors in serial core

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Rafael J. Wysocki
Subject: [PATCH 1/3] Fix misuse of wakeup flag accessors in serial core
Date: Wednesday, March 19, 2008 - 2:35 pm

From: Alan Stern <stern@rowland.harvard.edu>

This patch (as1059) fixes a mistake in the way the serial core
initializes a device's wakeup settings.  It should use the accessor
routine instead of relying on a macro producing an lvalue.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---

Index: usb-2.6/drivers/serial/serial_core.c
===================================================================
--- usb-2.6.orig/drivers/serial/serial_core.c
+++ usb-2.6/drivers/serial/serial_core.c
@@ -2356,7 +2356,7 @@ int uart_add_one_port(struct uart_driver
 	 */
 	tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev);
 	if (likely(!IS_ERR(tty_dev))) {
-		device_can_wakeup(tty_dev) = 1;
+		device_init_wakeup(tty_dev, 1);
 		device_set_wakeup_enable(tty_dev, 0);
 	} else
 		printk(KERN_ERR "Cannot register tty device on line %d\n",



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Alan Stern, (Wed Mar 19, 7:55 am)
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Andrew Morton, (Wed Mar 19, 11:48 am)
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Greg KH, (Wed Mar 19, 11:57 am)
[PATCH 0/3] PM wakeup flags revisited (was: Re: + pm-conve ..., Rafael J. Wysocki, (Wed Mar 19, 2:33 pm)
[PATCH 1/3] Fix misuse of wakeup flag accessors in serial core, Rafael J. Wysocki, (Wed Mar 19, 2:35 pm)
[PATCH 2/3] PM: Make wakeup flags available whenever CONFI ..., Rafael J. Wysocki, (Wed Mar 19, 2:37 pm)
[PATCH 3/3] PM: Convert wakeup flag accessors to inline fu ..., Rafael J. Wysocki, (Wed Mar 19, 2:39 pm)
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Alan Stern, (Wed Mar 19, 2:46 pm)
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Rafael J. Wysocki, (Wed Mar 19, 2:55 pm)
Re: + pm-convert-wakeup-flag-accessors-to-inline-functions ..., Alan Stern, (Wed Mar 19, 3:04 pm)
Re: [linux-pm] [PATCH 2/3] PM: Make wakeup flags available ..., David Brownell, (Wed Mar 19, 3:22 pm)
patch pm-convert-wakeup-flag-accessors-to-inline-functions ..., gregkh, (Thu Mar 20, 4:23 pm)
patch pm-fix-misuse-of-wakeup-flag-accessors-in-serial-cor ..., gregkh, (Thu Mar 20, 4:23 pm)
patch pm-make-wakeup-flags-available-whenever-config_pm-is ..., gregkh, (Thu Mar 20, 4:23 pm)