linux-kernel mailing list

FromSubjectsort iconDate
Jeremy Fitzhardinge
[PATCH 03 of 31] x86: convert pgalloc_64.h from macros t ...
Convert asm-x86/pgalloc_64.h from macros into functions (#include hell prevents __*_free_tlb from being inline, but they're probably a bit big to inline anyway). Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/init_64.c | 16 ++++++++++++++++ include/asm-x86/pgalloc_64.h | 33 ++++++++++++++++++--------------- 2 files changed, 34 insertions(+), 15 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c --- ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 24 of 31] xen: add support for callbackops hypercall
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- include/asm-x86/xen/hypercall.h | 6 ++ include/asm-x86/xen/interface.h | 4 + include/xen/interface/callback.h | 102 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 112 insertions(+) diff --git a/include/asm-x86/xen/hypercall.h b/include/asm-x86/xen/hypercall.h --- a/include/asm-x86/xen/hypercall.h +++ b/include/asm-x86/xen/hypercall.h @@ -161,6 +161,12 @@ return _hypercall4(int, set_callbacks, ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 29 of 31] xen: short-cut for recursive event handling
If an event comes in while events are currently being processed, then just increment the counter and have the outer event loop reprocess the pending events. This prevents unbounded recursion on heavy event loads (of course massive event storms will cause infinite loops). Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/events.c | 46 ++++++++++++++++++++++++++++++---------------- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 25 of 31] x86: only enable interrupts when kernel ...
The sysenter path tries to enable interrupts immediately. Unfortunately this doesn't work in a paravirt environment, because not enough kernel state has been set up at that point (namely, pointing %fs to the kernel percpu data segment). To fix this, defer ENABLE_INTERRUPTS until after the kernel state has been set up. Unfortunately this means that we're running with interrupts disabled for a while without calling the IRQ tracing code, but that can't be called without setting up %fs ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 21 of 31] xen: make sure iret faults are trapped
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/kernel/entry_32.S | 2 +- arch/x86/xen/xen-asm.S | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel/entry_32.S @@ -411,7 +411,7 @@ irq_return: INTERRUPT_RETURN .section .fixup,"ax" -iret_exc: +ENTRY(iret_exc) pushl $0 # no error code pushl ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 17 of 31] xen: make use of pte_t union
pte_t always contains a "pte" field for the whole pte value, so make use of it. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/mmu.c | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -216,12 +216,10 @@ pteval_t xen_pte_val(pte_t pte) { - pteval_t ret = 0; + pteval_t ret = pte.pte; - if (pte.pte_low) ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 19 of 31] xen: use phys_addr_t when referring to ...
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- include/xen/page.h | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/include/xen/page.h b/include/xen/page.h --- a/include/xen/page.h +++ b/include/xen/page.h @@ -8,27 +8,15 @@ #include <xen/features.h> -#ifdef CONFIG_X86_PAE /* Xen machine address */ typedef struct xmaddr { - unsigned long long maddr; + phys_addr_t maddr; } xmaddr_t; /* Xen pseudo-physical address ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 28 of 31] xen: make sure retriggered events are s ...
retrigger_dynirq() was incomplete, and didn't properly set the event to be pending again. It doesn't seem to actually get used. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/events.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/x86/xen/events.c b/arch/x86/xen/events.c --- a/arch/x86/xen/events.c +++ b/arch/x86/xen/events.c @@ -601,10 +601,16 @@ static int retrigger_dynirq(unsigned int irq) { int evtchn = ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 09 of 31] x86: move all the pgd_list handling to ...
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/pgtable.c | 28 +++++++--------------------- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -43,34 +43,31 @@ #endif /* PAGETABLE_LEVELS > 3 */ #endif /* PAGETABLE_LEVELS > 2 */ -#ifdef CONFIG_X86_64 static inline void pgd_list_add(pgd_t *pgd) { struct page *page = ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 00 of 31] x86: unification and xen updates
Hi Ingo, This is a great big pile of x86 unification and Xen bugfix patches. They build and boot for me on 64-bit and 32-bit (PAE and non-PAE). Patches are based on x86.git#testing as of this morning. The overview: - a couple of Xen bugfixes, which are 2.6.24 and 2.6.25 material - a bunch of x86 cleanups and unifications, mostly around pgalloc - some Xen fixes and improvements: - unify PAE/non-PAE pagetable handling - implement sysenter where applicable Thanks, J --
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 16 of 31] xen: use appropriate pte types
Convert Xen pagetable handling to use appropriate *val_t types. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/mmu.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -214,35 +214,35 @@ xen_set_pmd(pmdp, __pmd(0)); } -unsigned long long xen_pte_val(pte_t pte) +pteval_t xen_pte_val(pte_t pte) ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 01 of 31] xen: fix RMW when unmasking events
xen_irq_enable_direct and xen_sysexit were using "andw $0x00ff, XEN_vcpu_info_pending(vcpu)" to unmask events and test for pending ones in one instuction. Unfortunately, the pending flag must be modified with a locked operation since it can be set by another CPU, and the unlocked form of this operation was causing the pending flag to get lost, allowing the processor to return to usermode with pending events and ultimately deadlock. The simple fix would be to make it a locked operation, but ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 23 of 31] x86: unify pgd ctor/dtor
All pagetables need fundamentally the same setup and destruction, so just use the same code for everything. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> Cc: Andi Kleen <ak@suse.de> --- arch/x86/mm/pgtable.c | 59 +++++++++--------------------------------- include/asm-x86/pgtable.h | 16 +++++++++++ include/asm-x86/pgtable_32.h | 15 ---------- include/asm-x86/pgtable_64.h | 2 - 4 files changed, 30 insertions(+), 62 deletions(-) diff --git ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 05 of 31] x86: put paravirt stubs into common asm ...
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/pageattr.c | 2 -- include/asm-x86/pgalloc.h | 10 ++++++++++ include/asm-x86/pgalloc_32.h | 10 ---------- 3 files changed, 10 insertions(+), 12 deletions(-) diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -479,9 +479,7 @@ goto out_unlock; pbase = (pte_t *)page_address(base); -#ifdef CONFIG_X86_32 ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 14 of 31] x86/pgtable.h: demacro ptep_clear_flush_young
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/pgtable.c | 12 ++++++++++++ include/asm-x86/pgtable.h | 10 ++-------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -277,3 +277,15 @@ return ret; } + +int ptep_clear_flush_young(struct vm_area_struct *vma, + unsigned long address, pte_t *ptep) +{ + int ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 08 of 31] x86: move pgalloc pud and pgd operation ...
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/init_64.c | 5 ---- arch/x86/mm/pgtable.c | 7 +++++ include/asm-x86/pgalloc.h | 52 +++++++++++++++++++++++++++++++++++++----- include/asm-x86/pgalloc_32.h | 24 ------------------- include/asm-x86/pgalloc_64.h | 29 ----------------------- 5 files changed, 53 insertions(+), 64 deletions(-) diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c --- ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA
Mask MCE/MCA out of cpu caps. Its harmless to leave them there, but it does prevent the kernel from starting an unnecessary thread. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/enlighten.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -155,6 +155,8 @@ if (*ax == 1) maskedx = ~((1 << X86_FEATURE_APIC) | /* disable ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 26 of 31] xen: support sysenter/sysexit if hyperv ...
64-bit Xen supports sysenter for 32-bit guests, so support its use. (sysenter is faster than int $0x80 in 32-on-64.) sysexit is still not supported, so we fake it up using iret. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/kernel/entry_32.S | 18 +++++++++++++- arch/x86/xen/enlighten.c | 3 -- arch/x86/xen/setup.c | 21 ++++++++++++++++ arch/x86/xen/smp.c | 1 arch/x86/xen/xen-asm.S | 56 ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 12 of 31] x86/pgtable.h: demacro ptep_set_access_flags
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/pgtable.c | 16 ++++++++++++++++ include/asm-x86/pgtable.h | 13 +++---------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -1,5 +1,6 @@ #include <linux/mm.h> #include <asm/pgalloc.h> +#include <asm/pgtable.h> #include <asm/tlb.h> pte_t *pte_alloc_one_kernel(struct ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 07 of 31] x86: move pmd functions into common asm ...
Common definitions for 3-level pagetable functions. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/init_64.c | 5 ----- arch/x86/mm/pgtable.c | 8 ++++++++ arch/x86/mm/pgtable_32.c | 10 ---------- include/asm-x86/pgalloc.h | 33 +++++++++++++++++++++++++++++++++ include/asm-x86/pgalloc_32.h | 32 -------------------------------- include/asm-x86/pgalloc_64.h | 24 ------------------------ 6 files changed, 41 ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 13 of 31] x86/pgtable.h: demacro ptep_test_and_cl ...
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/pgtable.c | 15 +++++++++++++++ include/asm-x86/pgtable.h | 11 ++--------- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -262,3 +262,18 @@ return changed; } + +int ptep_test_and_clear_young(struct vm_area_struct *vma, + unsigned long addr, pte_t *ptep) +{ + int ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 22 of 31] x86: unify KERNEL_PGD_PTRS
Make KERNEL_PGD_PTRS common, as previously it was only being defined for 32-bit. There are a couple of follow-on changes from this: - KERNEL_PGD_PTRS was being defined in terms of USER_PGD_PTRS. The definition of USER_PGD_PTRS doesn't really make much sense on x86-64, since it can have two different user address-space configurations. I renamed USER_PGD_PTRS to KERNEL_PGD_BOUNDARY, which is meaningful for all of 32/32, 32/64 and 64/64 process configurations. - USER_PTRS_PER_PGD ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 18 of 31] xen: unify pte operations
We can fold the essentially common pte functions together now. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/mmu.c | 125 ++++++++++++++++++---------------------------------- 1 file changed, 44 insertions(+), 81 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -171,6 +171,49 @@ xen_set_pte(ptep, pteval); } +pteval_t xen_pte_val(pte_t pte) +{ + pteval_t ret = ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 20 of 31] xen: unify pte operations on machine frames
Xen's pte operations on mfns can be unified like the kernel's pfn operations. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- include/xen/page.h | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/include/xen/page.h b/include/xen/page.h --- a/include/xen/page.h +++ b/include/xen/page.h @@ -125,37 +125,37 @@ #define virt_to_mfn(v) (pfn_to_mfn(PFN_DOWN(__pa(v)))) #define mfn_to_virt(m) (__va(mfn_to_pfn(m) << ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 10 of 31] x86: rename paravirt_alloc_pt etc after ...
Rename (alloc|release)_(pt|pd) to pte/pmd to explicitly match the name of the appropriate pagetable level structure. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/kernel/paravirt.c | 10 +++++----- arch/x86/kernel/vmi_32.c | 20 ++++++++++---------- arch/x86/mm/init_32.c | 6 +++--- arch/x86/mm/ioremap.c | 2 +- arch/x86/mm/pageattr.c | 2 +- arch/x86/mm/pgtable.c | 16 ++++++++-------- arch/x86/xen/enlighten.c | 30 ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 04 of 31] x86: add common mm/pgtable.c
Add a common arch/x86/mm/pgtable.c file for common pagetable functions. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/Makefile | 2 arch/x86/mm/pgtable.c | 239 ++++++++++++++++++++++++++++++++++++++++++ arch/x86/mm/pgtable_32.c | 187 -------------------------------- include/asm-x86/pgalloc.h | 18 +++ include/asm-x86/pgalloc_32.h | 11 - include/asm-x86/pgalloc_64.h | 67 ----------- 6 files changed, 258 insertions(+), ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 06 of 31] x86: move pte functions into common asm ...
Common definitions for 2-level pagetable functions. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/mm/init_64.c | 6 ------ arch/x86/mm/pgtable.c | 7 +++++++ arch/x86/mm/pgtable_32.c | 7 ------- include/asm-x86/pgalloc.h | 16 ++++++++++++++++ include/asm-x86/pgalloc_32.h | 18 ------------------ include/asm-x86/pgalloc_64.h | 16 ---------------- 6 files changed, 23 insertions(+), 47 deletions(-) diff --git ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 02 of 31] xen: fix UP setup of shared_info
We need to set up the shared_info pointer once we've mapped the real shared_info into its fixmap slot. That needs to happen once the general pagetable setup has been done. Previously, the UP shared_info was set up one in xen_start_kernel, but that was left pointing to the dummy shared info. Unfortunately there's no really good place to do a later setup of the shared_info in UP, so just do it once the pagetable setup has been done. [ Stable: needed in 2.6.24.x ] Signed-off-by: Jeremy ...
Mar 17, 4:36 pm 2008
Jeremy Fitzhardinge
[PATCH 15 of 31] x86: demacro pgalloc paravirt stubs
Turn paravirt stubs into inline functions, so that the arguments are still typechecked. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- include/asm-x86/pgalloc.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/include/asm-x86/pgalloc.h b/include/asm-x86/pgalloc.h --- a/include/asm-x86/pgalloc.h +++ b/include/asm-x86/pgalloc.h @@ -8,13 +8,14 @@ #ifdef CONFIG_PARAVIRT #include <asm/paravirt.h> #else -#define ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 11 of 31] x86: add pud_alloc for 4-level pagetables
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/kernel/paravirt.c | 2 ++ arch/x86/mm/pgtable.c | 1 + include/asm-x86/paravirt.h | 11 +++++++++++ include/asm-x86/pgalloc.h | 3 +++ 4 files changed, 17 insertions(+) diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -385,8 +385,10 @@ .alloc_pte = paravirt_nop, .alloc_pmd = paravirt_nop, ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 27 of 31] xen: implement a debug-interrupt handler
Xen supports the notion of a debug interrupt which can be triggered from the console. For now this is implemented to show pending events, masks and each CPU's pending event set. Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/xen/events.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ arch/x86/xen/smp.c | 19 ++++++++++++++----- arch/x86/xen/xen-ops.h | 3 +++ 3 files changed, 64 insertions(+), 5 deletions(-) diff --git ...
Mar 17, 4:37 pm 2008
Jeremy Fitzhardinge
[PATCH 31 of 31] xen: jump to iret fixup
Use jmp rather than call for the iret fixup, so its consistent with the sysexit fixup, and it simplifies the stack (which is already complex). Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> --- arch/x86/kernel/entry_32.S | 3 +-- arch/x86/xen/xen-asm.S | 22 +++++++++------------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S --- a/arch/x86/kernel/entry_32.S +++ ...
Mar 17, 4:37 pm 2008
Frank Mayhar
[PATCH 2.6.25-rc6 resubmit] Add a "show workqueues" SYSR ...
Per Randy, I've added an update to Documentation/sysrq.txt and am resubmitting the patch in the proper style. This patch adds a convenient function to show all workqueues using the magic SYSRQ handling. It uses the 'z' key to invoke the function as the 'w' key was already gone. I've found this very useful in debugging; hopefully others will find it as useful. diffstat wq.patch drivers/char/sysrq.c | 14 +++++++++++++- include/linux/workqueue.h | 1 + kernel/workqueue.c ...
Mar 17, 4:50 pm 2008
Jan Engelhardt
vfree with spin_lock_bh
[Empty message]
Mar 17, 4:30 pm 2008
Sabuj Pattanayek
kernel exception in Fusion MPT base driver 3.04.06 (linu ...
Hi, I'm running (uname -a): Linux porpoise 2.6.24.3 #11 Mon Mar 17 17:24:30 CDT 2008 ppc64 PPC970FX, altivec supported RackMac3,1 GNU/Linux on an Apple Xserve G5. With the following fibre channel card (lspci -vvv, it has two fibre connections): 0001:06:03.0 Fibre Channel: LSI Logic / Symbios Logic FC929X Fibre Channel Adapter (rev 81) Subsystem: LSI Logic / Symbios Logic Unknown device 10d0 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- ...
Mar 17, 4:29 pm 2008
Andreas Schwab
Re: RFC: /dev/stdin, symlinks & permissions
This has nothing to do with /dev/stdout. Your terminal simply does not allow access by anyone except user root or group tty. You need to open it up first, or mount /dev/pts with broader permissions (which is a bad idea however). Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." --
Mar 17, 4:54 pm 2008
Michael Tokarev
RFC: /dev/stdin, symlinks & permissions
I just come across an.. interesting (to me anyway) issue. There are files - /dev/stdin, /dev/stdout & /dev/stderr - which are handy sometimes and are available on several *nix variants (including at least Solaris). On Linux they're usually "implemented" as symlinks pointed to /proc/self/fd/{0,1,2}, respectively. Which, in turn, are symlinks pointing to the actual files. For example, in a root ssh session, /dev/stdin may look like (omitting details): # ls -l /dev/stdin /dev/stdin ...
Mar 17, 4:26 pm 2008
Rene Herman
Re: ehci-hcd affects hda speed
Just something like this? Completely untested as I've not the hardware anymore. Googling for an old lspci, I had a revision 0x63, and Lev has a revision 0x65. The VT6212(L) should be 0x60+ it seems. The "CC:" should be a "Tested-by:" if that's actually the case. But yes, as he also asked, should this be the fix at all? Rene.
Mar 17, 4:23 pm 2008
Rene Herman
Re: ehci-hcd affects hda speed
And, as usual, I can not reach Lev as some mailer along the way is telling me his address is unroutable. Rene. --
Mar 17, 4:26 pm 2008
Randy Dunlap
Re: [PATCH 2.6.25-rc6] Add a "show workqueues" SYSRQ knob.
Missing update to Documentation/sysrq.txt. Patch description, diffstat, & sob should come before the patch. And I propose that we reserve sysrq-j for extending sysrq keys in the --- ~Randy --
Mar 17, 4:32 pm 2008
Frank Mayhar
[PATCH 2.6.25-rc6] Add a "show workqueues" SYSRQ knob.
This patch adds a convenient function to show all workqueues using the magic SYSRQ handling. It uses the 'z' key to invoke the function as the 'w' key was already gone. I've found this very useful in debugging; hopefully others will find it as useful. diff --git a/drivers/char/sysrq.c b/drivers/char/sysrq.c index de60e1e..733d625 100644 --- a/drivers/char/sysrq.c +++ b/drivers/char/sysrq.c @@ -243,6 +243,18 @@ static struct sysrq_key_op sysrq_showmem_op = { .enable_mask = ...
Mar 17, 4:19 pm 2008
Jonathan Corbet
[PATCH] de-semaphorize smackfs
While looking at the generic semaphore patch, I came to wonder what the remaining semaphore users in the kernel were actually doing. After a quick grep for down_interruptible(), smackfs remained at the bottom of my screen. It seems like a straightforward mutex case - low-hanging fruit. So here's a conversion patch; compile-tested only, but what could go wrong? jon Convert smackfs from a semaphore to a mutex Signed-off-by: Jonathan Corbet <corbet@lwn.net> diff --git ...
Mar 17, 4:14 pm 2008
Glauber Costa
[PATCH] vsmp build fixes
VSMP depends on PCI, but the file is now compiled conditionally on PARAVIRT, no VSMP, so enclose everything in an ifdef CONFIG_PCI. We have to be careful enough to let is_vsmp_box and vsmp_init defined, since they are used outside this file Signed-off-by: Glauber Costa <gcosta@redhat.com> CC: Ravikiran Thirumalai <kiran@scalemp.com> --- arch/x86/kernel/vsmp_64.c | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/arch/x86/kernel/vsmp_64.c ...
Mar 17, 2:30 pm 2008
Yinghai Lu Mar 17, 2:18 pm 2008
Adrian Bunk
[2.6 patch] x86: remove the write-only timer_uses_ioapic_pin_0
This patch removes the write-only timer_uses_ioapic_pin_0 (gsi can't be <= 15 in the line of it's fake usage in mpparse_32.c). Spotted by the GNU C compiler. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- arch/x86/kernel/io_apic_32.c | 5 ----- arch/x86/kernel/mpparse_32.c | 3 +-- include/asm-x86/io_apic.h | 1 - 3 files changed, 1 insertion(+), 8 deletions(-) 5869ec6906fdb6d786284c599c862061f601ac6a diff --git a/arch/x86/kernel/io_apic_32.c ...
Mar 17, 1:29 pm 2008
Eric Paris
Re: [2.6 patch] make selinux_parse_opts_str() static
Ack-ed by: Eric Paris <eparis@redhat.com> --
Mar 17, 2:36 pm 2008
Adrian Bunk
[2.6 patch] make selinux_parse_opts_str() static
This patch makes the needlessly global selinux_parse_opts_str() static. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- 42740a04634e3a4362a688b29ad31ee87c940ff7 diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 4bf4807..41a049f 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -800,7 +800,8 @@ static void selinux_sb_clone_mnt_opts(const struct super_block *oldsb, mutex_unlock(&newsbsec->lock); } -int selinux_parse_opts_str(char *options, ...
Mar 17, 1:29 pm 2008
James Morris
Re: [2.6 patch] make selinux_parse_opts_str() static
ITYM Acked-by :-) -- James Morris <jmorris@namei.org> --
Mar 17, 3:32 pm 2008
Miklos Szeredi
[patch 02/11] unprivileged mounts: allow unprivileged umount
From: Miklos Szeredi <mszeredi@suse.cz> The owner doesn't need sysadmin capabilities to call umount(). Similar behavior as umount(8) on mounts having "user=UID" option in /etc/mtab. The difference is that umount also checks /etc/fstab, presumably to exclude another mount on the same mountpoint. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn <serue@us.ibm.com> --- fs/namespace.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 09/11] unprivileged mounts: propagation: inherit ...
From: Miklos Szeredi <mszeredi@suse.cz> On mount propagation, let the owner of the clone be inherited from the parent into which it has been propagated. If the parent has the "nosuid" flag, set this flag for the child as well. This is needed for the suid-less namespace (use case #2 in the first patch header), where all mounts are owned by the user and have the nosuid flag set. In this case the propagated mount needs to have nosuid, otherwise a suid executable may be misused by the ...
Mar 17, 1:01 pm 2008
Miklos Szeredi
[patch 11/11] unprivileged mounts: copy mount ownership ...
From: Miklos Szeredi <mszeredi@suse.cz> Mount ownership wasn't copied on CLONE_NEWNS. Noticed by Al Viro. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- fs/namespace.c | 7 ++++++- fs/pnode.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) Index: linux/fs/namespace.c =================================================================== --- linux.orig/fs/namespace.c 2008-03-17 20:55:53.000000000 +0100 +++ linux/fs/namespace.c 2008-03-17 20:55:53.000000000 +0100 @@ ...
Mar 17, 1:01 pm 2008
Miklos Szeredi
[patch 05/11] unprivileged mounts: allow unprivileged bi ...
From: Miklos Szeredi <mszeredi@suse.cz> Allow bind mounts to unprivileged users if the following conditions are met: - mountpoint is not a symlink - parent mount is owned by the user - the number of user mounts is below the maximum Unprivileged mounts imply MS_SETUSER, and will also have the "nosuid" and "nodev" mount flags set. In particular, if mounting process doesn't have CAP_SETUID capability, then the "nosuid" flag will be added, and if it doesn't have CAP_MKNOD capability, ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 06/11] unprivileged mounts: allow unprivileged mounts
From: Miklos Szeredi <mszeredi@suse.cz> For "safe" filesystems allow unprivileged mounting and forced unmounting. A filesystem type is considered "safe", if mounting it by an unprivileged user may not cause a security problem. This is somewhat subjective, so setting this property is left to userspace (implemented in the next patch). Since most filesystems haven't been designed with unprivileged mounting in mind, a thorough audit is recommended before setting this property. Make this a ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 04/11] unprivileged mounts: account user mounts
From: Miklos Szeredi <mszeredi@suse.cz> Add sysctl variables for accounting and limiting the number of user mounts. The maximum number of user mounts is set to 1024 by default. This won't in itself enable user mounts, setting a mount to be owned by a user is first needed. [akpm] - don't use enumerated sysctls Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn <serue@us.ibm.com> --- Documentation/filesystems/proc.txt | 9 ++++ fs/namespace.c ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 03/11] unprivileged mounts: propagate error value ...
From: Miklos Szeredi <mszeredi@suse.cz> Allow clone_mnt() to return errors other than ENOMEM. This will be used for returning a different error value when the number of user mounts goes over the limit. Fix copy_tree() to return EPERM for unbindable mounts. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn <serue@us.ibm.com> --- fs/namespace.c | 95 ++++++++++++++++++++++++++++----------------------------- fs/pnode.c | 5 +-- 2 files changed, 51 ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 00/11] mount ownership and unprivileged mount sys ...
Andrew, Al, Please consider adding this series to your trees. I've been using these patches for a while on my laptop to mount fuse filesystems as user, without any suid-root helpers. The setup is as follows: - link /proc/mounts to /etc/mtab - patch util-linux-ng with http://lkml.org/lkml/2008/1/16/103 - remove suid from mount, umount and fusermount - add a line to /etc/fstab to bind mount ~/mnt onto itself owned by the user - add 'fs.types.fuse.usermount_safe = 1' to ...
Mar 17, 1:00 pm 2008
James Morris
Re: [patch 00/11] mount ownership and unprivileged mount ...
Something to consider down the track would be how to possibly allow this with SELinux, which only knows about normal mounts. We might need a user_mount hook which is called once the core kernel code determines that it is a a valid unprivileged mount (although the sb_mount hook will already have been called, IIUC). - James -- James Morris <jmorris@namei.org> --
Mar 17, 3:51 pm 2008
Miklos Szeredi
[patch 01/11] unprivileged mounts: add user mounts to th ...
From: Miklos Szeredi <mszeredi@suse.cz> This patchset adds support for keeping mount ownership information in the kernel, and allow unprivileged mount(2) and umount(2) in certain cases. The mount owner has the following privileges: - unmount the owned mount - create a submount under the owned mount The sysadmin can set the owner explicitly on mount and remount. When an unprivileged user creates a mount, then the owner is automatically set to the user. The following use cases are ...
Mar 17, 1:00 pm 2008
Miklos Szeredi
[patch 08/11] unprivileged mounts: make fuse safe
From: Miklos Szeredi <mszeredi@suse.cz> Don't require the "user_id=" and "group_id=" options for unprivileged mounts, but if they are present, verify them for sanity. Disallow the "allow_other" option for unprivileged mounts. Document new way of enabling unprivileged mounts for fuse. Document problems with unprivileged mounts. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn <serue@us.ibm.com> --- Documentation/filesystems/fuse.txt | 88 ...
Mar 17, 1:01 pm 2008
Miklos Szeredi
[patch 07/11] unprivileged mounts: add sysctl tunable fo ...
From: Miklos Szeredi <mszeredi@suse.cz> Add the following: /proc/sys/fs/types/${FS_TYPE}/usermount_safe Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn <serue@us.ibm.com> --- Documentation/filesystems/proc.txt | 31 +++++++++++++++++++ fs/filesystems.c | 60 +++++++++++++++++++++++++++++++++++++ include/linux/fs.h | 1 3 files changed, 92 insertions(+) Index: ...
Mar 17, 1:01 pm 2008
Miklos Szeredi
[patch 10/11] unprivileged mounts: add "no submounts" flag
From: Miklos Szeredi <mszeredi@suse.cz> Add a new mount flag "nosubmnt", which denies submounts for the owner. This would be useful, if we want to support traditional /etc/fstab based user mounts. In this case mount(8) would still have to be suid-root, to check the mountpoint against the user/users flag in /etc/fstab, but /etc/mtab would no longer be mandatory for storing the actual owner of the mount. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Acked-by: Serge Hallyn ...
Mar 17, 1:01 pm 2008
Adrian Bunk
[2.6.25 patch] acpi_drivers.h: fix dock dummy functions
Built-in code can't use functions in a modular ACPI dock driver. This patch fixes the following build error reported by Thomas Meyer: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o: In function `ata_acpi_associate': (.text+0x7106a): undefined reference to `register_hotplug_dock_device' drivers/built-in.o: In function `ata_acpi_associate': (.text+0x710bd): undefined reference to `register_hotplug_dock_device' make: *** [.tmp_vmlinux1] Fehler 1 <-- snip ...
Mar 17, 1:30 pm 2008
Thomas Meyer
In function `ata_acpi_associate': undefined reference to ...
$ git describe v2.6.25-rc6-14-gbde4f8f $ make CHK include/linux/version.h CHK include/linux/utsrelease.h CALL scripts/checksyscalls.sh CHK include/linux/compile.h LD vmlinux.o MODPOST vmlinux.o WARNING: modpost: Found 14 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD ...
Mar 17, 12:41 pm 2008
Adrian Bunk
Re: In function `ata_acpi_associate': undefined referenc ...
-ENODOTCONFIG cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --
Mar 17, 12:48 pm 2008
Thomas Meyer
Re: In function `ata_acpi_associate': undefined referenc ...
# # Automatically generated make config: don't edit # Linux kernel version: 2.6.25-rc6 # Mon Mar 17 20:14:26 2008 # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X86=y # CONFIG_GENERIC_LOCKBREAK is not ...
Mar 17, 12:58 pm 2008
Grant Likely
Re: powerpc: cuImage.* creation error
Looks like I added a bogus target (no dts file for the board yet) and didn't match correctly the init code for the other two. Please try this: --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -253,7 +253,6 @@ image-$(CONFIG_TQM8540) += cuImage.tqm85 image-$(CONFIG_TQM8541) += cuImage.tqm8541 image-$(CONFIG_TQM8555) += cuImage.tqm8555 image-$(CONFIG_TQM8560) += ...
Mar 17, 3:39 pm 2008
Paul Gortmaker
Re: powerpc: cuImage.* creation error
In message: powerpc: cuImage.* creation error Untested, but I'll guess that this is at least part of the problem for the sbc one... Thanks, Paul. --- Author: Paul Gortmaker <paul.gortmaker@windriver.com> Date: Mon Mar 17 15:47:03 2008 -0400 cuimage: fix board names in Makefile Fix the copy and paste error from 25431333813686654907ab987fb5de10c10a16db for the sbc8548 and sbc8560 Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> diff --git ...
Mar 17, 1:07 pm 2008
Adrian Bunk
Re: powerpc: cuImage.* creation error
It doesn't fix the build, and adds sbc8560_defconfig to the list of non-compiling defconfigs: <-- snip --> ... WRAP arch/powerpc/boot/cuImage.sbc8560 DTC: dts->dtb on file "/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/dts/sbc8560.dts" powerpc64-linux-ld: arch/powerpc/boot/cuboot-sbc8560.o: No such file: No such file or directory make[2]: *** [arch/powerpc/boot/cuImage.sbc8560] Error 1 cu Adrian -- "Is there not promise of rain?" Ling Tan asked ...
Mar 17, 3:23 pm 2008
Paul Gortmaker
Re: powerpc: cuImage.* creation error
In message: Re: powerpc: cuImage.* creation error You should have both the sbc8548.dts and the sbc8560.dts in your tree. They have been in there for several weeks now. I just tested with the above here, and I was just about to hit send on this extra chunk to fix the second half of the problem. Note that I didn't lump the tqm8540 in with the other tqm, because the defconfig tends to indicate it doesn't need 85xx-cpm2; just 85xx. Thanks, Paul. -- Author: Paul Gortmaker ...
Mar 17, 3:46 pm 2008
Grant Likely
Re: powerpc: cuImage.* creation error
On Mon, Mar 17, 2008 at 4:46 PM, Paul Gortmaker Heh; oops. I looked but somehow missed them. I guess I didn't look hard enough. Acked-by: Grant Likely <grant.likely@secretlab.ca> Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 4:22 pm 2008
Grant Likely
Re: powerpc: cuImage.* creation error
I may have messed something up. I'll dig into it this afternoon. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 12:39 pm 2008
Grant Likely
Re: powerpc: cuImage.* creation error
On Mon, Mar 17, 2008 at 2:07 PM, Paul Gortmaker No, the suffix in the cuImage targets has a 1:1 relationship with dts files in arch/powerpc/boot/dts/. If a file doesn't exist there, then the target cannot be built. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 3:41 pm 2008
Adrian Bunk
powerpc: cuImage.* creation error
When building all powerpc defconfigs in 2.6.25-rc6 exactly three of them fail to build, and all with similar problems: mpc85xx_defconfig: <-- snip --> ... WRAP arch/powerpc/boot/cuImage.tqm8540 DTC: dts->dtb on file "/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/dts/tqm8540.dts" powerpc64-linux-ld: arch/powerpc/boot/cuboot-tqm8540.o: No such file: No such file or directory make[2]: *** [arch/powerpc/boot/cuImage.tqm8540] Error 1 <-- snip ...
Mar 17, 12:36 pm 2008
Yang, Bo
RE: [PATCH 4/4] scsi: megaraid_sas - Update the Version ...
James, Sure I will send more details. Thanks. Bo Yang -----Original Message----- From: James Bottomley [mailto:James.Bottomley@HansenPartnership.com] Sent: Monday, March 17, 2008 4:55 PM To: Yang, Bo Cc: linux-scsi@vger.kernel.org; akpm@osdl.org; linux-kernel@vger.kernel.org; Patro, Sumant; Kolli, Neela Subject: Re: [PATCH 4/4] scsi: megaraid_sas - Update the Version andChangelog It would be nice if the git change log were this detailed, as well Where did this change come ...
Mar 17, 2:00 pm 2008
bo yang
[PATCH 4/4] scsi: megaraid_sas - Update the Version and ...
Update the Version and ChangeLog Signed-off-by Bo Yang<bo.yang@lsi.com> --- Documentation/scsi/ChangeLog.megaraid_sas | 22 ++++++++++++++++++++ drivers/scsi/megaraid/megaraid_sas.c | 2 - drivers/scsi/megaraid/megaraid_sas.h | 6 ++--- 3 files changed, 26 insertions(+), 4 deletions(-) diff -rupN linux-2.6.24_orig/Documentation/scsi/ChangeLog.megaraid_sas linux-2.6.24_new/Documentation/scsi/ChangeLog.megaraid_sas --- ...
Mar 17, 1:18 am 2008
bo yang
[PATCH 3/4] scsi: megaraid_sas - Add the new controller ...
Add the new Controller (ID: 007C) support to driver. Signed-off-by Bo Yang<bo.yang@lsi.com> --- drivers/scsi/megaraid/megaraid_sas.c | 7 +++++-- drivers/scsi/megaraid/megaraid_sas.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff -rupN linux-2.6.24_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.24_new/drivers/scsi/megaraid/megaraid_sas.c --- linux-2.6.24_orig/drivers/scsi/megaraid/megaraid_sas.c 2008-03-17 13:53:49.000000000 -0400 +++ ...
Mar 17, 1:13 am 2008
bo yang
[PATCH 2/4] scsi: megaraid_sas - Fix the frame count cal ...
Driver sent the wrong frame count to firmware. This patch fixed the frame count calculation. Signed-off-by Bo Yang<bo.yang@lsi.com> --- drivers/scsi/megaraid/megaraid_sas.c | 31 ++++++++++++++++--------- drivers/scsi/megaraid/megaraid_sas.h | 4 +++ 2 files changed, 25 insertions(+), 10 deletions(-) diff -rupN linux-2.6.24_orig/drivers/scsi/megaraid/megaraid_sas.c linux-2.6.24_new/drivers/scsi/megaraid/megaraid_sas.c --- ...
Mar 17, 12:36 am 2008
James Bottomley
Re: [PATCH 4/4] scsi: megaraid_sas - Update the Version ...
It would be nice if the git change log were this detailed, as well Where did this change come from? It's not in any of this change set that I can see. James --
Mar 17, 1:54 pm 2008
Miklos Szeredi
[patch 8/8] fuse: update file size on short read
From: Miklos Szeredi <mszeredi@suse.cz> If the READ request returned a short count, then either - cached size is incorrect - filesystem is buggy, as short reads are only allowed on EOF So assume, that the size is wrong and refresh it, so that cached read() doesn't zero fill the missing chunk. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- fs/fuse/file.c | 42 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 4 deletions(-) Index: ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 7/8] fuse: implement perform_write
From: Nick Piggin <npiggin@suse.de> Introduce fuse_perform_write. With fusexmp (a passthrough filesystem), large (1MB) writes into a backing tmpfs filesystem are sped up by almost 4 times (256MB/s vs 71MB/s). [mszeredi@suse.cz]: - split into smaller functions - testing - duplicate generic_file_aio_write(), so that there's no need to add a new ->perform_write() a_op. Comment from hch. Signed-off-by: Nick Piggin <npiggin@suse.de> Signed-off-by: Miklos Szeredi ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 6/8] fuse: clean up setting i_size in write
From: Miklos Szeredi <mszeredi@suse.cz> Extract common code for setting i_size in write functions into a common helper. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- fs/fuse/file.c | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) Index: linux/fs/fuse/file.c =================================================================== --- linux.orig/fs/fuse/file.c 2008-03-17 18:26:04.000000000 +0100 +++ linux/fs/fuse/file.c 2008-03-17 18:26:28.000000000 ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 5/8] fuse: support writable mmap
From: Miklos Szeredi <mszeredi@suse.cz> Quoting Linus (3 years ago, FUSE inclusion discussions): "User-space filesystems are hard to get right. I'd claim that they are almost impossible, unless you limit them somehow (shared writable mappings are the nastiest part - if you don't have those, you can reasonably limit your problems by limiting the number of dirty pages you accept through normal "write()" calls)." Instead of attempting the impossible, I've just waited for the ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 4/8] mm: allow not updating BDI stats in end_page ...
From: Miklos Szeredi <mszeredi@suse.cz> Fuse's writepage will need to clear page writeback separately from updating the per BDI counters. This patch renames end_page_writeback() to __end_page_writeback() and adds a boolean parameter to indicate if the per BDI stats need to be updated. Regular callers get an inline end_page_writeback() without the boolean parameter. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- include/linux/page-flags.h | 2 +- include/linux/pagemap.h | ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 2/8] mm: Add NR_WRITEBACK_TEMP counter
From: Miklos Szeredi <mszeredi@suse.cz> Fuse will use temporary buffers to write back dirty data from memory mappings (normal writes are done synchronously). This is needed, because there cannot be any guarantee about the time in which a write will complete. By using temporary buffers, from the MM's point if view the page is written back immediately. If the writeout was due to memory pressure, this effectively migrates data from a full zone to a less full zone. This patch adds a new ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 3/8] mm: rotate_reclaimable_page() cleanup
From: Miklos Szeredi <mszeredi@suse.cz> Clean up messy conditional calling of test_clear_page_writeback() from both rotate_reclaimable_page() and end_page_writeback(). The only user of rotate_reclaimable_page() is end_page_writeback() so this is OK. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- include/linux/swap.h | 2 +- mm/filemap.c | 10 ++++++---- mm/swap.c | 37 ++++++++++++------------------------- 3 files changed, 19 insertions(+), 30 ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 1/8] mm: bdi: export bdi_writeout_inc()
From: Miklos Szeredi <mszeredi@suse.cz> Fuse needs this for writable mmap support. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- include/linux/backing-dev.h | 2 ++ mm/page-writeback.c | 10 ++++++++++ 2 files changed, 12 insertions(+) Index: linux/include/linux/backing-dev.h =================================================================== --- linux.orig/include/linux/backing-dev.h 2008-03-17 18:24:13.000000000 +0100 +++ ...
Mar 17, 12:19 pm 2008
Miklos Szeredi
[patch 0/8] fuse: writable mmap + batched write
Hi Andrew, These are fuse updates for 2.6.26. 1-4) small tweaks to core code to make writable mmap in fuse possible 5) the fuse writable mmap support itself 6-7) allows buffered fuse writes to be bigger than 4k 8) handle short buffered reads better Thanks, Miklos --
Mar 17, 12:19 pm 2008
Michael Halcrow
[PATCH] eCryptfs: Swap dput() and mntput()
ecryptfs_d_release() is doing a mntput before doing the dput. This patch moves the dput before the mntput. Thanks to Rajouri Jammu for reporting this. Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com> --- diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index 841a032..5e59658 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs/dentry.c @@ -80,8 +80,8 @@ static void ecryptfs_d_release(struct dentry *dentry) { if (ecryptfs_dentry_to_private(dentry)) { if ...
Mar 17, 11:38 am 2008
Nebojsa Miljanovic
Re: SO_REUSEADDR not allowing server and client to use s ...
OK. I see. So, it would have to be some malicious application running together with the server (i.e. on the same CPU). I do see now why you said it would be very very hard to make this happen. Still, it would be nice to introduce SO_REUSEPORT socket options so secure servers (who happen to be clients as well) can re-use ports when necessary. Another option would be to check if port re-use is happening inside same application and allow it. That may make half of the folks happy, so I am ...
Mar 17, 11:17 am 2008
Serge E. Hallyn
[PATCH] cgroups: implement device whitelist (v4)
Implement a cgroup to track and enforce open and mknod restrictions on device files. A device cgroup associates a device access whitelist with each cgroup. A whitelist entry has 4 fields. 'type' is a (all), c (char), or b (block). 'all' means it applies to all types and all major and minor numbers. Major and minor are either an integer or * for all. Access is a composition of r (read), w (write), and m (mknod). The root device cgroup starts with rwm to 'all'. A child devcg gets a copy of ...
Mar 17, 11:07 am 2008
Justin Mattock
capability.h
Hello; I seem to be very confused on how to install fglrx on 2.6.25-* below is the warnings and errors, cleaning... patching 'highmem.h'... assuming new VMA API since we do have kernel 2.6.x... def_vma_api_version=-DFGL_LINUX253P1_VMA_API Assuming default VMAP API Assuming default munmap API doing Makefile based build for kernel 2.6.x and higher make -C /lib/modules/2.6.25-rc6/build SUBDIRS=/lib/modules/fglrx/build_mod/2.6.x modules make[1]: Entering directory ...
Mar 17, 11:06 am 2008
Grant Likely
Re: [PATCH 1/3] Xilinx: hwicap: Refactor status handling code.
On Mon, Mar 17, 2008 at 11:36 AM, Stephen Neuendorffer Acked-by: Grant Likely <grant.likely@secretlab.ca> -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 1:23 pm 2008
Stephen Neuendorffer
[PATCH 1/3] Xilinx: hwicap: Refactor status handling code.
Both the buffer-based and fifo-based icap cores have a status register. Previously, this was only used internally to check whether transactions have completed. However, the status can be useful to the main driver as well. This patch exposes these status functions to the main driver along with some masks for the differnet bits. Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com> --- drivers/char/xilinx_hwicap/buffer_icap.c | 22 ++++--------------- ...
Mar 17, 10:36 am 2008
Grant Likely
Re: [PATCH 3/3] Xilinx: hwicap: Use fixed device major.
On Mon, Mar 17, 2008 at 11:36 AM, Stephen Neuendorffer Looks good to me -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 1:20 pm 2008
Stephen Neuendorffer
[PATCH 3/3] Xilinx: hwicap: Use fixed device major.
Major 259 has been assigned by lanana. Use it. Also, publish /dev/icap[0-k] as the device entries, and register platform devices named 'icap' to be consistent. Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com> --- drivers/char/xilinx_hwicap/xilinx_hwicap.c | 43 +++++++++------------------- 1 files changed, 14 insertions(+), 29 deletions(-) diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index 5b8d646..016f905 ...
Mar 17, 10:36 am 2008
Stephen Neuendorffer
[PATCH 0/3] Xilinx hwicap updates
The following sequence of patches makes the icap driver more robust, by making better use of the status information from the cores. In addition, Lanana has assigned Major 259 for FPGA configuration interfaces, so we now use it, rather than dynamically finding a major number. Grant: please pick these up for 2.6.26. Do you think it's worth patching virtex_devices.c at this point, or just punt on ARCH=ppc? Steve --
Mar 17, 10:36 am 2008
Grant Likely
Re: [PATCH 2/3] Xilinx: hwicap: Verify sync before readi ...
On Mon, Mar 17, 2008 at 11:36 AM, Stephen Neuendorffer -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
Mar 17, 1:18 pm 2008
Stephen Neuendorffer
[PATCH 2/3] Xilinx: hwicap: Verify sync before reading idcode.
It appears that in some cases, the sync word might not be recognized by the hardware correctly. If this happens, then attempting to read from the port results in an unrecoverable error because of the design of the FPGA core. This patch updates the code to check the status of the device before reading the IDCODE, in order to avoid entering this unrecoverable state. This patch also adds additional NOOP commands into the sychronization sequence, which appears to be necessary to avoid the ...
Mar 17, 10:36 am 2008
john chen
display class questions in the kernel?
Dear Linux community. I was just wondering if anyone is actively maintaining drivers/video/display/display-sysfs.c, or the display class. I am looking at the version in 2.6.24.3 and I noticed that it hasn't been updated since 2.6.22. Just curious if anyone is maintaining this actively? I also didn't find any code in the drivers/video sub-directory that is actually using the "display class". I found some examples and possible updates from James Simmons on the web, but it seems ...
Mar 17, 10:31 am 2008
Dick Streefland
2.6.24.3: unexpected SIGTRAP in gdb
With kernel version 2.6.24.3, I sometimes get an unexpected SIGTRAP signal during the evaluation of a function call on the gdb command line. This problem does not occur with kernel version 2.6.23.12 running on the same machine. Both gdb-6.4.90 and gdb-6.7.1 exhibit this behavior. I can reproduce the problem as follows: $ cat > bug.c int x; int foo(void) { return 42; } int main(int argc, char* argv[]) { x++; return 0; } ^D $ cat > bug.gdb b main r s p foo() p foo() ^D $ ...
Mar 17, 9:53 am 2008
linux-net
Re:linux-kernel,some questions
The virus W32/Klez.h@MM was found in Swby.exe. The attachment Swby.exe was removed. The virus Exploit-MIME.gen.b was found in . The attachment was removed. --
Mar 17, 9:40 am 2008
Alan Cox
Re: SO_REUSEADDR not allowing server and client to use s ...
On Mon, 17 Mar 2008 11:43:28 -0500 Different issue. I can hijack a connection. Imagine I have a server bound to *.5000, and someone is about to connect. If on the server box I am able to bind and issue a connect outwards matching the inbound connection I will get the connection not the server. --
Mar 17, 10:30 am 2008
Nebojsa Miljanovic
Re: SO_REUSEADDR not allowing server and client to use s ...
Alan, thanks. With that additional INFO, I was able to find detailed description of this denial of service attack (attached below). Just to clarify. Having this port re-use check prevents folks from launching this attack as opposed to being victim of it? 2.4 Simultaneous Connections Occasionally, it is possible that hosts XX and YY both wish to establish a connection and both of them simultaneously initiate the handshake. This is called simultaneous connection establishment [RFC 793]. Both ...
Mar 17, 9:43 am 2008
Alan D. Brunelle
[Patch (block.git) 2/2] Ensure single IPI generation for ...
Signed-off-by: Alan D. Brunelle <alan.brunelle@hp.com> --- arch/ia64/kernel/smp.c | 8 ++++++-- arch/x86/kernel/smp_32.c | 8 ++++++-- arch/x86/kernel/smp_64.c | 8 ++++++-- include/linux/smp.h | 1 + kernel/smp.c | 34 ++++++++++++++++++++-------------- 5 files changed, 39 insertions(+), 20 deletions(-) diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c index 04ba9f8..52225bb 100644 --- a/arch/ia64/kernel/smp.c +++ b/arch/ia64/kernel/smp.c @@ ...
Mar 17, 9:37 am 2008
Jens Axboe
Re: [Patch (block.git) 2/2] Ensure single IPI generation ...
x86 and x86-64 boot just fine, so powerpc should work as well (will do performance testing on a 4-way ppc tomorrow). ia64 should also work, as long as the init_call_single_data() gets called correctly. If it doesn't work on tha ia64, try and change the core_initcall() to a postcore_initcall() or even an arch_initcall(). It now resides in kernel/smp.c. -- Jens Axboe --
Mar 17, 12:53 pm 2008
Jens Axboe
Re: [Patch (block.git) 2/2] Ensure single IPI generation ...
I agree with doing it this way, re-checking and doing another run (or more). However I think we can improve it a bit so we don't always have to grab the dst lock at least twice - it should be safe enough to include the lock only inside the first loop, doing an smp_mb() before the list_empty() check and again at the bottom before looping around and doing the list_empty() check again. I've rolled a new patch series ...
Mar 17, 12:26 pm 2008
Alan D. Brunelle
[Patch (block.git) 1/2] Add irqsave to spinlocks in call ...
Signed-off-by: Alan D. Brunelle <alan.brunelle@hp.com> --- kernel/smp.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/smp.c b/kernel/smp.c index 852abd3..7232e1c 100644 --- a/kernel/smp.c +++ b/kernel/smp.c @@ -24,12 +24,13 @@ void __cpuinit generic_init_call_single_data(void) void generic_smp_call_function_single_interrupt(void) { struct call_single_queue *q; + unsigned long flags; LIST_HEAD(list); q = ...
Mar 17, 9:34 am 2008
Jens Axboe
Re: [Patch (block.git) 1/2] Add irqsave to spinlocks in ...
This is included in the later series. -- Jens Axboe --
Mar 17, 12:27 pm 2008
Alan D. Brunelle
[PATCH (block.git) 0/2] IO CPU affinity update:
Hi Jens - Two patches: 1. Adds in the IRQ saving to generic_smp_call_function_single_interrupt (as you had suggested). 2. Ensures a single IPI generated to get a remote function call handler going. So far it is working better than before on the 4-way IA64 w/ the mkfs/untar/make test suite - after 22 runs: Part RQ MIN AVG MAX Dev ----- -- ------ ------ ------ ------ mkfs 0 18.786 19.253 19.655 0.241 mkfs 1 18.639 19.182 19.786 0.293 untar 0 17.140 ...
Mar 17, 9:34 am 2008
Jens Axboe
Re: [PATCH (block.git) 0/2] IO CPU affinity update:
This is starting to look pretty good! Thanks a lot for these results, and the ->activated optimizations. I had a feeling the unstable results were something like this, missing ipi's. -- Jens Axboe --
Mar 17, 12:27 pm 2008
Alan D. Brunelle
Re: [PATCH (block.git) 0/2] IO CPU affinity update:
Jens: FYI: I am still seeing infrequent hangs on the x86_64-based platform. It happened again today after my patch was added, I did get <alt><sysrq><W> to work this time, and the threads that were stuck were waiting for IOs to complete. I believe at some point you were thinking of hacking in a block IO dump magic key as well - is that there yet? I'll get to the ia64 testing tomorrow - have to run now, spent most of the day looking at what could cause stuff to be missed on x86_64. The code looks ...
Mar 17, 1:57 pm 2008
Michael Hanselmann
[PATCH] Update key codes for Apple aluminium keyboards
After a discussion with the autor of the original patch adding support for Apple's new aluminium keyboards (a45d82d19a6c2a717bcc33cff243199b77fa0082), Michel Dänzer, we decided that some changes should be done. Please push this patch into 2.6.25 before it's released. Changing the key codes later might confuse users. Signed-off-by: Michael Hanselmann <linux-kernel@hansmi.ch> --- --- linux-2.6.25-rc6.orig/drivers/hid/hid-input.c 2008-03-17 15:46:52.000000000 +0100 +++ ...
Mar 17, 9:18 am 2008
Jiri Kosina
Re: [PATCH] Update key codes for Apple aluminium keyboards
Could you please describe the changes in more detailed way, explaining why= =20 are they needed, so that we have it in changelog properly? Thanks. --=20 Jiri Kosina SUSE Labs
Mar 17, 10:00 am 2008
Jiri Kosina
Re: [PATCH] Update key codes for Apple aluminium keyboards
It indeed does. I will queue it in my tree, thanks a lot. --=20 Jiri Kosina SUSE Labs
Mar 17, 2:21 pm 2008
Michael Hanselmann
Re: [PATCH] Update key codes for Apple aluminium keyboards
Sure: --- F5 and F6 have no second function printed on them. Thus their definitions have been removed from the table. KEY_CYCLEWINDOWS doesn't name the function of Mac OS X' Exposé properly and because we couldn't find a better key code, we decided to use KEY_FN_F4 instead. We also changed KEY_BACK and KEY_FORWARD, which apply to browser functions, to KEY_PREVIOUSSONG and KEY_NEXTSONG, since the keys are intended to control a music player. --- Does this contain enough ...
Mar 17, 1:18 pm 2008
Heiko Carstens
Re: + dm-raid1-bitops-bug.patch added to -mm tree
Could we have this patch or something similar in 2.6.25, please? It's broken doing a test_bit() on an int since the result is random whenever sizeof(int) != sizeof(long). It might also lead to exceptions if an architecture requires a sizeof(long) alignment for test_bit(). --
Mar 17, 8:45 am 2008
Guennadi Liakhovetski
[RFC] kernel traczilla: tracking active kernel development
Hi The first thing one normally does before starting a new development is research whether and what has already been done in this area. Unless, of course, one knows it beforehand:-) This research might sometimes be quite time-consuming and might not always deliver expected results. Wouldn't it be good to have a central page for tracking such hot kernel projects _before_ they get submitted into mainline. One would just decide "now I am prepared to tell the world about my work", go to ...
Mar 17, 8:30 am 2008
James Bottomley
Re: ultrastor.c is a bit-rot
VL is vesa local ... it was an ISA like graphics bus that was fast and It will definitely work for EISA and VL bus. I think if you analyse the placement of kernel data segments for compiled in drivers, it might also work for ISA too, since I think the pfn will be low enough. It should fail as a module not just because the area will be out of range for ISA, but also because the module data segment is in vmalloc space, so the virt_to_bus assumptions of contiguity could be ...
Mar 17, 8:23 am 2008
Boaz Harrosh
ultrastor.c is a bit-rot
Inspecting ultrastor.c it is clear to me that this was never used for a loooooooooong time. Not since a PC has more then 2^24 bit of memory. Let me explain below. Now I'm not saying it should be fixed. I'm saying that it should be dumped in the account that it is not used by any one and that it does not work. Why it never worked? ~~~~~~~~~~~~~~~~~~~~~ The driver's header says it supports 3 cards * 14F - ISA first-party DMA HA with floppy support and WD1003 emulation. * 24F - EISA ...
Mar 17, 7:59 am 2008
Alan Cox
Re: ultrastor.c is a bit-rot
It will work compiled in, and probably users of such cards if any don't have > 16MB. I doubt anyone is using the driver however. Alan --
Mar 17, 9:07 am 2008
Boaz Harrosh
Re: ultrastor.c is a bit-rot
So what is the verdict? is it removed? marked broken for ISA? can I safely say that unchecked_isa_dma can be removed? Boaz --
Mar 17, 9:00 am 2008
James Bottomley
Re: ultrastor.c is a bit-rot
Error handling here, I'm afraid; dma_alloc_coherent can return NULL. Other than that, looks great. James --
Mar 17, 10:25 am 2008
Matthew Wilcox
Re: ultrastor.c is a bit-rot
VESA Local Bus. It was (in some sense) the predecessor of AGP. We treat it like ISA inside the kernel. On x86, EISA depends on ISA, so the dependency, while wrong, does not affect any x86 users who have an I believe this will work for VESA and EISA cards, though not, indeed for That doesn't mean it doesn't have users ... On the other hand, the u14-34f driver is supposed to be preferred to the ultrastor drivers. Only problem: it doesn't support the 24F card. -- Intel are signing my ...
Mar 17, 8:23 am 2008
James Bottomley
Re: ultrastor.c is a bit-rot
No ... ISA definitely requires it. James --
Mar 17, 9:03 am 2008
Boaz Harrosh
Re: ultrastor.c is a bit-rot
In Hebrew we say: "You make me drink Kerosene". An "obvious enough to apply the best straight line fix" submitted below: I say dump it, it's unused. Boaz --- From: Boaz Harrosh <bharrosh@panasas.com> Date: Mon, 17 Mar 2008 18:40:03 +0200 Subject: [PATCH] ultrastor: Fix for ISA DMA allocation "obvious enough to apply the best straight line fix" submitted below. Signed-off-by: Boaz Harrosh <bharrosh@panasas.com> CC: Andi Kleen <ak@suse.de> --- drivers/scsi/ultrastor.c | 24 ...
Mar 17, 10:01 am 2008
Scott Edwards
Fibre channel network interfaces + Linux SAN
Two things I'm trying to solve with my fc hardware. How do I enable these for IP networking, and how do I offer say lvm logical volumes behind Linux as a SAN? I'd like nodes to be bootable and offer specific volumes as their disks. I'm using 2.6.28 As for networking, I vaguely remember setting up IPv4 on fibre channel some time ago. So far I have two hosts connected to a Compaq Storage Works FC arbitrated loop. Each host has Online for /sys/class/fc_host/hostN/port_state. I can't ...
Mar 17, 7:18 am 2008
Muli Ben-Yehuda
CFP: OSR special issue on the Linux kernel - deadline extended
Due to many requests, the paper submission deadline for the SIGOPS Operating Systems Review special issue on Research and Developments in the Linux Kernel has been extended until 11:59PM EST Friday March 28th. Now is the time to get those OSR papers rolling! SIGOPS Operating Systems Review Special Issue on Research and Developments in the Linux Kernel The Linux kernel, since its inception in 1991, has captured the interest of many thousands of developers and millions of users. ...
Mar 17, 5:52 am 2008
Pavel Emelyanov
[PATCH 3/3] Infiniband: don't use task_struct.tgid in ma ...
The task_struct->tgid field is about to become deprecated, due to pid namespaces make tasks have many pids, not one. There is one place using it left to fix in infiniband - the make_cm_node(). This function uses the task tgid just to generate a session id, so it's perfectly safe to use appropriate wrapper - task_tgid_nr(). Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- drivers/infiniband/hw/nes/nes_cm.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git ...
Mar 17, 5:50 am 2008
Pavel Emelyanov
[PATCH 2/3] Infiniband: make ehca_cq use struct pid poin ...
The task_struct->tgid field is about to become deprecated, due to pid namespaces make tasks have many pids, not one. The infiniband driver is one of the code, that still uses it in some places. Now make struct ehca_cq use a struct pid pointer and consolidate owners check into one call. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- drivers/infiniband/hw/ehca/ehca_classes.h | 2 +- drivers/infiniband/hw/ehca/ehca_cq.c | 30 ++++++++++++++++++------------ ...
Mar 17, 5:48 am 2008
Pavel Emelyanov
[PATCH 1/3] Infiniband: make ehca_pd use struct pid poin ...
The task_struct->tgid field is about to become deprecated, due to pid namespaces make tasks have many pids, not one. The infiniband driver is one of the code, that still uses it in some places. First make struct ehca_pd use a struct pid pointer and consolidate owners check into one call (saves space). Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- drivers/infiniband/hw/ehca/ehca_av.c | 18 +++--------------- drivers/infiniband/hw/ehca/ehca_classes.h | 2 +- ...
Mar 17, 5:46 am 2008
Roland Dreier
Re: [PATCH 1/3] Infiniband: make ehca_pd use struct pid ...
> The task_struct->tgid field is about to become deprecated, due to > pid namespaces make tasks have many pids, not one. The infiniband > driver is one of the code, that still uses it in some places. Looks fine in terms of the changes it makes, but actually it seems that the ehca use of this is completely bogus and the ownership checking should be removed. The core ib_uverbs module has checks that make sure that objects can only be accessed through the file that they were created through; ...
Mar 17, 1:56 pm 2008
Ingo Molnar
Re: [git patches] libata fixes
hm, this broke the build, the attached (common) config fails with: LD .tmp_vmlinux1 drivers/built-in.o: In function `ata_acpi_associate': (.text+0xc3984): undefined reference to `register_hotplug_dock_device' drivers/built-in.o: In function `ata_acpi_associate': (.text+0xc39d1): undefined reference to `register_hotplug_dock_device' make: *** [.tmp_vmlinux1] Error 1 Ingo
Mar 17, 11:29 am 2008
Ingo Molnar
Re: [git patches] libata fixes
changing CONFIG_ACPI_DOCK=m to CONFIG_ACPI_DOCK=y works around the build problem. Ingo --
Mar 17, 11:31 am 2008
Jeff Garzik
[git patches] libata fixes
Notes: * the devres change is included here because the ahci fix needs it Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ahci.c | 72 ++++++++++++++++++++++----------- drivers/ata/libata-acpi.c | 96 ++++++++++++++++++++++++++++++++------------- drivers/ata/pata_ali.c | 2 +- include/linux/pci.h | 2 + lib/devres.c | 25 ...
Mar 17, 5:35 am 2008
David Miller
Re: [git patches] net driver fixes
From: Jeff Garzik <jeff@garzik.org> Pulled and pushed back out, thanks Jeff! --
Mar 17, 12:00 pm 2008
Jeff Garzik
[git patches] net driver fixes
Notes: 1) This includes a drivers/atm patch from Al (I don't usually take drivers/atm patches, but it came straight to me) 2) the drivers/sn change came from the maintainer, so it seemed fine to push it this way, along with the drivers/net/ioc3-eth changes 3) the forcedeth change is a critical fix Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the following updates: drivers/atm/fore200e.c ...
Mar 17, 5:23 am 2008
Rusty Russell
[PULL] 2.6.25 virtio fixes
The following changes since commit a978b30af3bab0dd9af9350eeda25e76123fa28e: Linus Torvalds (1): Linux 2.6.25-rc6 are available in the git repository at: ssh://master.kernel.org/pub/scm/linux/kernel/git/rusty/linux-2.6-for-linus.git master Amit Shah (1): virtio: Enable netpoll interface for netconsole logging Anthony Liguori (1): virtio: Use spin_lock_irqsave/restore for virtio-pci Christian Borntraeger (1): virtio: fix race in enable_cb Jeremy Katz ...
Mar 17, 5:10 am 2008
UK NATIONAL LOTTERY
Confirm reciept
You won the sum of
Mar 17, 4:53 am 2008
Stephen Rothwell
linux-next: Tree for March 17
Hi all, I have created today's linux-next tree at git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git (tar balls at http://www.kernel.org/pub/linux/kernel/people/sfr/linux-next/). You can see which trees have been included by looking in the Next/Trees file in the source. There are also quilt-import.log and merge.log files in the Next directory. Between each merge, the tree was built with allmodconfig for both powerpc and x86_64. There were a few merge conflicts (mostly ...
Mar 17, 4:21 am 2008
Luck, Tony
RE: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't ...
> % ./hackbench 130 process 500 I'd like to reproduce your results so I can make a new version of the ptc.g patch that doesn't have this regression. I found this version (that claims to be the latest) of hackbench.c http://people.redhat.com/mingo/cfs-scheduler/tools/hackbench.c Is this the one you used? What was the configuration of your machine (how many cpus, how much memory)? Thanks -Tony --
Mar 17, 10:38 am 2008
KOSAKI Motohiro
[2.6.25-rc5-mm1][regression] ia64: hackbench doesn't fin ...
Hi I tested following. % ./hackbench 130 process 500 (this parameter mean consume all physical memory and 1G swap space) 2.6.25-rc3-mm1: works well 2.6.25-rc5: works well 2.6.25-rc5-mm1: doesn't finish >12 hour my bisect indicate the cause of bug is git-ia64.patch. and, git-ia64.patch of 2.6.25-rc5-mm1 contain following patches. [IA64] cleanup and improve fsys_gettimeofday [IA64] Multiple outstanding ptc.g instruction support [IA64] VIRT_CPU_ACCOUNTING ...
Mar 17, 4:18 am 2008
Luck, Tony
RE: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't ...
Thank you very much for your testing, and for isolating the How long does hackbench take to complete on 2.6.25-rc5? I'll revert it while I investigate the cause of this Me too! -Tony --
Mar 17, 9:09 am 2008
KOSAKI Motohiro
Re: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't ...
Hi Tony-san, 2.6.25-rc5: about 200sec -mm1: super heavy soft lockup happend. Thank you very much! ---------------------------------------------------------- 2.6.25-rc5-mm1 spinlock lockup Starting Avahi daemon... [ OK ] Starting HAL daemon: [ OK ] Starting smartd: [ OK ] Red Hat Enterprise Linux Server release 5.1 (Tikanga) Kernel 2.6.25-rc5-mm1 on an ia64 PQ-muneda login: BUG: spinlock lockup on CPU#1, hackbench/12693, e0000040c45b1950 Call Trace: ...
Mar 17, 4:43 pm 2008
KOSAKI Motohiro
Re: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't ...
cpu: Itanium2 x8 mem: 8GB(4GB x2 node) Thanks. --
Mar 17, 4:44 pm 2008
KOSAKI Motohiro
Re: [2.6.25-rc5-mm1][regression] ia64: hackbench doesn't ...
Hi Tony-san, seto-san teach me method of more investigate. and I found the root cause is contained by following patch. [IA64] Multiple outstanding ptc.g instruction support Could you please revert that patch from ia64? I dislike its strong regression. --
Mar 17, 4:51 am 2008
murtuja bharmal
ip_rcv, ip_output is not exported in 2.6 kernel.
Hello, Can any one tell me why ip_rcv, ip_output is not exported in 2.6 kernel. If I have to use this function in kernel module what should be the approach. Do I need to export it, in kernel code or there is any other alternative. Thanks Murtuja Bharmal Meet people who discuss and share your passions. Go to http://in.promos.yahoo.com/groups --
Mar 17, 4:00 am 2008
Oleg Nesterov
Re: [PATCH 2/2] Bsd_acct: using task_struct->tgid is not ...
Offtopic. Bsd-accounting is system wide. I can't understand what should I think the patch is correct, but let's suppose that a sub-namespace does accounting, and the task from the parent namespace exits. With this patch we report ac.ac_pid == 0, which is a bit strange. But the question is, should we see the tasks from the parent namespace at all? Perhaps, the task shouldn't account itself if it doesn't "belong" to acct_globals.ns ? In that case we don't need other changes to figure out ...
Mar 17, 10:57 am 2008
Pavel Emelyanov
[PATCH 2/2] Bsd_acct: using task_struct->tgid is not rig ...
In case we're accounting from a sub-namespace, the tgids reported will not refer to the right namespace. Save the pid_namespace we're accounting in on the acct_glbs and use it in do_acct_process. Two less :) places using the task_struct.tgid member. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- kernel/acct.c | 21 +++++++++++++++------ 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/kernel/acct.c b/kernel/acct.c index 7ff5339..91e1cfd 100644 --- ...
Mar 17, 3:51 am 2008
Pavel Emelyanov
[PATCH 1/2] Bsd_acct: plain current->real_parent access ...
This is minor, but dereferencing even current real_parent is not safe on debug kernels, since the memory, this points to, can be unmapped - RCU protection is required. Besides, the tgid field is deprecated and is to be replaced with task_tgid_xxx call (the 2nd patch), so RCU will be required anyway. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> --- kernel/acct.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/kernel/acct.c b/kernel/acct.c index ...
Mar 17, 3:48 am 2008
Len Brown
Re: [PATCH] thermal: fix Kconfig dependencies
Although the "select" that started this thread was certainly erroneous, this doesn't look right either. THERMAL should not depend on or select HWMON. Instead, part of its code that is there for the benefit of HWMON should depend on HWMON. Based on Jean's last message, that code should probably get its own sub-config option, CONFIG_THERMAL_HWMON that is default N for the benefit of old libraries. Similarly, ACPI_THERMAL should not depend on THERMAL, instead the code that registers with ...
Mar 17, 11:59 am 2008
Heiko Carstens
Re: [PATCH] thermal: fix Kconfig dependencies
Updated patch: Subject: [PATCH] thermal: fix Kconfig dependencies From: Heiko Carstens <heiko.carstens@de.ibm.com> git commit 3152fb9f11cdd2fd8688c2c5cb805e5c09b53dd9 "thermal: fix generic thermal I/F for hwmon" adds a select HWMON to THERMAL. This causes HWMON to be selected regardless of its other dependencies. In this case depends on HAS_IOMEM gets ignored which causes this build error on s390: drivers/hwmon/w83627hf.c: In function 'superio_outb': drivers/hwmon/w83627hf.c:117: ...
Mar 17, 11:43 am 2008
Heiko Carstens
[PATCH] thermal: fix Kconfig dependencies
From: Heiko Carstens <heiko.carstens@de.ibm.com> git commit 3152fb9f11cdd2fd8688c2c5cb805e5c09b53dd9 "thermal: fix generic thermal I/F for hwmon" adds a select HWMON to THERMAL. This causes HWMON to be selected regardless of its other dependencies. In this case depends on HAS_IOMEM gets ignored which causes this build error on s390: drivers/hwmon/w83627hf.c: In function 'superio_outb': drivers/hwmon/w83627hf.c:117: error: implicit declaration of function 'outb' Change the select to a ...
Mar 17, 2:58 am 2008
Linus Torvalds
Re: [PATCH] thermal: fix Kconfig dependencies
Nope, that doesn't work. ACPI_THERMAL will select THERMAL, so now you have THERMAL selected without HWMON. As a minimal fix, you'd at least need to make ACPI_THERMAL depend on THERMAL too. Linus --
Mar 17, 9:55 am 2008
S.Çağlar Onur
[PATCH] Fix indentation
zlc_setup(): handle jiffies wraparound (10ed273f5016c582413dfbc468dd084957d847e1) changes tab with spaces CC: Lee Schermerhorn <Lee.Schermerhorn@hp.com> CC: Paul Jackson <pj@sgi.com> Cc: Andrew Morton <akpm@linux-foundation.org> --- mm/page_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 402a504..363c948 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1284,7 +1284,7 @@ static nodemask_t *zlc_setup(struct ...
Mar 17, 2:36 am 2008
KOSAKI Motohiro Mar 17, 2:59 am 2008
S.Çağlar Onur
[PATCH] net/mac80211/: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: linux-wireless@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- net/mac80211/rc80211_simple.c | 3 ++- net/mac80211/rx.c | 3 ++- 2 files ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] drivers/net/arcnet/arcnet.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: Jeff Garzik <jeff@garzik.org> Cc: David Miller <davem@davemloft.net> Cc: netdev@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- drivers/net/arcnet/arcnet.c | ...
Mar 17, 2:36 am 2008
Stephen Rothwell
Re: [PATCH] arch/powerpc/platforms/iseries/pci.c: Use ti ...
On Mon, 17 Mar 2008 11:36:26 +0200 S.=C3=87a=C4=9Flar Onur <caglar@pardus.o= Acked-by: Stephen Rothwell <sfr@canb.auug.org.au> --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Mar 17, 4:31 pm 2008
S.Çağlar Onur
[PATCH] drivers/net/ax88796.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: netdev@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- drivers/net/ax88796.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] drivers/net/tokenring/3c359.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: netdev@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- drivers/net/tokenring/3c359.c | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] arch/parisc/kernel/unaligned.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: linux-parisc@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- arch/parisc/kernel/unaligned.c | 2 +- 1 files changed, 1 ...
Mar 17, 2:36 am 2008
Kyle McMartin
Re: [PATCH] arch/parisc/kernel/unaligned.c: Use time_* macros
Hi, On Mon, Mar 17, 2008 at 11:36:25AM +0200, S.?a??lar Onur wrote: I prefer the idea of using printk_ratelimit. I've committed a patch that does this to git and credited you with pointing it out. --
Mar 17, 8:40 am 2008
S.Çağlar Onur
[PATCH] arch/ia64/kernel/: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() & time_before() macros, defined at linux/jiffies.h, which deals with wrapping correctly Cc: linux-ia64@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- arch/ia64/kernel/irq_ia64.c | 2 +- arch/ia64/kernel/mca.c | 3 ++- ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] arch/alpha/kernel/traps.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: Richard Henderson <rth@twiddle.net> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- arch/alpha/kernel/traps.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] fs/binfmt_aout.c: Use printk_ratelimit()
Use printk_ratelimit() instead of jiffies based arithmetic, suggested by Geert Uytterhoeven Cc: linux-arch@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- fs/binfmt_aout.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c index a1bb224..ba4cddb 100644 --- a/fs/binfmt_aout.c +++ b/fs/binfmt_aout.c @@ ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* ...
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: linuxppc-dev@ozlabs.org Cc: Paul Mackerras <paulus@samba.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- arch/powerpc/platforms/iseries/pci.c | 3 ++- 1 files changed, 2 ...
Mar 17, 2:36 am 2008
S.Çağlar Onur
[PATCH] drivers/net/wireless/atmel.c: Use time_* macros
The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly Cc: linux-wireless@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr> --- drivers/net/wireless/atmel.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff ...
Mar 17, 2:36 am 2008
Roland McGrath
[PATCH] x86 handle_vm86_trap cleanup
Use force_sig in handle_vm86_trap like other machine traps do. Signed-off-by: Roland McGrath <roland@redhat.com> --- arch/x86/kernel/vm86_32.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c index 738c210..fddb998 100644 --- a/arch/x86/kernel/vm86_32.c +++ b/arch/x86/kernel/vm86_32.c @@ -553,16 +553,9 @@ int handle_vm86_trap(struct kernel_vm86_regs * regs, long error_code, int trapno } if (trapno ...
Mar 17, 2:21 am 2008
Li Zefan
[PATCH -mm] cgroup: fix boot option parsing
When boot with 'cgroup_disable=cpuacct', it turns out subsystem 'cpu' is disabled. When Balbir posted the patch to add cgroup boot option support, Paul M noticed this problem, but the patch was accepted without fixing it. Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> --- kernel/cgroup.c | 15 ++++++--------- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/kernel/cgroup.c b/kernel/cgroup.c index e8e8ec4..54c28ea 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c @@ ...
Mar 17, 1:24 am 2008
Paul Menage Mar 17, 1:26 am 2008
Borislav Petkov
[PATCH 12/17] ide-tape: remove pipelined mode parameters
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 17 ----------------- 1 files changed, 0 insertions(+), 17 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 0056a26..5535356 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -72,23 +72,6 @@ enum { #endif /**************************** Tunable parameters *****************************/ - - -/* - * Pipelined mode parameters. - * - * We try to use the ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 08/17] ide-tape: remove pipeline-specific code fr ...
As a side effect, remove unused idetape_kfree_stage() and idetape_abort_pipeline() Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 83 ------------------------------------------------ 1 files changed, 0 insertions(+), 83 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 7e0f4fa..3eeb5c0 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -686,37 +686,6 @@ static void __idetape_kfree_stage(idetape_stage_t ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 05/17] ide-tape: remove pipeline-specific code in ...
Since we don't do pipeline read-ahead anymore, we don't have to look for filemarks we have crossed. Therefore, remove the code chunk that does that and pass on the command to the tape. As a side effect, remove unused idetape_wait_first_stage(). Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 52 ------------------------------------------------ 1 files changed, 0 insertions(+), 52 deletions(-) diff --git a/drivers/ide/ide-tape.c ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 09/17] ide-tape: unwrap idetape_queue_pc_tail()
idetape_queue_pc_tail() is a wrapper for its __idetape_queue_pc_tail() counterpart and has no other functionality. Remove it and call the "wrapped" function directly. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 3eeb5c0..a85866a 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -1631,7 +1631,7 @@ static ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 03/17] ide-tape: remove idetape_discard_read_pipeline()
Now that we don't queue any more requests on the pipeline we don't need to discard it anymore. Also, remove __idetape_discard_read_pipeline() too. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 92 +---------------------------------------------- 1 files changed, 2 insertions(+), 90 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 241f596..429fed4 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -1875,52 ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 13/17] ide-tape: remove pipelined mode tape contr ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 34 +++++----------------------------- 1 files changed, 5 insertions(+), 29 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 5535356..1464383 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -204,19 +204,15 @@ enum { /* 0 When the tape position is unknown */ IDETAPE_FLAG_ADDRESS_VALID = (1 << 1), /* Device already opened */ - IDETAPE_FLAG_BUSY = (1 ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 07/17] ide-tape: remove idetape_remove_stage_head()
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 39 --------------------------------------- 1 files changed, 0 insertions(+), 39 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 5a6b657..7e0f4fa 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -692,41 +692,6 @@ static void idetape_kfree_stage(idetape_tape_t *tape, idetape_stage_t *stage) } /* - * Remove tape->first_stage from the pipeline. The caller ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 11/17] ide-tape: remove pipeline-specific code fr ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 40 ++++------------------------------------ 1 files changed, 4 insertions(+), 36 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index c612c8c..0056a26 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -2690,11 +2690,10 @@ static inline void idetape_add_settings(ide_drive_t *drive) { ; } */ static void idetape_setup(ide_drive_t *drive, idetape_tape_t *tape, int ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 04/17] ide-tape: remove idetape_empty_write_pipeline()
In order _not_ to skip over some pipeline stages left, we carefully flush any remaining ones. Nevertheless, this is only a temporary measure (git-bisect) before removing pipeline functionality completely. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 80 ++---------------------------------------------- 1 files changed, 3 insertions(+), 77 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 429fed4..d4a94d5 100644 --- ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 17/17] ide-tape: remove comments markup from Docu ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- Documentation/ide/ide-tape.txt | 132 ++++++++++++++++++++-------------------- 1 files changed, 65 insertions(+), 67 deletions(-) diff --git a/Documentation/ide/ide-tape.txt b/Documentation/ide/ide-tape.txt index 51f596b..3f348a0 100644 --- a/Documentation/ide/ide-tape.txt +++ b/Documentation/ide/ide-tape.txt @@ -1,67 +1,65 @@ -/* - * IDE ATAPI streaming tape driver. - * - * This driver is a part of the Linux ide driver. - * - * ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 06/17] ide-tape: remove idetape_pipeline_size()
The computation of the block offset of the the tape position (MTIOCPOS, MTIOCGET) is not influenced by the stages queued in the pipeline anymore but by the size of the current buffer which is going to be sent to the drive. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 23 +---------------------- 1 files changed, 1 insertions(+), 22 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 3b324bb..5a6b657 100644 --- ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 16/17] ide-tape: remove pipelined mode descriptio ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- Documentation/ide/ide-tape.txt | 79 ---------------------------------------- 1 files changed, 0 insertions(+), 79 deletions(-) diff --git a/Documentation/ide/ide-tape.txt b/Documentation/ide/ide-tape.txt index 658f271..51f596b 100644 --- a/Documentation/ide/ide-tape.txt +++ b/Documentation/ide/ide-tape.txt @@ -8,8 +8,6 @@ * interface, on the other hand, creates new requests, adds them * to the request-list of the block device, ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 02/17] ide-tape: remove unused parameter from ide ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index b931547..241f596 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -1587,7 +1587,7 @@ abort: } static int idetape_copy_stage_from_user(idetape_tape_t *tape, - idetape_stage_t *stage, const char __user *buf, int n) + const char __user *buf, int n) ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 15/17] ide-tape: remove misc references to pipeli ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 22 +++------------------- 1 files changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 9ae42c3..a4caf2b 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -265,9 +265,7 @@ typedef struct ide_tape_obj { * While polling for DSC we use postponed_rq to postpone the current * request so that ide.c will be able to service pending ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 10/17] ide-tape: remove remaining pipeline functi ...
The driver is using now solely its own request queue. Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 103 +----------------------------------------------- 1 files changed, 2 insertions(+), 101 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index a85866a..c612c8c 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -642,28 +642,6 @@ static void idetape_analyze_error(ide_drive_t *drive, u8 *sense) } } ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 01/17] ide-tape: remove unused parameter from ide ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 11 ++++------- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 86be926..b931547 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -1619,7 +1619,7 @@ static int idetape_copy_stage_from_user(idetape_tape_t *tape, } static int idetape_copy_stage_to_user(idetape_tape_t *tape, char __user *buf, - idetape_stage_t *stage, ...
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 0/17] ide-tape: remove pipeline functionality-v3
Hi Bart, here's the rest of the pipeline removal series. What's left is to rewrite the whole allocation logic around tape->merge_stage and all the other small buffers so that we can get at least some sanity into the driver before working on it any further :). Documentation/ide/ide-tape.txt | 211 ++++--------- drivers/ide/ide-tape.c | 689 ++-------------------------------------- 2 files changed, 99 insertions(+), 801 deletions(-) --
Mar 16, 11:41 pm 2008
Borislav Petkov
[PATCH 14/17] ide-tape: remove pipeline-specific members ...
Signed-off-by: Borislav Petkov <petkovbb@gmail.com> --- drivers/ide/ide-tape.c | 79 ++++------------------------------------------- 1 files changed, 7 insertions(+), 72 deletions(-) diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 1464383..9ae42c3 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -307,12 +307,8 @@ typedef struct ide_tape_obj { * At most, there is only one ide-tape originated data transfer request * in the device request queue. ...
Mar 16, 11:41 pm 2008
Joe Peterson
Interactivity degrades with CONFIG_[FAIR]_GROUP_SCHED se ...
First of all, I am very excited to see the CFS in the kernel. Interactivity is really great; much better than before. When going from kernel 2.6.23 to 2.6.24, however, I noticed that interactivity (namely the smoothness of mouse motion) was noticeably less smooth under load. The most obvious case was while pulling down a Subversion repository; the mouse would freeze for quite long periods while being moved (i.e. a large fraction of a second), which never happens under 2.6.23. I was using ...
Mar 16, 11:12 pm 2008
Roland McGrath
[PATCH] powerpc exec PT_DTRACE
The PT_DTRACE flag is meaningless and obsolete. Don't touch it. Signed-off-by: Roland McGrath <roland@redhat.com> --- arch/powerpc/kernel/process.c | 5 ----- arch/powerpc/kernel/sys_ppc32.c | 5 ----- 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c index 4846bf5..7c8e3da 100644 --- a/arch/powerpc/kernel/process.c +++ b/arch/powerpc/kernel/process.c @@ -862,11 +862,6 @@ int sys_execve(unsigned long a0, ...
Mar 16, 10:01 pm 2008
Roland McGrath
[PATCH] x86_64 sys32_execve PT_DTRACE
The PT_DTRACE flag is meaningless and obsolete. Don't touch it. Signed-off-by: Roland McGrath <roland@redhat.com> --- arch/x86/ia32/sys_ia32.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/arch/x86/ia32/sys_ia32.c b/arch/x86/ia32/sys_ia32.c index abf71d2..fa47939 100644 --- a/arch/x86/ia32/sys_ia32.c +++ b/arch/x86/ia32/sys_ia32.c @@ -804,11 +804,6 @@ asmlinkage long sys32_execve(char __user *name, compat_uptr_t __user *argv, if (IS_ERR(filename)) ...
Mar 16, 10:00 pm 2008
Roland McGrath
[PATCH 2/2] x86_64 ptrace vs -ENOSYS
When we're stopped at syscall entry tracing, ptrace can change the %rax value from -ENOSYS to something else. If no system call is actually made because the syscall number (now in orig_rax) is bad, then we now always reset %rax to -ENOSYS again. This changes it to leave the return value alone after entry tracing. That way, the %rax value set by ptrace is there to be seen in user mode (or in syscall exit tracing). This is consistent with what the 32-bit kernel does. Signed-off-by: Roland ...
Mar 16, 9:59 pm 2008
Roland McGrath
[PATCH 1/2] x86_64 ia32 ptrace vs -ENOSYS
When we're stopped at syscall entry tracing, ptrace can change the %eax value from -ENOSYS to something else. If no system call is actually made because the syscall number (now in orig_eax) is bad, then the %eax value set by ptrace should be returned to the user. But, instead it gets reset to -ENOSYS again. This is a regression from the native 32-bit kernel. This change fixes it by leaving the return value alone after entry tracing. Signed-off-by: Roland McGrath <roland@redhat.com> --- ...
Mar 16, 9:57 pm 2008
KOSAKI Motohiro
Re: [2.6.25-rc5-mm1][regression?] BUG: spinlock wrong CP ...
Hi if revert following patch [IA64] Multiple outstanding ptc.g instruction support then this problem doesn't reproduce. I attached that revert patch.
Mar 17, 6:32 am 2008
KOSAKI Motohiro
[2.6.25-rc5-mm1][regression?] BUG: spinlock wrong CPU, m ...
Hi I found strange message at 2.6.25-rc5-mm1 booting. and it is always reproduce. and, Eric Piel's spinlock related patch(below URL) can't fixed my problem. http://marc.info/?l=linux-kernel&m=120561027011749&w=2 Is this known bug? or should i do bisect? ------------------------------------------------------------------- BUG: spinlock wrong CPU on CPU#3, udevd/2495 lock: a040000058246510, .magic: dead4ead, .owner: udevd/2495, .owner_cpu: 2 Call Trace: [<a000000100015f00>] ...
Mar 16, 9:25 pm 2008
chen
咨询
致贵公司(厂)财务部协议书 尊贵的先生(小姐)您好! 推出此项业务是双方公司的利益,是一项双赢的业务,本公司每月都有发票剩余,因此愿为有需要的客户代理开具发票。 本公司有增值税专用发票、普通发票,还可提供多家公司及不同性质的发票、海关进口增值、建筑业、广告业、运输业、服务业等。点数优惠、发票真实有效可验证后付款。 若有不明,欢迎来电洽谈,若有打搅、敬请谅解!本公司将真诚与您长期合作! 顺祝商祺! 联系电话:0512-67138515 王小姐( 苏州广达新公司) MSN:sale-account2008@hotmail.com QQ:954661604 建议您保留本邮件
Mar 16, 7:10 pm 2008
Paul Jackson
Re: [PATCH] [4/18] Add basic support for more than one h ...
Andi, Seems to me that both patches 2/18 and 4/18 are called: Add basic support for more than one hstate in hugetlbfs You probably want to change this detail. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --
Mar 17, 1:09 am 2008
Paul Jackson
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64
Ok - good plan. Do you know offhand what would be the correct HW list for hugepages and hugepagesz? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --
Mar 17, 3:02 am 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
or preferred has some problem? preferred = PFN_DOWN(ALIGN(preferred, align)) + offset; YH --
Mar 17, 12:17 am 2008
Andi Kleen
Re: [PATCH] [0/18] GB pages hugetlb support
That one and Add basic support for more than one hstate in hugetlbfs and partly Add support to have individual hstates for each hugetlbfs mount It all builds on each other. Ideally look at the end result of the whole series. -Andi --
Mar 17, 12:00 am 2008
Andi Kleen
[PATCH] [7/18] Abstract out the NUMA node round robin co ...
Need this as a separate function for a future patch. No behaviour change. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/hugetlb.c | 37 ++++++++++++++++++++++--------------- 1 file changed, 22 insertions(+), 15 deletions(-) Index: linux/mm/hugetlb.c =================================================================== --- linux.orig/mm/hugetlb.c +++ linux/mm/hugetlb.c @@ -219,6 +219,27 @@ static struct page *alloc_fresh_huge_pag return page; } +/* + * Use a helper variable ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [18/18] Implement hugepagesz= option for x86-64
Add an hugepagesz=... option similar to IA64, PPC etc. to x86-64. This finally allows to select GB pages for hugetlbfs in x86 now that all the infrastructure is in place. Signed-off-by: Andi Kleen <ak@suse.de> --- Documentation/kernel-parameters.txt | 11 +++++++++-- arch/x86/mm/hugetlbpage.c | 17 +++++++++++++++++ include/asm-x86/page.h | 2 ++ 3 files changed, 28 insertions(+), 2 deletions(-) Index: ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [5/18] Expand the hugetlbfs sysctls to handle ar ...
- I didn't bother with hugetlb_shm_group and treat_as_movable, these are still single global. - Also improve error propagation for the sysctl handlers a bit Signed-off-by: Andi Kleen <ak@suse.de> --- include/linux/hugetlb.h | 5 +++-- kernel/sysctl.c | 2 +- mm/hugetlb.c | 43 +++++++++++++++++++++++++++++++------------ 3 files changed, 35 insertions(+), 15 deletions(-) Index: ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [15/18] Add support to x86-64 to allocate and lo ...
Signed-off-by: Andi Kleen <ak@suse.de> --- arch/x86/mm/hugetlbpage.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) Index: linux/arch/x86/mm/hugetlbpage.c =================================================================== --- linux.orig/arch/x86/mm/hugetlbpage.c +++ linux/arch/x86/mm/hugetlbpage.c @@ -133,9 +133,14 @@ pte_t *huge_pte_alloc(struct mm_struct * pgd = pgd_offset(mm, addr); pud = pud_alloc(mm, pgd, addr); if (pud) { - if ...
Mar 16, 6:58 pm 2008
Paul Jackson
Re: [PATCH] [0/18] GB pages hugetlb support
What kernel version is this patchset against ... apparently not 2.6.25-rc5-mm1. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --
Mar 16, 10:35 pm 2008
Andi Kleen
[PATCH] [3/18] Convert /proc output code over to report ...
I chose to just report the numbers in a row, in the hope to minimze breakage of existing software. The "compat" page size is always the first number. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/hugetlb.c | 59 +++++++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 20 deletions(-) Index: linux/mm/hugetlb.c =================================================================== --- linux.orig/mm/hugetlb.c +++ linux/mm/hugetlb.c @@ -683,37 +683,56 ...
Mar 16, 6:58 pm 2008
Paul Jackson
Re: [PATCH] [0/18] GB pages hugetlb support
Ok. Thanks. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --
Mar 17, 12:00 am 2008
Paul Jackson
Re: [PATCH] [0/18] GB pages hugetlb support
Andi, Are all the "interesting" cpuset related changes in patch: [PATCH] [1/18] Convert hugeltlb.c over to pass global state around in a structure ? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.940.382.4214 --
Mar 16, 8:11 pm 2008
Andi Kleen
[PATCH] [11/18] Fix alignment bug in bootmem allocator
Without this fix bootmem can return unaligned addresses when the start of a node is not aligned to the align value. Needed for reliably allocating gigabyte pages. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/bootmem.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux/mm/bootmem.c =================================================================== --- linux.orig/mm/bootmem.c +++ linux/mm/bootmem.c @@ -197,6 +197,7 @@ __alloc_bootmem_core(struct bootmem_data { ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [4/18] Add basic support for more than one h ...
Fixed thanks. Indeed description went wrong on 4/18 2/ was the correct one. -Andi --
Mar 17, 1:15 am 2008
Adam Litke
Re: [PATCH] [0/18] GB pages hugetlb support
On Mon, 2008-03-17 at 02:58 +0100, Andi Kleen wrote: I bet copy_hugetlb_page_range() is causing your complaints. It takes the dest_mm->page_table_lock followed by src_mm->page_table_lock inside a loop and hasn't yet been converted to call spin_lock_nested(). A I am not sure how well LTP is tracking mainline development in this area. How do these patches do with the libhugetlbfs test suite? We are adding support for ginormous pages (1GB, 16GB, etc) but it is not complete. Should run ...
Mar 17, 8:05 am 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
i = ALIGN(i+offset, incr) - offset; also the one in fail_block... only happen when align is large than alignment of node_boot_start. YH --
Mar 17, 12:53 am 2008
Andi Kleen
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64
Yes, but that was already there before. I didn't change it. I agree it should be fixed, but i would prefer to not mix PPC specific patches into my patchkit so I hope someone Not all architectures support hugepagesz=, in particular i386 does not and possibly others. It is implemented by arch specific code. -Andi --
Mar 17, 2:59 am 2008
Andi Kleen
[PATCH] [0/18] GB pages hugetlb support
This patchkit supports GB pages for hugetlb on x86-64 in addition to 2MB pages. This is the sucessor of an earlier much simpler patchkit that allowed to set the hugepagesz globally at boot to 1GB pages. The advantage of this more complex patchkit is that it allows 2MB page users and 1GB page users to coexist (although not on the same hugetlbfs mount points) It first adds some straight-forward infrastructure to hugetlbfs to support multiple page sizes. Then it uses that infrastructure ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [8/18] Add a __alloc_bootmem_node_nopanic
Straight forward variant of the existing __alloc_bootmem_node, only Signed-off-by: Andi Kleen <ak@suse.de> difference is that it doesn't panic on failure Signed-off-by: Andi Kleen <ak@suse.de> --- include/linux/bootmem.h | 4 ++++ mm/bootmem.c | 12 ++++++++++++ 2 files changed, 16 insertions(+) Index: linux/mm/bootmem.c =================================================================== --- linux.orig/mm/bootmem.c +++ linux/mm/bootmem.c @@ -471,6 +471,18 @@ void * ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [0/18] GB pages hugetlb support
This was against 2.6.25-rc4 -Andi --
Mar 16, 11:58 pm 2008
Andi Kleen
[PATCH] [16/18] Add huge pud support to hugetlbfs
Straight forward extensions for huge pages located in the PUD instead of PMDs. Signed-off-by: Andi Kleen <ak@suse.de> --- arch/ia64/mm/hugetlbpage.c | 6 ++++++ arch/powerpc/mm/hugetlbpage.c | 5 +++++ arch/sh/mm/hugetlbpage.c | 5 +++++ arch/sparc64/mm/hugetlbpage.c | 5 +++++ arch/x86/mm/hugetlbpage.c | 25 ++++++++++++++++++++++++- include/linux/hugetlb.h | 5 +++++ mm/hugetlb.c | 9 +++++++++ 7 files changed, 59 insertions(+), ...
Mar 16, 6:58 pm 2008
Paul Jackson
Re: [PATCH] [0/18] GB pages hugetlb support
Well, from what I can see, Ken Chen wrote the code that deals with constraints on hugetlb allocation. So I'll copy him on this reply, along with the other two subject matter experts I know of in this area, Christoph Lameter and Adam Litke. The following is the only cpuset related change I saw in this patchset. It looks pretty obvious to me ... just changing the code to adapt to Andi's new 'struct hstate' for holding what had been global hugetlb state. @@ -1228,18 +1252,18 @@ static int ...
Mar 17, 2:26 am 2008
Andi Kleen
[PATCH] [1/18] Convert hugeltlb.c over to pass global st ...
Large, but rather mechanical patch that converts most of the hugetlb.c globals into structure members and passes them around. Right now there is only a single global hstate structure, but most of the infrastructure to extend it is there. Signed-off-by: Andi Kleen <ak@suse.de> --- arch/ia64/mm/hugetlbpage.c | 2 arch/powerpc/mm/hugetlbpage.c | 2 arch/sh/mm/hugetlbpage.c | 2 arch/sparc64/mm/hugetlbpage.c | 2 arch/x86/mm/hugetlbpage.c | 2 ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [2/18] Add basic support for more than one h ...
No the later patch only supports GB and MB. If you want KB you have to do it yourself. If there was a reason I forgot it. Doesn't really matter much either way. -Andi --
Mar 17, 1:44 pm 2008
Adam Litke
Re: [PATCH] [0/18] GB pages hugetlb support
Libhugetlbfs comes with a rigorous functional test suite. It has test cases for specific bugs that have since been fixed. I ran it on your patches and got an oops around hugetlb_overcommit_handler() when running the 'counters' test. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center --
Mar 17, 8:59 am 2008
Adam Litke
Re: [PATCH] [1/18] Convert hugeltlb.c over to pass globa ...
I didn't see anything fundamentally wrong with this... In fact it is looking really nice notwithstanding the minor nits below. Could you define a macro for (1 << huge_page_order(h))? It is used at least 4 times. How about something like pages_per_huge_page(h) or something? I think that would convey the meaning more clearly. Whitespace? Whitespace? -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center --
Mar 17, 1:15 pm 2008
Andi Kleen
[PATCH] [12/18] Add support to allocate hugetlb pages th ...
This is needed on x86-64 to handle GB pages in hugetlbfs, because it is not practical to enlarge MAX_ORDER to 1GB. Instead the 1GB pages are only allocated at boot using the bootmem allocator using the hugepages=... option. These 1G bootmem pages are never freed. In theory it would be possible to implement that with some complications, but since it would be a one-way street (> MAX_ORDER pages cannot be allocated later) I decided not to currently. The > MAX_ORDER code is not ifdef'ed per ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [6/18] Add support to have individual hstates fo ...
- Add a new pagesize= option to the hugetlbfs mount that allows setting the page size - Set up pointers to a suitable hstate for the set page size option to the super block and the inode and the vma. - Change the hstate accessors to use this information - Add code to the hstate init function to set parsed_hstate for command line processing - Handle duplicated hstate registrations to the make command line user proof Signed-off-by: Andi Kleen <ak@suse.de> --- fs/hugetlbfs/inode.c | ...
Mar 16, 6:58 pm 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
please check the one against -mm and x86.git ---
Mar 17, 1:10 am 2008
Adam Litke
Re: [PATCH] [4/18] Add basic support for more than one h ...
With this patch you will call try_to_free_low on all registered page sizes. As written, when a user reduces the number of one page size, all page sizes could be affected. I don't think that's what you want to do. Perhaps just call do_try_to_free_low() on the hstate in question. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center --
Mar 17, 1:28 pm 2008
Andi Kleen
[PATCH] [14/18] Clean up hugetlb boot time printk
- Reword sentence to clarify meaning with multiple options - Add support for using GB prefixes for the page size - Add extra printk to delayed > MAX_ORDER allocation code Signed-off-by: Andi Kleen <ak@suse.de> --- mm/hugetlb.c | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) Index: linux/mm/hugetlb.c =================================================================== --- linux.orig/mm/hugetlb.c +++ linux/mm/hugetlb.c @@ -510,6 +510,15 @@ ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
No offset is not enough because it is still relative to the zone start. I'm preparing an updated patch. -Andi --
Mar 17, 1:17 am 2008
Andi Kleen
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
It's possible that there are better fixes for this, but at least my simple patch seems to work here. I admit I was banging my head against this for some time and when I did the fix I just wanted the bug to go away and didn't really go for subtleness. The bootmem allocator is quite spaghetti in fact, it could really need some general clean up (although it's' not quite as bad yet as page_alloc.c) -Andi --
Mar 17, 12:41 am 2008
Paul Jackson
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64
Andi wrote: + hugepages= [HW,X86-32,IA-64] HugeTLB pages to allocate at boot. + hugepagesz= [HW,IA-64,PPC,X86-64] The size of the HugeTLB pages. + On x86 this option can be specified multiple times + interleaved with hugepages= to reserve huge pages + of different sizes. Valid pages sizes on x86-64 + are 2M (when the CPU supports "pse") and 1G (when the + CPU supports the "pdpe1gb" cpuinfo flag) + Note that 1GB pages can only be allocated at boot time + using hugepages= and not ...
Mar 17, 2:29 am 2008
Andi Kleen
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
> only happen when align is large than alignment of node_boot_start. Here's an updated version of the patch with this addressed. Please review. The patch is somewhat more complicated, but actually makes the code a little cleaner now. -Andi Fix alignment bug in bootmem allocator Without this fix bootmem can return unaligned addresses when the start of a node is not aligned to the align value. Needed for reliably allocating gigabyte pages. I removed the offset variable because all ...
Mar 17, 1:56 am 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
how about create local node_boot_start and node_bootmem_map that make sure node_boot_start has bigger alignment than align input. YH --
Mar 17, 11:52 am 2008
Adam Litke
Re: [PATCH] [2/18] Add basic support for more than one h ...
I'd like to avoid assuming the huge page size is some multiple of MB. PowerPC will have a 64KB huge page. Granted, you do fix this in a later patch, so as long as the whole series goes together this shouldn't cause Since mask can always be derived from order, is there a reason we don't always calculate it? I guess it boils down to storage cost vs. calculation cost and I don't feel too strongly either way. -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center --
Mar 17, 1:22 pm 2008
Andi Kleen
[PATCH] [9/18] Export prep_compound_page to the hugetlb ...
hugetlb will need to get compound pages from bootmem to handle the case of them being larger than MAX_ORDER. Export the constructor function needed for this. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/internal.h | 2 ++ mm/page_alloc.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) Index: linux/mm/internal.h =================================================================== --- linux.orig/mm/internal.h +++ linux/mm/internal.h @@ -13,6 +13,8 @@ #include ...
Mar 16, 6:58 pm 2008
Adam Litke
Re: [PATCH] [10/18] Factor out new huge page preparation ...
We do not usually preface functions in mm/hugetlb.c with "huge" and the name you have chosen doesn't seem that clear to me anyway. Could we rename it to prep_new_huge_page() or something similar? -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center --
Mar 17, 1:31 pm 2008
Andi Kleen
[PATCH] [10/18] Factor out new huge page preparation cod ...
Needed to avoid code duplication in follow up patches. This happens to fix a minor bug. When alloc_bootmem_node returns a fallback node on a different node than passed the old code would have put it into the free lists of the wrong node. Now it would end up in the freelist of the correct node. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/hugetlb.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) Index: ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [0/18] GB pages hugetlb support
Yes. Looking at the warning I'm not sure why lockdep doesn't filter it out automatically. I cannot think of a legitimate case where a "possible recursive lock" with different lock addresses would be a genuine bug. I wasn't aware of that one. -Andi --
Mar 17, 8:33 am 2008
Andi Kleen
Re: [PATCH] [0/18] GB pages hugetlb support
I just updated to 2.6.25-rc6 base on ftp://firstfloor.org/pub/ak/gbpages/patches/ and gave it a quick test. So you can use that one too. It only had a single easy reject. -Andi --
Mar 17, 12:29 am 2008
Andi Kleen
[PATCH] [17/18] Add huge pud support to mm/memory.c
mm/memory.c seems to have already gained some knowledge about huge pages: in particularly in get_user_pages. Fix that code up to support huge puds. Signed-off-by: Andi Kleen <ak@suse.de> --- mm/memory.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Index: linux/mm/memory.c =================================================================== --- linux.orig/mm/memory.c +++ linux/mm/memory.c @@ -931,7 +931,13 @@ struct page *follow_page(struct vm_area_ pud = ...
Mar 16, 6:58 pm 2008
Andi Kleen
[PATCH] [13/18] Add support to allocate hugepages of dif ...
Signed-off-by: Andi Kleen <ak@suse.de> --- include/linux/hugetlb.h | 1 + mm/hugetlb.c | 23 ++++++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-) Index: linux/mm/hugetlb.c =================================================================== --- linux.orig/mm/hugetlb.c +++ linux/mm/hugetlb.c @@ -552,19 +552,23 @@ static int __init hugetlb_init_hstate(st { unsigned long i; - for (i = 0; i < MAX_NUMNODES; ...
Mar 16, 6:58 pm 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
node_boot_start is not page aligned? YH --
Mar 16, 7:19 pm 2008
Andi Kleen
[PATCH] [4/18] Add basic support for more than one hstat ...
Signed-off-by: Andi Kleen <ak@suse.de> --- mm/hugetlb.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) Index: linux/mm/hugetlb.c =================================================================== --- linux.orig/mm/hugetlb.c +++ linux/mm/hugetlb.c @@ -550,26 +550,33 @@ static unsigned int cpuset_mems_nr(unsig #ifdef CONFIG_SYSCTL #ifdef CONFIG_HIGHMEM -static void try_to_free_low(unsigned long count) +static void do_try_to_free_low(struct hstate *h, ...
Mar 16, 6:58 pm 2008
Andi Kleen
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
> node_boot_start is not page aligned? It is, but it is not necessarily GB aligned and without this change sometimes alloc_bootmem when requesting GB alignment doesn't return GB aligned memory. This was a nasty problem that took some time to track down. -Andi --
Mar 17, 12:02 am 2008
Yinghai Lu
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
when node_boot_start is 512M alignment, and align is 1024M, offset could be 512M. it seems i = ALIGN(i, incr) need to do sth with offset... YH --
Mar 17, 12:31 am 2008
Yinghai Lu Mar 17, 2:27 pm 2008
Andi Kleen
[PATCH] [2/18] Add basic support for more than one hstat ...
- Convert hstates to an array - Add a first default entry covering the standard huge page size - Add functions for architectures to register new hstates - Add basic iterators over hstates Signed-off-by: Andi Kleen <ak@suse.de> --- include/linux/hugetlb.h | 10 +++++++++- mm/hugetlb.c | 46 +++++++++++++++++++++++++++++++++++++--------- 2 files changed, 46 insertions(+), 10 deletions(-) Index: ...
Mar 16, 6:58 pm 2008
Steven Rostedt Mar 17, 8:43 am 2008
Paul E. McKenney
[PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
Hello! In the process of writing up the mechanical proof of correctness for the dynticks/preemptable-RCU interface, I noticed misplaced memory barriers in rcu_enter_nohz() and rcu_exit_nohz(). This patch puts them in the right place and adds a comment. The key thing to keep in mind is that rcu_enter_nohz() is -exiting- the mode that can legally execute RCU read-side critical sections. The memory barrier must be between any potential RCU read-side critical sections and the increment of the ...
Mar 16, 6:08 pm 2008
Oleg Nesterov
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
Can't comment this patch, there is no rcu_enter_nohz() in my rcupreempt.h ;) I'm not sure the code below is up to date, but what I have in arch/s390/kernel/time.c is: stop_hz_timer: cpu_set(cpu, nohz_cpu_mask); if (rcu_needs_cpu(cpu) || local_softirq_pending()) { cpu_clear(cpu, nohz_cpu_mask); return; } Don't we need smp_mb() after cpu_set() ? Oleg. --
Mar 17, 11:30 am 2008
Paul E. McKenney
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
If you mean that the rcu_needs_cpu() executes before the cpu_set() in the code fragment above, while the rcu_start_batch() executes on some other CPU? Hmmm.... Can't see why this wouldn't be a problem, right off-hand, though I cannot claim to be an s390 expert. Heiko, thoughts? --
Mar 17, 1:43 pm 2008
Nick Piggin
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
Can you make these smp_mb() as well? Thanks, Nick --
Mar 16, 8:09 pm 2008
Paul E. McKenney
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
Can't see why not, now that you mention it. Steve, anything Nick and I are missing here? (See updated patch below.) Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> --- rcupreempt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -urpNa -X dontdiff linux-2.6.25-rc6/include/linux/rcupreempt.h linux-2.6.25-rc6-rcu_nohz-fix/include/linux/rcupreempt.h --- linux-2.6.25-rc6/include/linux/rcupreempt.h 2008-03-16 17:45:16.000000000 -0700 +++ ...
Mar 16, 10:54 pm 2008
Paul E. McKenney
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
S390's memory model is quite strong, so it might not be needed. In any case, if needed, it goes -before- the cpu_set(), because the problems would arise if prior RCU read-side critical sections were to be reordered to follow this cpu_set(), right? Let's see... In S390, a store cannot be reordered to precede any prior load or store, so any preceding RCU read-side critical section would be seen by all CPUs as preceding the shift to nohz mode. Might be trouble for the opposite ...
Mar 17, 12:06 pm 2008
Oleg Nesterov
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
(to clarify: my question is completely offtopic to this patch) No, but it is very possible I missed something. What if rcu_needs_cpu(cpu) is executed before cpu_set(cpu, nohz_cpu_mask)? It can miss rcu_start_batch() -> rcp->cur++ and return false, but at the same time rcu_start_batch() may see nohz_cpu_mask without this CPU. No? Oleg. --
Mar 17, 1:17 pm 2008
Oleg Nesterov
Re: [PATCH] fix misplaced mb() in rcu_enter/exit_nohz()
Yes, and __rcu_pending() sees the old value of ->cur. IOW. Suppose that this CPU reads rcp->cur out of order. To simplify, let's suppose that stop_hz_timer() on CPU_0 in fact does xxx = rcu_needs_cpu(cpu); // false // ---- WINDOW ------ cpu_set(cpu, nohz_cpu_mask); if (xxx || local_softirq_pending()) { ... abort ... } ...proceed... Another CPU does rcu_start_batch() in the window above. In that case rcp->cpumask will include CPU_0, and the grace period can't be ...
Mar 17, 2:23 pm 2008
Yinghai Lu Mar 16, 5:38 pm 2008
Jesse Barnes
Re: [PATCH] x86: trim mtrr don't close gap for resource ...
The new function could probably use some higher level comments (though the rest of the e820 routines seem similarly devoid of description so it's not a big deal). And given that this patch fixes a regression, it should probably get upstream quickly. Thanks for fixing this so quickly, Yinghai. Acked-by: Jesse Barnes <jesse.barnes@intel.com> --
Mar 17, 9:35 am 2008
Dave Airlie
[git pull] drm fixes for linux-2.6.25-rc6
Hi Linus, Please pull the 'drm-fixes' branch from ssh://master.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git drm-fixes Sorry this is so late, but a number of things cropped up in the last week I thought were urgent enough to get into 2.6.25 final. The PCI GART changes should fix '2.6.25-rc3 + RS690 + DRM + xf86-video-ati hang' The VIA fixes are for a number of upstream bugs, along with the pci ids fixups so we work properly on a new series of ATI cards. Dave. ...
Mar 16, 5:36 pm 2008
Jean Delvare
Re: Linux 2.6.25-rc6
Hi Gabriel, This has been reported as: http://bugzilla.kernel.org/show_bug.cgi?id=10259 https://bugzilla.redhat.com/show_bug.cgi?id=437637 The generic thermal zone device does something which is not fundamentally incorrect but that libsensors doesn't expect, and unfortunately libsensors was not made robust enough and dies instead of just ignoring the new unexpected device. libsensors 2.10.x is already fixed in lm-sensors' SVN [1] and a tentative patch is available for libsensors 3.0.x ...
Mar 17, 11:39 am 2008
Gabriel C
Re: Linux 2.6.25-rc6
That commit broke lmsensros here ( found by bisect ). ... Can't access procfs/sysfs file Kernel interface access error For 2.6 kernels, make sure you have mounted sysfs and libsensors was compiled with sysfs support! ... Of course proc and sysfs is mounted and the lib has that support :) Here the bisect result : git-bisect start # bad: [a978b30af3bab0dd9af9350eeda25e76123fa28e] Linux 2.6.25-rc6 git-bisect bad a978b30af3bab0dd9af9350eeda25e76123fa28e # good: ...
Mar 17, 7:34 am 2008
Linus Torvalds
Linux 2.6.25-rc6
Ok, I lost a day-and-a-half this week due to a disk that decided to get read errors due to an unfortunate power outage, and had to spend too much time regenerating my normal setup, but I don't think I lost any emails, and things seemed to have calmed down a bit, so here's to hoping that -rc6 is starting to look better. The dirstat shows the usual pattern of most changes being in drivers and architecture updates, although this time it's a bit skewed by the parisc and powerpc updates ...
Mar 16, 5:01 pm 2008
Jean Delvare
Re: Linux 2.6.25-rc6
I completely agree that it shouldn't have been included that late in the release cycle, in particular when it obviously received no testing at all (it breaks all versions of lm-sensors.) The reason why it was merged is that some people feared that application authors would add support for the new thermal zone interface (/sys/class/thermal) quickly instead of waiting for the same information to be exported through the standard hwmon interface (/sys/class/hwmon) which libsensors supports. This ...
Mar 17, 1:33 pm 2008
Gabriel C
Re: Linux 2.6.25-rc6
Hmm , ok but then the situation is even worse. Why something *known* to break _all_ existing lmsensors setups out there is being pushed that late in game ? IMO that should be just reverted from 2.6.25 and pushed again in the next merge window. Best Regards, Gabriel --
Mar 17, 12:35 pm 2008
Thomas Gleixner
Re: 2.6.25-rc5-git6: Reported regressions from 2.6.24
No, I have not the lightest clue whats going on. Thanks, tglx --
Mar 17, 9:17 am 2008
Jason Wu Mar 16, 11:47 pm 2008
Rafael J. Wysocki Mar 17, 2:36 pm 2008
Gabriel C Mar 17, 11:20 am 2008
Gabriel C
Re: 2.6.25-rc5-git6: Reported regressions from 2.6.24
Rafael J. Wysocki wrote: Thomas do you want me to bisect ? Or do you have any patches I could try ( really does not matter how experimental they are ) ? Rafael the bug report is saying x86-64 Component while my box is 32bit :) Could you please correct this ? Best Regards Gabriel --
Mar 16, 5:20 pm 2008
Stefan Bauer
Re: [PATCH] i810fb: Fix console switch regression
Yes, IMO you are right. 4c7ffe0 ("fbdev: prevent drivers that have hardware cursors from calling software cursor code") introduced the senseless code. I'm going on testing today, but I think that's it. Again, please CC me, thanks. --- From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de> Since 4c7ffe0b9f7f40bd818fe3af51342f64c483908e ("fbdev: prevent drivers that have hardware cursors from calling software cursor code") every call of i810fb_cursor fails with -ENXIO because of a ...
Mar 17, 1:20 am 2008
Stefan Bauer
Re: [PATCH] i810fb: Fix console switch regression
I'm sorry for the spaces in the second patch, here's a clean one with tabs. --- From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de> Since 4c7ffe0b9f7f40bd818fe3af51342f64c483908e ("fbdev: prevent drivers that have hardware cursors from calling software cursor code") every call of i810fb_cursor fails with -ENXIO because of a incorrect "!". This hasn't striked until eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! versus & precedence in various places") surrounded the expression with ...
Mar 17, 8:41 am 2008
YAMAMOTO Takashi
Re: [RFC][2/3] Account and control virtual address space ...
i think you can sum and uncharge it with a single call. YAMAMOTO Takashi --
Mar 17, 4:35 pm 2008
Paul Menage
Re: [RFC][0/3] Virtual address space control for cgroups
Would it? Other than the basic cgroup boilerplate, the only real duplication that I could see would be that there'd need to be an additional per-mm pointer back to the cgroup. (Which could be avoided if we added a single per-mm pointer back to the "owning" task, which would generally be the mm's thread group leader, so that you could go quickly from an mm to a set of cgroup subsystems). And the advantage would that you'd be able to more easily pick/choose which bits of control you use (and ...
Mar 16, 6:57 pm 2008
Balbir Singh
Re: [RFC][2/3] Account and control virtual address space ...
1. We need to account total_vm usage of the task anyway. So why have two places, one for accounting and second for control? 2. These hooks are activated for conditionally invoked for vma's with VM_ACCOUNT set. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 17, 5:51 am 2008
Balbir Singh
Re: [RFC][0/3] Virtual address space control for cgroups
Not really. Virtual limits are more gentle than an OOM kill that can occur if the cgroup runs out of memory. Please also see Yes, a disk I/O and swap I/O controller are being developed (not by us, but others in the community). How does one restrict swap space for a particular application? I can think of RLIMIT_AS for a process and something similar to what I've posted for cgroups. Not enabling swap is an option, but not very practical IMHO. -- Warm Regards, Balbir Singh Linux ...
Mar 16, 8:12 pm 2008
Paul Menage
Re: [RFC][2/3] Account and control virtual address space ...
How about if this function avoided charging the root cgroup? You'd save 4 atomic operations on a global data structure on every mmap/munmap when the virtual address limit cgroup wasn't in use, which could be significant on a large system. And I don't see situations where you really need to limit the address space of the root cgroup. Paul --
Mar 16, 7:02 pm 2008
Paul Menage
Re: [RFC][0/3] Virtual address space control for cgroups
Yes, but we don't have mm->owner, which is what I was proposing - mm->owner would be a pointer typically to the mm's thread group leader. It would remove the need to have to have pointers for the various different cgroup subsystems that need to act on an mm rather than a task_struct, since then you could use mm->owner->cgroups[subsys_id]. But this is kind of orthogonal to whether virtual address space limits should be a separate cgroup subsystem. Paul --
Mar 16, 10:22 pm 2008
Balbir Singh
Re: [RFC][2/3] Account and control virtual address space ...
4 atomic operations is very tempting, but we want to account for root usage due to the following reasons: 1. We want to be able to support hierarchial accounting and control 2. We want to track usage of the root cgroup and report it back to the user 3. We don't want to treat the root cgroup as a special case. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 16, 7:57 pm 2008
Pavel Emelyanov
Re: [RFC][2/3] Account and control virtual address space ...
So? What prevents us from using these hooks? :) --
Mar 17, 5:40 am 2008
Balbir Singh
Re: [RFC][0/3] Virtual address space control for cgroups
Aaahh.. Yes.. mm->owner might be a good idea. The only thing we'll need to handle is when mm->owner dies (I think the thread group is still kept around). The other disadvantage is the double dereferencing, which should not be all that Yes, sure. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 17, 8:15 am 2008
Paul Menage
Re: [RFC][0/3] Virtual address space control for cgroups
I'm a counter-example to your suspicion :-) Trying to control virtual address space is a complete nightmare in the presence of anything that uses large sparsely-populated mappings (mmaps of large files, or large sparse heaps such as the JVM uses.) If we want to control the effect of swapping, the right way to do it is to control disk I/O, and ensure that the swapping is accounted to that. Or simply just not give apps much swap space. Paul --
Mar 16, 6:55 pm 2008
Dave Hansen
Re: [RFC][2/3] Account and control virtual address space ...
I think splattering these things all over is probably a bad idea. If you're going to do this, I think you need a couple of phases. 1. update the vm_(un)acct_memory() functions to take an mm 2. start using them (or some other abstracted functions in place) 3. update the new functions for cgroups It's a bit non-obvious why you do the mem_cgroup_update_as() calls in the places that you do from context. Having some other vm-abstracted functions will also keep you from splattering ...
Mar 17, 9:53 am 2008
Balbir Singh
Re: [RFC][0/3] Virtual address space control for cgroups
I understand the per-mm pointer overhead back to the cgroup. I don't understand the part about adding a per-mm pointer back to the "owning" task. We already have task->mm. BTW, the reason by we directly add the mm_struct to mem_cgroup mapping is that there are contexts from where only the mm_struct is known (when we charge/uncharge). Assuming that current->mm's mem_cgorup is the one we want I am not sure I understand your proposal fully. But, if it can help provide the flexibility you are ...
Mar 16, 10:08 pm 2008
Paul Menage
Re: [RFC][2/3] Account and control virtual address space ...
On Mon, Mar 17, 2008 at 10:57 AM, Balbir Singh Why? It is a special case, in that in a lot of machines there's only going to be the root cgroup, and the subsystem won't be mounted. So in those cases, paying any overhead is a cost without a benefit. Alternatively, how about you skip tracking virtual address space changes if the virtual address cgroup isn't mounted on any hierarchy? When you mount it, you can do a pass across all mms and set the root cgroup usage to their total. Paul --
Mar 16, 8:03 pm 2008
Balbir Singh
Re: [RFC][2/3] Account and control virtual address space ...
I am not sure I understand your proposal. Without manually placing these hooks how do we track 1. When the vm size has increased/decreased 2. In case due to some reason, the call following these hooks fail, how do we Not sure I understand -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 17, 7:39 am 2008
Balbir Singh
Re: [RFC][3/3] Update documentation for virtual address ...
-- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 16, 6:33 pm 2008
Pavel Emelyanov
Re: [RFC][2/3] Account and control virtual address space ...
We still have two of them even placing hooks in each place manually. Besides, putting the mem_cgroup_(un)charge_as() in these vm hooks will 1. save the number of places to patch 2. help keeping memcgroup consistent in case someone adds more places that expand tasks vm (arches, drivers) - in case we have our hooks This is a good point against. But, wrt my previous comment, can we handle this somehow? --
Mar 17, 6:01 am 2008
Li Zefan
Re: [RFC][0/3] Virtual address space control for cgroups
It will be code duplication to make it a new subsystem, and it will be useful to control both of them, am I right? :) So could we just add a CONFIG to this patch series, like: CONFIG_CGROUP_MEM_RES_AS_CTLR --
Mar 16, 6:47 pm 2008
Balbir Singh
Re: [RFC][2/3] Account and control virtual address space ...
I thought about it and almost used may_expand_vm(), but there is a slight catch there. With cap_vm_enough_memory() or security_vm_enough_memory(), they are called after total_vm has been calculated. In our case we need to keep the cgroups equivalent of total_vm up to date, and we do this in mem_cgorup_update_as. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 17, 5:29 am 2008
Balbir Singh
Re: [RFC][0/3] Virtual address space control for cgroups
I am yet to measure the performance overhead of the accounting checks. I'll try and get started on that today. I did not consider making it a separate system, because I suspect that anybody wanting memory control would also want address space control (for the advantages listed in the documentation). I am not against the idea of making it a separate subsystem, but first let me get back with the numbers. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
Mar 16, 6:50 pm 2008
Pavel Emelyanov
Re: [RFC][2/3] Account and control virtual address space ...
No, please, no. Let's make two calls - mem_cgroup_charge_as and mem_cgroup_uncharge_as. Why not use existintg cap_vm_enough_memory and co? [snip] --
Mar 17, 4:36 am 2008
Elias Oltmanns
Re: [PATCH 4/4] disk-protect: Add a generic block layer ...
Come to think of it, the lock really shouldn't be released between modding / checking the timer and issuing the respective command. This makes the whole thing a bit messy because allocating a request the standard way is done before acquiring the spin_lock. Since we don't know at that time whether a command is actually going to be enqueued, this looks rather suboptimal to me. A better idea anyone? Regards, Elias
Mar 17, 4:00 pm 2008
Oleg Nesterov
Re: [PATCH 4/5] don't panic if /sbin/init exits or killed
Agreed. It was either killed, or exited. The exit code provides enough info. Thanks, I'll resend this patch. Oleg. --
Mar 16, 5:05 pm 2008
Ananth N Mavinakayan ...
Re: [PATCH] Subject: kprobes-x86: correct post-eip value ...
Of course, there still are other ways to shoot yourself in the foot with the post_handler(), but, atleast for cases we can control, we need to do the right thing. Ananth --
Mar 17, 5:39 am 2008
Yakov Lerner
Re: [PATCH] Subject: kprobes-x86: correct post-eip value ...
On Mon, Mar 17, 2008 at 7:19 AM, Ananth N Mavinakayanahalli I see your point. This can be prevented by saving and restoring regs->ip around the post_handler() call, no ? Current code is beautiful. Saving and restoring regs->ip would make this place look ugly. Otoh, if the post_handler() wants to crash the kernel, it can do it in thousand ways, not just by trashing regs->ip, no ? Yakov --
Mar 17, 3:59 am 2008
Masami Hiramatsu
Re: [PATCH] Subject: kprobes-x86: correct post-eip value ...
Ananth, I think we can not prevent it even if resume_execution() is called after post_handler, because resume_execution() refers reg->ip...:-( And Yakov, I think you might need to make a patchset against all arch which support kprobes, because this patch modifies expected behavior of kprobes only on x86. IMHO, Yakov's suggestion will be also good for resume_execution(), because it only has to clean up after expectable-single-stepping. (user code is unexpectable... we can not control all of ...
Mar 17, 3:17 pm 2008
Ananth N Mavinakayan ...
Re: [PATCH] Subject: kprobes-x86: correct post-eip value ...
resume_execution() exists not just for the program counter fixups after out-of-line singlestepping, but is also as an insurance to put the program counter back to the correct address in case the user's post_handler() mucks around with it. That isn't possible with this change :-( Ananth --
Mar 16, 10:19 pm 2008
Jarod Wilson
Re: [PATCH] firewire: fix panic in handle_at_packet
Panics hooking up to an x86 mac mini in target disk mode are gone on my end with this patch added, and the fix makes sense -- assuming I've got it right, in my head, of course. ;) As I understand it, we'll now simply bail in handle_at_packet when we see packet == NULL, rather than trying to play with already freed memory, and cancelling an AT packet here should always be perfectly safe, because we're already onto the AR side of this transaction, and in most cases, the AT handler already ...
Mar 16, 8:32 pm 2008
Jeff Garzik Mar 17, 4:58 am 2008
Jeff Garzik Mar 17, 4:58 am 2008
Kok, Auke Mar 17, 9:37 am 2008
Takashi Iwai
Re: [PATCH 4/7] sound/pci: remove unused variable
[Dropped wrong Cc's] At Sat, 15 Mar 2008 17:03:51 +0100 (CET), This shouldn't be removed. This value should be returned from the This looks superfluous indeed. Applied to ALSA tree now. Thanks, Takashi --
Mar 17, 2:20 am 2008
Patrick McHardy Mar 17, 6:55 am 2008
Jeff Dike
Re: [2.6.24.x] UML select()/poll() oversleeping reproduc ...
I'm seeing the same thing with tickless disabled on current UML - stay tuned... Jeff -- Work email - jdike at linux dot intel dot com --
Mar 17, 9:27 am 2008
Jeff Dike
Re: [2.6.24.x] UML select()/poll() oversleeping reproduc ...
Below is the same patch with another kluge, which cuts down the requested sleep by 10% in hopes of getting the actual sleep closer to what's wanted. This is unusable in anything resembling mainline, but I'd like to see how your various systems react to it. I'm getting very close to the sleeps I asked for (with slight undersleeping, which is a bug). Jeff -- Work email - jdike at linux dot intel dot com Index: ...
Mar 17, 12:34 pm 2008
Jeff Dike
Re: [2.6.24.x] UML select()/poll() oversleeping reproduc ...
See what kind of difference the patch below makes - it reduces the 30% oversleeping down to 10% for me. That's still way too much, but it's better. The problem being fixed here is that setitimer consistently returns a remaining time greater than what was originally requested, by ~20%: 1205773032.413780 setitimer(ITIMER_VIRTUAL, {it_interval={0, 10000}, it_value={0, 10000}}, NULL) = 0 1205773032.413814 setitimer(ITIMER_VIRTUAL, {it_interval={0, 0}, it_value={0, 0}}, {it_interval={0, 10998}, ...
Mar 17, 10:03 am 2008
Nix
Re: [2.6.24.x] UML select()/poll() oversleeping reproducibly
OK. Tests on host with clocksource pit: bash-3.2# bin/select-sleep 5 Slept for 5 seconds. bash-3.2# bin/select-sleep 10 Slept for 11 seconds. bash-3.2# bin/select-sleep 30 Slept for 31 seconds. bash-3.2# bin/select-sleep 60 Slept for 61 seconds. ... so much better than the 4x error without this patch. Tests on host with clocksource tsc: bash-3.2# bin/select-sleep 5 Slept for 5 seconds. bash-3.2# bin/select-sleep 10 Slept for 10 seconds. bash-3.2# bin/select-sleep 30 Slept ...
Mar 17, 2:08 pm 2008
Jan Kara
Re: WARNING: at fs/buffer.c:1183 mark_buffer_dirty
Not a real problem. We tried to mark as dirty buffer, which did not contain uptodate data (because the device has been removed). This is harmless. Thanks for report anyway. -- Jan Kara <jack@suse.cz> SuSE CR Labs --
Mar 17, 8:24 am 2008
Masami Hiramatsu
Re: [PATCH -mm 1/5] list.h: add list_singleton
Hi Peter, Indeed. I have some other candidates. - list_single - list_has_one - list_one Could you tell me which or some other name you recommend? Thanks, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com --
Mar 17, 8:04 am 2008
Peter Zijlstra
Re: [PATCH -mm 1/5] list.h: add list_singleton
I think list_has_one() or list_is_singular() are good names, they convey they are a test for a condition by using a form of be. --
Mar 17, 8:13 am 2008
Masami Hiramatsu
[PATCH -mm] list.h: rename list_singleton to list_is_singular
Rename list_singleton to list_is_singular. Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com> --- OK, I picked up list_is_singular(). Thanks, include/linux/list.h | 4 ++-- kernel/kprobes.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Index: 2.6.25-rc5-mm1/include/linux/list.h =================================================================== --- 2.6.25-rc5-mm1.orig/include/linux/list.h +++ 2.6.25-rc5-mm1/include/linux/list.h @@ -212,10 +212,10 @@ ...
Mar 17, 1:52 pm 2008
Andrew Morton
Re: [PATCH 8/8] handle leap second via timer
On Sat, 15 Mar 2008 04:18:39 +0100 (CET) It sounds like a few updates are in the pipeline, but I merged this series as-is into -mm. I'll normally push ntp changes through Thomas's git-hrt tree, however this patch series has dependencies upon at least introduce-explicit-signed-unsigned-64bit-divide.patch convert-a-few-do_div-user.patch rename-div64_64-to-div64_u64.patch rename-div64_64-to-div64_u64-mm.patch remove-div_long_long_rem.patch so they can't go into git-hrt immediately. The ...
Mar 17, 3:18 pm 2008
Randy Dunlap
Re: [PATCH] x86: don't allow KVM_CLOCK without HAVE_KVM
They do generally mutually exclude each other. I think that the problem is just that dirty old "select PARAVIRT" in config KVM_CLOCK. PARAVIRT depends on !(X86_VISWS || X86_VOYAGER), but "select" doesn't care^W honor that. As Documentation/kbuild/kconfig-language.txt says: "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over. ...
Mar 17, 8:55 am 2008
Avi Kivity
Re: [kvm-devel] [PATCH] x86: don't allow KVM_CLOCK witho ...
A depends is horrible from the user point of view as it hides the feature completely if paravirt is not enabled. So your original workaround is probably best. Or maybe depends on PARAVIRT_CAPABLE selects PARAVIRT Where PARAVIRT_CAPABLE is a synonym for !(X86_REMOVE_ME || X86_TOTAL_SILLYNESS), so we don't have to repeat it everywhere. -- error compiling committee.c: too many arguments to function --
Mar 17, 10:01 am 2008
Eric Paris
Re: Audit vs netlink interaction problem
It looks reasonable to me. If you can send a tested patch with a good description to linux-audit@redhat.com I can work it into mainline. -Eric --
Mar 17, 12:41 pm 2008
Pavel Emelyanov
Re: Audit vs netlink interaction problem
audit_init() creates a kernel-side socket, while we need to know the pid of a user-side one. But I saw your patch, seems like the NETLINK_CB(skb).pid --
Mar 17, 12:59 am 2008
Pavel Emelyanov
Re: Audit vs netlink interaction problem
Looks great, all the more so I created very similar patch. David, can we have this in mainline some day? Thanks, --
Mar 17, 1:01 am 2008
Pavel Machek
Re: Timer interrupt stops, causes soft lockup
Does nosmp help? Does noapic/nolapic help? You may want to try testing with HZ=4000... to show the problem faster. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html --
Mar 17, 8:46 am 2008
Randy Dunlap Mar 17, 8:02 am 2008
Martin Schwidefsky
Re: [patch 2/2] zcrypt: add support for large random numbers
True. This is done consistently wrong in the zcrypt driver. I would prefer to do a separate kernel-doc cleanup patch and leave this patch as it is. Ok ? -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. --
Mar 17, 2:44 am 2008
Jens Axboe
Re: blktrace/relay/s390: Oops in subbuf_splice_actor
If the problem is in the splice part of relay, then the problem will likely go away if you add the -s parameter to blktrace. Might be handy to know if you are experimenting. -- Jens Axboe --
Mar 17, 1:08 am 2008
Christof Schmitt
Re: blktrace/relay/s390: Oops in subbuf_splice_actor
I still have your patch applied. blktrace with -s returns the trace data, as expected and blktrace without the -s returns data, but nothing useful for blkparse. Christof --
Mar 17, 8:19 am 2008
Nick Piggin
Re: [PATCH v1] change likeliness accounting
0.01%, so 1 time every 10 000 tests. That seems pretty excessive. If the 9 999 tests which were taken correctly each saved only 0.1 cycle due to the likely annotation, then that would be implying the same likely annotation adds 1 000 cycles to the cost of the branch when taken that way. In practice, I'd say it is probably just going to cost an extra icache miss, another jump, and maybe a cycle here or there... 100 cycles at worst. And the benefit might also be larger than 0.1 cycle because ...
Mar 16, 7:45 pm 2008
Justin Madru
Re: [Regression: 2.6.25-rc5: Blank Screen: Intel 945]
I'm just compiling the intel_reg_dumper right? I don't have to recompile all of X to use it? Ok, got that. I tried to compile and I found out I also had to install libpciaccess-dev, that's probably because I'm using the git tree and not the one that Ubuntu 7.10 uses. But I still can't compile the intel_reg_dumper I get the following error: intel-driver/src/reg_dumper$ make gcc -DHAVE_CONFIG_H -I. -I../.. -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes ...
Mar 16, 6:28 pm 2008
Stephen Smalley
Re: [PATCH] cgroups: implement device whitelist lsm (v3)
By complete security model, I don't mean it has to be MAC+DAC +privileges. Just that it does in fact implement a well formed security model, not just an ad hoc set of stupid security tricks. Smack and "One of the explicit requirements to get LSM into the kernel was to have the ability to make capabilities be a module. This allows the embedded people to completely remove capabilities, as they really want this. I don't think we can ignore this, no matter how much of a pain in the butt it ...
Mar 17, 6:26 am 2008
Serge E. Hallyn
Re: [PATCH] cgroups: implement device whitelist lsm (v3)
No I'd like to see those patches. It would ideally allow LSM to become *purely* restrictive and LPM to be purely empowering, presumably making the resulting hook sets easier to review and maintain. The LPM wouldn't (I assume) gain any *new* hook points so we wouldn't be adding any new places for hooks to be overriden by a rootkit. -serge --
Mar 17, 7:08 am 2008
Casey Schaufler
Re: [PATCH] cgroups: implement device whitelist lsm (v3)
I don't expect to put in any additional hooks points, although it's safe to bet that someone will want to pretty quickly. What I see as the big concern is our old friend the granularity question. I can pretty well predict that we'll have quite a bruhaha over whether each hook point should have it's own hook or if they should be shared based on the privilege supported. For example, in namei.c the function generic_permission() currently calls capable(CAP_DAC_OVERRIDE). The privilege supported ...
Mar 17, 9:16 am 2008
Stephen Smalley
Re: [PATCH] cgroups: implement device whitelist lsm (v3)
nit: I'd use priv_ rather than lpm_, just as we use security_ rather than lsm_. Do you plan to pass other arguments to the privilege hook call, like the object? If not, then there is no point in changing the capable call sites at all - just change its implementation to invoke a priv_capable() Changing all of the call sites seems a bit prohibitive for an initial implementation; rewiring the internals of capable() to use a new privilege hook interface would be a lot simpler. You also ...
Mar 17, 9:48 am 2008
Andy Whitcroft
Re: [PATCH] Move memory controller allocations to their ...
Yes, MOVABLE is for things which are very easily moved out, whether that is migrated to another page, or paged out to swap, or trivially freed as it can be re-read from somewhere such as text from a binary; generally this is things on the LRU. RECLAIMABLE, is things which are harder to get rid of, but for which there is some hope of evicting their contents; as you say things like -apw --
Mar 17, 4:25 am 2008
Jan Kara
Re: [PATCH 1/4] quota: Quota core changes for quotaon on ...
Good idea. Will do. Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR --
Mar 17, 6:17 am 2008
Jan Kara
Re: [PATCH 1/3] Add possibly missing iput() when quotaon ...
Yes, this can be nasty when triggered (Busy inodes after umount) and the patch is safe. Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR --
Mar 17, 6:13 am 2008
Jan Beulich
Re: [RFC] x86: bitops asm constraint fixes
That's not very desirable: For one part, because there are uses of bitops on arrays of ints (and casting these up isn't fully correct on x86-64 because of the same reason that using the bitops on char arrays isn't correct (see the other response I sent to Jeremy's reply), but also because operating on longs requires REX prefixes n x86-64, Not really, since BASE_ADDR is an input, whereas ADDR is an output. However, ultimately all uses of ADDR should go (since even if any of the functions needs ...
Mar 17, 2:16 am 2008
Jan Beulich
Re: [RFC] x86: bitops asm constraint fixes
I'm mainly afraid to break some implicit assumptions potentially made somewhere that the memory clobber is there (as e.g. implicitly The fact that a char array may be of a size that is not a multiple of the word size used by bt{,c,r,s}, i.e. you may either touch memory outside of the actual bit field (problematic if what follows is an atomic variable, and the bit operation used is not an atomic one, or if the bit array is Apparently not, as you can see from the example I gave that ...
Mar 17, 2:08 am 2008
Rusty Russell
Re: [PATCH] fix verify_export_symbols()
Hi Jan, Actually, the others did exist, they just weren't checked. I've taken this patch and your two other module patches. Please cc me on module patches in future. Thanks! Rusty. --
Mar 17, 3:36 pm 2008
Christoph Lameter
Re: hackbench regression since 2.6.25-rc
REFILL means refilling the per cpu objects from the freelist of the per cpu slab page. That could be bad because it requires taking the slab Hmmm... I was hoping that add/remove partial numbers would come down. Ok lets forget about the patch. Increasing min_objects does the trick. --
Mar 17, 10:27 am 2008
Christoph Lameter
Re: hackbench regression since 2.6.25-rc
Interesting. What is the optimal configuration for your 8p? Could you Well for a 4k cpu configu this would set min_objects to 8192. So I think we could implement a form of logarithmic scaling based on cpu counts comparable to what is done for the statistics update in vmstat.c fls(num_online_cpus()) = 4 So maybe slub_min_objects= 8 + (2 + fls(num_online_cpus())) * 4 --
Mar 17, 10:32 am 2008
Zhang, Yanmin
Re: hackbench regression since 2.6.25-rc
I collected more data on 16-p tigerton to try to find the possible relationship between slub_min_objects and processor number. Kernel is 2.6.25-rc5. Command\slub_min_objects | slub_min_objects=8 | 16 | 32 | 64 ------------------------------------------------------------------------------------- ./hackbench 100 process 2000 | 250second | 23 | 18.6 | 17.5 ./hackbench 200 process 2000 | 532 | 44 | 35.6 | 33.5 The first ...
Mar 17, 12:50 am 2008
Zhang, Yanmin
Re: hackbench regression since 2.6.25-rc
There is no much help. In 2.6.25-rc5, REFILL means refill from c->page->freelist and another_slab. It's looks like its definition is confusing. In the case of hackbench, mostly, c->page->freelist is NULL. With #hackbench 100 process 2000, 100*20*2 (totoally 4000) processes are started. vmstat shows about 300~500 processes are at RUNNING state, so every processor runqueue has more than 20 processes running on 16p tigerton. Below is the data with kernel ...
Mar 16, 8:35 pm 2008
Zhang, Yanmin
Re: hackbench regression since 2.6.25-rc
Initially I wanted to do so, but oprofile data showed both 2.6.24 and 2.6.25-rc aren't good with hachbench on tigerton. The slub_min_objects boot parameter could boost performance largely. So I think --
Mar 16, 8:05 pm 2008
Jeff Garzik
Re: [PATCH 2.6.25] - Fix transmit queue stop mechanism
applied -- please include "cxgb3: " prefix in your subject line next time. See http://linux.yyz.us/patch-format.html for more info. Jeff --
Mar 17, 5:09 am 2008
Nick Piggin
Re: question about PAE and buffercache
No. It is indeed constrained by the amount of virtual memory space the kernel has. So it could use in practice probably only around 700-800MB for buffercache. --
Mar 16, 7:27 pm 2008
Andi Kleen
Re: question about PAE and buffercache
I suspect Adam has a terminology problem and he likely meant "unmapped page cache" instead of buffer cache. In Linux "buffer cache" only refers to file system metadata (like file system bitmaps etc.), but he likely meant all file data which is in the page cache. The page cache is not limited by the kernel virtual memory split. In fact buffer cache is a special case of the page cache too iirc even large parts of the buffer cache can be highmem depending on the file system. -Andi --
Mar 17, 12:14 am 2008
Christoph Hellwig
Re: [RFC] correct flags to f_mode conversion in __dentry_open
I've tripped over this recently aswell. It would for sure be useful to add a sumbolic O_FOO constant for this magic value '3' and document it in the manpage. --
Mar 17, 3:45 am 2008
Xose Vazquez Perez
Re: linux+glibc memory allocator, poor performance
Definitely it looks like a glibc bug: http://www.kernel.org/pub/linux/kernel/people/npiggin/ebizzy/ This time google libc does not help, but jemalloc did it. yellow color(attached png) freeBSD vs. gnu malloc both in LiNUX. -thanks for test it Nick- regards, -- so much to do, so little time.
Mar 17, 11:36 am 2008
Jan Kara
Re: [PATCH] Do not allow setting of quota limits to too ...
Sorry for that. I've realized I forgot to add "quota:" only after I've sent Not really serious. Nobody complained so far (i.e., for the time quota exists) and the limits will just wrap when you try to set them over 4TB now. So the patch can wait... Honza -- Jan Kara <jack@suse.cz> SUSE Labs, CR --
Mar 17, 6:11 am 2008
Peter Teoh
Re: per cpun+ spin locks coexistence?
Thanks for the explanation, much apologies for this newbie discussion. But I still find it inexplicable: Ok, so calling get_cpu_var() always return the array-element for the current CPU, and since by design, only the current CPU can modify/write to this array element (this is my assumption - correct?), and the other CPU will just read it (using the per_cpu construct). So far correct? So why do u still need to spin_lock() to lock other CPU from accessing - the other CPU will always just ...
Mar 17, 10:06 am 2008
Johannes Weiner
Re: per cpun+ spin locks coexistence?
Hi, You ignore the fact that there are structures and pointers in C :) One and the same object may be referenced from different structure objects. For example you have an object foo saved in a cpu-local variable and this object references another object bar (foo.bar), you might do whatever you want to do with foo. But if bar is a structure you might still have to lock when you want to change the fields of it to prevent races if this bar object can be referenced from another point like ...
Mar 17, 10:51 am 2008
Eric Dumazet
Re: per cpun+ spin locks coexistence?
You are right Peter, that fs/file.c contains some leftover from previous implementation of defer queue, that was using a timer. So we can probably provide a patch that : - Use spin_lock() & spin_unlock() instead of spin_lock_bh() & spin_unlock_bh() in free_fdtable_work() since we dont anymore use a softirq (timer) to reschedule the workqueue. ( this timer was deleted by the following patch : http://readlist.com/lists/vger.kernel.org/linux-kernel/50/251040.html But, you cannot avoid ...
Mar 17, 12:22 pm 2008
Rene Herman
Re: PNP: dynamic pnp resources
Perhaps we can go organize a fundraiser for SuSE so they can go out and buy an ISAPnP soundcard. I have a few I can sell. I promise I won't overcharge Did look, but decided there wasn't much more specifically to add. It's something more fundamental about the flow of things and while the comment above is obviously cynical I did grow a bit tired of a series of patches that just transported the OOPS two lines down again each time, so I held out for Bjorn as well. Still availabe for ...
Mar 17, 3:31 pm 2008
Martin Schwidefsky
Re: [patch 0/6] Guest page hinting version 6.
Yes, on s390 the PTEs cannot be asynchronous because there is no need to synchronize them in the first place. A mapping layer with all primitives without using the SIE instruction will be difficult. For one we cannot use the ESSA instruction which isolates the state changes and host page table is tied to the SIE. The page state is stored in the page table extension and the discard state is basically a specially marked invalid pte in the host table. A mapping layer with some restrictions is If ...
Mar 17, 2:21 am 2008
J. Bruce Fields
Re: Oops in NFSv4 server in 2.6.23.17
Thanks for the confirmation.--b. --
Mar 17, 6:15 am 2008
Lukas Hejtmanek
Re: Oops in NFSv4 server in 2.6.23.17
Hello, seems to be OK even from the insecure port. Thanks. -- Lukáš Hejtmánek --
Mar 17, 1:12 am 2008
Jens Axboe
Re: [PATCH 1/7] x86-64: introduce fast variant of smp_ca ...
Have you looked at the patches you are replying to? :-) -- Jens Axboe --
Mar 17, 12:25 am 2008
Nick Piggin
Re: [PATCH 1/7] x86-64: introduce fast variant of smp_ca ...
Not really. The common cases (that I can see) are either call all, or call one. In the call all case, you would have to touch every other CPU's request list, and that's not really any better than what I've done in my patchest for that. There would presumably be some cutoff where it makes more sense to queue events to the percpu IPI lists if you are only sending to a few CPUs. That would be trivial to implement, but... what are the use-cases for that? The big one that I really know of is user ...
Mar 16, 7:24 pm 2008
Pete Zaitcev
Re: USB oops with mainline (post 2.6.25-rc5)
It's the BUG() which the new s/g API change added. I don't know exactly what caused it. It's possible that block layer is buggy by itself. Or perhaps hald sens a packet command and the conversion to the new API is not complete. In the old API drivers had to adjust the request, but in the new one the right way seems to pass the byte count into the __blk_end_request. I don't have a specific guidance regarding it, and the conversion of ub was hurried apparently. Try this, please: --- ...
Mar 16, 5:59 pm 2008
Kristen Carlson Accardi
Re: [PATCH] pciehp dont enable slot unless forced
On Mon, 17 Mar 2008 16:04:23 -0400 Acked-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> --
Mar 17, 2:13 pm 2008
Alex Chiang
Re: [regression] pciehp hang on hp ia64 rx6600
Hi Mark, Yes, this patch does revert back to previously working 2.6.24 behavior and fixes the problem for me. --
Mar 17, 12:53 pm 2008
Mark Lord
[PATCH] pciehp dont enable slot unless forced
This fixes a 2.6.25 regression reported by Alex Chiang. Invoke pciehp_enable_slot() at startup only when pciehp_force=1. Some HP equipment apparently cannot cope with it otherwise. This restores the (previously working) 2.6.24 behaviour here, while allowing machines that need a kick to use pciehp_force=1. This was the original design back in October 2007, but Kristen suggested we try without it first: Kristen Carlson Accardi wrote: >I think it would be ok to try allowing the slot ...
Mar 17, 1:04 pm 2008
Willy Tarreau
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Oh and even on servers, when your anti-virus proxy reaches a load of 800, you're happy no to have too large a time-slice so that you regularly get a chance of being allowed to type in commands over SSH. Large time-slices are needed only in HPC environments IMHO, where only one task runs. --
Mar 16, 10:21 pm 2008
Ray Lee
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
How? Are you saying that switching the granularity to, say, 25ms, will *decrease* the latency of interactive tasks? And the efficiency we're talking about reducing here is due to the fact that tasks are hitting cold caches more times per second when the granularity is smaller, correct? Or are you concerned by another Not without benchmarks of interactivity, please. There are far, far more linux desktops than there are servers. People expect to have to tune servers (I do, for the servers I ...
Mar 16, 10:16 pm 2008
Nick Piggin
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Yeah, and firefox scrolling is in the class of workloads where they adaptively reduce CPU consumption as they get less quota (ie. because they just start skipping). Still, for desktop workloads you shouldn't have to deal with lots of CPU hog processes on the runqueue, so I don't see why this is needed? I don't mind having the timeslice smallish, but it shouldn't be Yeah, thanks for looking at that. Wow, scheduler patches sure make it upstream a lot quicker than when I used to work on the ...
Mar 17, 2:56 am 2008
Nick Piggin
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Your ssh session should be allowed to run anyway. I don't see the difference. If the runqueue length is 100 and the time-slice is (say) 10ms, then if your ssh only needs average of 5ms of CPU time per second, then it should be run next when it becomes runnable. If it wants 20ms of CPU time per second, then it has to wait for 2 seconds anyway to be run next, regardless of whether That's silly. By definition if there is only one task running, you don't care what the timeslice is. We actually ...
Mar 17, 12:19 am 2008
Ingo Molnar
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
here's a performance comparison between 2.6.21 and -rc6, on a 8-socket/16-core system: http://redhat.com/~mingo/misc/sysbench-rc6.jpg [transactions/sec, higher is better] 2.6.21 2.6.25-rc5 2.6.25-rc6 ------------------------------------------------------- 1: 383.26 270.47 269.69 2: 741.02 527.67 560.52 4: 1880.79 1049.59 ...
Mar 17, 3:16 am 2008
Nick Piggin
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Um, if ssh is not using as much CPU time as the other processes running, (if it has "something very short to do") then yes it should get the CPU *right now*, regardless of what the timeslice size is. If it *is* using as much CPU time as everyone else, then it will have to wait to get time, just like everybody else; and in that case, lowering the timeslice will not help matters at all because consider if ssh has to compute for 20ms before returning control to the user, then with a 10ms timeslice ...
Mar 17, 1:54 am 2008
Nick Piggin
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Secondary issues like the actual cost of context switch, but they are Linux desktops shouldn't run with massive loads anyway. Tuning the scheduler to "work" well in an X session when you have a make -j100 in the background is retarded. But sure, if the scheduler doesn't properly prioritize non-CPU bound tasks versus CPU bound ones, then it should be fixed to do so. --
Mar 16, 10:34 pm 2008
Peter Zijlstra
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
Nick, We do grow the period as the load increases, and this keeps the slice constant - although it might not be big enough for your taste (but its tunable) Short running tasks will indeed be very likely to be run quickly after wakeup because wakeup's are placed left in the tree. (and when using sleeper fairness, can get up to a whole slice bonus). Interactivity is all about generating a scheduling pattern that is easy on the human brain - that means predictable and preferably with lags ...
Mar 17, 2:28 am 2008
Willy Tarreau
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
It's not about what *ssh* uses but about what *others* use. Except by renicing SSH or marking it real-time, it has no way to say "give the CPU to me right now, I have something very short to do". So it will have to wait for the 100 other tasks to eat their 10ms, waiting 1 second to consume 5ms of CPU (and I was speaking about 800 and not 100). It is one of the situations where I prefer to shorten timeslices when load increases because it will not slow down the service too much, but will still ...
Mar 17, 1:26 am 2008
Nick Piggin
Re: Poor PostgreSQL scaling on Linux 2.6.25-rc5 (vs 2.6.22)
OK, but the very concept of reducing efficiency when load increases is nasty, and leads to nasty feedback loops. It's just a very bad behaviour to have out of the box, and as a general observation, 10ms is too short a default timeslice IMO. I don't see how it is really helpful for interactive processes either. By definition, if they are not CPU bound, then they should be run quite soon after waking up; if they are CPU bound, then reducing efficiency by increasing context switches is ...
Mar 16, 5:44 pm 2008
Rafael J. Wysocki
Suspend and hibernation patchset against -rc6
There's a new patchset against 2.6.25-rc6 at: http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.25-rc6/patches/ It contains some more patches, specifically the "legacy PM removal" series, the fixed "PM: make wakeup flags available whenever CONFIG_PM is set" series posted recently by Alan (the second patch rebased by me), the Johannes' apm-emulation patch and the patches introducing the new suspend/hibernation callbacks I sent yesterday. Also, patches 05-06 are upstream (in the ...
Mar 17, 3:17 pm 2008
Jeff Garzik Mar 17, 5:27 am 2008
Jeff Garzik Mar 17, 5:27 am 2008
Len Brown
Re: [2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot
I agree with Linus' decision to revert/disable this feature. I think it is appropriate to muck with this in -mm, but not in -rc6 I don't think re-loading the DSDT at run-time would be practical. First, booting with the OEM DSDT may nullify the benefit of overriding the OEM DSDT -- the damage may have already been done. Secondly, unwinding everything that depends on the DSDT is on the order of kexec or suspend/resume. We're talking about all the stuff that PNP does at boot time, plus device ...
Mar 17, 10:27 am 2008
Len Brown
Re: [2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot
I recommend that you make a new proposal for 2.6.26 that applies on top of Linus' top-of-tree and that we include lkml in hashing it out rather than just linux-acpi. thanks, -Len --
Mar 17, 11:05 am 2008
Len Brown
Re: [2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot
DSDT's are generally 4KB to 64KB, so I don't think compression for a DSDT override is important. -Len --
Mar 17, 10:48 am 2008
Peter Zijlstra
Re: [2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot
Actually looks like the semaphore thing again, its a spinlock inside of Looks like another of the semaphore thingies.. Does this go away once you apply the semaphore lockdep fixup from here: http://lkml.org/lkml/2008/3/12/63 --
Mar 17, 5:23 am 2008
Daniel Lezcano
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix send ...
Thank you very much, I will try to reproduce it with a simple program. --
Mar 17, 6:17 am 2008
Daniel Lezcano Mar 17, 3:44 am 2008
Benjamin Thery
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix send ...
I also tried to reproduce your problem with Postfix (on a Debian distro) but failed to obtain the error message. While googling for the error string, I found this link which report the same kind of error when Postfix is used with grsecurity (in 2006): http://blog.jensthebrain.de/archives/2006/12/11/IPv6-Probleme-mit-Postfix-und-grsecurity I barely understand German so I'm not sure it is related to your problem. Benjamin --
Mar 17, 5:50 am 2008
Tilman Schmidt
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix send ...
m. The userspace failure described there is indeed the same as mine: Postfix' sendmail command tries to open "/proc/net/if_inet6" which fails with EACCES. But I have never installed grsecurity on this machine, and the problem appeared for me only with kernel 2.6.25-rc5-mm1, not when running kernel 2.6.25-rc5 on the same machine, so I guess the cause must be something different. What's also strange is that I can "cat /proc/net/if_inet6" from the command line as the same non-root user with ...
Mar 17, 6:35 am 2008
Tilman Schmidt
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix send ...
It's the one that comes with openSUSE 10.3: ts@xenon:~> rpm -q postfix Sure, no problem. You may find them at http://gollum.phnxsoft.com/~ts/linux/main.cf http://gollum.phnxsoft.com/~ts/linux/strace.log HTH T. --=20 Tilman Schmidt E-Mail: tilman@imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge=F6ffnet mindestens haltbar bis: (siehe R=FCckseite)
Mar 17, 6:06 am 2008
Len Brown
Re: [2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot
For a Linux distro to ship DSDT override images, they'd have to have some licensing & support arrangement with the OEM who actually owns that BIOS code. While this wouldn't defy any laws of physics, it doesn't look compatible with current industry business practices. OEMs are more likely to simply ship a BIOS update ISO. -Len --
Mar 17, 10:59 am 2008
Jeff Garzik
Re: 2.6.25-rc5: Reported regressions from 2.6.24
Well, after going through several kernel versions (back to 2.6.19 so far), this machine continues to have reboot problems. I'm going to back-burner this, as it is looking more like a hardware or BIOS problem that cropped up recently. Jeff --
Mar 17, 12:20 pm 2008
Thomas Meyer
Re: 2.6.25-rc5: Reported regressions from 2.6.24
I still cannot *believe* this bug, but i just checked out the latest kernel and did a make distclean and a make (with mr. bunks patch applied) and there it is again: $ dmesg (cut) [ 464.852986] ohci1394: fw-host0: physical posted write error [ 464.852991] ohci1394: fw-host0: respTxComplete: dma prg stopped [ 464.852997] ohci1394: fw-host0: SelfID received outside of bus reset sequence [ 464.853002] ohci1394: fw-host0: Unhandled interrupt(s) 0xfc7cfe0c [ 464.896722] ohci1394: ...
Mar 17, 2:28 pm 2008
Jeff Garzik Mar 17, 5:09 am 2008
Takashi Iwai
Re: [PATCH] at73c213: Fix DMA size at the end of DMA buffer
At Mon, 17 Mar 2008 22:32:29 +0900 (JST), Done. thanks, Takashi --
Mar 17, 6:54 am 2008
Takashi Iwai
Re: [PATCH] at73c213: Fix DMA size at the end of DMA buffer
At Mon, 17 Mar 2008 22:00:27 +0900 (JST), Thanks for the patch. So, I should revert your last patch, right? It's already on ALSA tree... --
Mar 17, 6:21 am 2008
Atsushi Nemoto
Re: [PATCH] at73c213: Fix DMA size at the end of DMA buffer
Yes, please. Thank you. --- Atsushi Nemoto --
Mar 17, 6:32 am 2008
Atsushi Nemoto
Re: [PATCH] at73c213: Fix DMA size at the end of DMA buffer
Thank you! It works fine. Here is a new patch. ------------------------------------------------------ Subject: [PATCH] at73c213: Add constraints for periods value From: Atsushi Nemoto <anemo@mba.ocn.ne.jp> The interrupt handler always provide runtime->period_size data, so it works correctly only if buffer_size was a multiple of period_size. This patch fixes periodic click noise. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- This patch obsoletes a patch titled "at73c213: ...
Mar 17, 6:00 am 2008
Alan Cox Mar 17, 3:39 am 2008
Daniel Phillips
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
Great idea. Except that the disk array has millisecond level latency, So you could potentially connect to a _huge_ disk array and write deltas to it. The disk array would have to support roughly 3 Gbytes/second of write bandwidth to keep up with the Violin ramdisk. Doable, but you are now in the serious heavy iron zone. Personally, I like my nice simple design a lot more. Just mirror it, as many times as you need to satisfy your paranoia. Or how about go write your own? Daniel --
Mar 17, 1:16 am 2008
Daniel Phillips
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
You are twisting words. I may have said that replication provides a point-in-time copy of a volume, which is exactly what it does, no more, A big buffer cache does not provide a guarantee that the dirty cache data saved to disk when line power is lost. If you would like to add that feature to the Linux buffer cache, then please do it, or make whichever other contribution you wish to make. If you just want to explain to me one more time that Linux, batteries, whatever, cannot be relied on, ...
Mar 17, 1:25 am 2008
Willy Tarreau
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
You can do that with 3 10GE NICS, though in practise that's not easy. Willy --
Mar 17, 10:30 am 2008
david
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
by the way, the only way to get this much bandwideth between two machines is to directly connect PCI-e/16 card slots togeather. this is definantly not commodity hardware anymore (if it's even possible, PCI-e has some very short distance limitations) David Lang --
Mar 17, 10:23 am 2008
David Newall
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
You said that you could achieve a certain performance, and later you said that for reliability you could use mirroring and replication but you never said that would lead to a performance hit. In fact you don't seem to be able to offer performance AND robustness; for performance you can only offer that level of robustness attainable on a single system, which means I think even you agreed was really not up to snuff for But the filesystem does offer a minimum level of consistency, which ...
Mar 17, 11:56 am 2008
david
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
if you are depending on replication over the network you have just limited your throughput to your network speed and latency. on an enterprise level machine the network can frequently be significantly slower than the disk array that you are so frantic to avoid waiting for. David Lang --
Mar 16, 8:59 pm 2008
David Newall
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
I think you've just tried to obfuscate the truth. As you have described, replication does not provide full protection against data loss; it loses all changes since last cycle. Recall that it was you who introduced the word "replication", in the context of guaranteeing no loss of data. Then you ignored David's point about the relatively low speed of networks, remarking only that mirroring is real-time. Reading between your words makes clear that "mirroring and replication" does You've ...
Mar 17, 12:14 am 2008
david
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
your network will do less then 1 Gbit/sec, so to mirror in real-time (what you claim is trivial) you would need at least 24 network connections in parallel. that's a LOT harder to setup then a high performance disk array. David Lang --
Mar 17, 7:42 am 2008
Daniel Phillips
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
Not if it is mirrored and replicated. Also nice if crashes are very I say it does not crash often, to the point where I have not seen it crash once for any reason I did not create myself (I tend to wait for the occasional brown bag release to fade away before shifting development We do get quite a few reports of less mature systems like hald and usb causing problems, and not too long ago NFS client was very crash happy. I did see some of those myself two years ago, and fixed them. On the ...
Mar 16, 7:42 pm 2008
Ric Wheeler
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
Just a point of information, most of the mid-tier and above disk arrays can do replication/mirroring behind the scene (i.e., you write to one array and it takes care of replicating your write to one or more other arrays). This behind the scene replication can be over various types of connections - IP or fibre channel probably are the two most common paths. That will still leave you with the normal latency for a small write to an array which is (when you hit cache) order of 1-2 ...
Mar 17, 6:52 am 2008
David Newall
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
What about system crashes? They guarantee that data will be lost. I know opinions are divided on the subject of crashes: You say Linux doesn't; everybody else says it does. I side with experience. (It does.) --
Mar 16, 6:31 pm 2008
Alan Cox
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
> You did not explain how your proposal will avoid dropping the transaction Here is a simple but high physical storage using approach (but hey disks are cheap) You walk across the ram dirty table writing out chunks to backing store 0. At some point in time you want a consistent snapshot so you pick the next write barrier point after this time and begin committing blocks dirtied after that moment to store 1 (with blocks before that moment being written to both). You don't permit more than ...
Mar 17, 4:53 am 2008
Daniel Phillips
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
Replication does not work that way. On each replication cycle, the differences between the most recent two volume snapshots go over the network. This strategy has the nice effect of consolidating rewrites. There are also excellent delta compression opportunities. In the worst case, with insufficient bandwidth for the churn rate of the volume, replication rate increases to the time for replicating the full volume. Again, at worst, this would require extra storage for the snapshot to be ...
Mar 16, 10:52 pm 2008
david
Re: [ANNOUNCE] Ramback: faster than a speeding bullet
so just mirror to a local disk array then. a local disk array has more write bandwidth than a network connection to a remote machine, so if you can mirror to a remote machine you can mirror to if by traditionalists you mean everyone who makes a living keeping systems running you are right. we want sane failure modes as much as we want performance. there will be times when we decide to go for speed at the expense of safety, but we want to do it knowingly, not when someone is ...
Mar 16, 11:49 pm 2008
Volker Armin Hemmann
Re: 2.6.24.X: SATA/AHCI related boot delay. - not with 2 ...
Hi, I tried some more stuff, replaced the cables, played with bios settings. No change. Then I updated to 2.6.24.3 - and no hangs or 'softreset' failures anymore. [ 38.151334] ahci 0000:00:0a.0: AHCI 0001.0100 32 slots 4 ports 3 Gbps 0x= f=20 impl IDE mode [ 38.151386] ahci 0000:00:0a.0: flags: 64bit sntf led clo pmp pio [ 38.151425] PCI: Setting latency timer of device 0000:00:0a.0 to 64 [ 38.151626] scsi0 : ahci [ 38.151722] scsi1 : ahci [ 38.151788] scsi2 : ahci [ ...
Mar 17, 12:16 am 2008
Takashi Iwai
Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx brok ...
At Fri, 14 Mar 2008 21:18:19 -0400, I vaguely remember about the patch... The patch below was on my local tree but never pushed because of lack of testing. Does it work for Maybe the problem is in a different place, then... thanks, Takashi --- diff -r 82e6201fc907 sound/isa/es18xx.c --- a/sound/isa/es18xx.c Mon Mar 17 14:36:24 2008 +0100 +++ b/sound/isa/es18xx.c Mon Mar 17 17:32:59 2008 +0100 @@ -765,9 +765,10 @@ static irqreturn_t snd_es18xx_interrupt( /* Read Interrupt ...
Mar 17, 9:26 am 2008
Rene Herman Mar 17, 3:04 pm 2008
Rene Herman
Re: [alsa-devel] [regression] 2.6.25-rc4 snd-es18xx brok ...
Okay, thought I'd stare at this thing a bit -- there's no specific 1888 documentation available it seems but I did notice something in the 1878 datasheet which might mean something. The docs says that bits 0-1 are don't care for DMA but don't for IRQ, so could it possibly be as simple as the attached? 1878 sheet doesn't document register 0x7f, it seems... Assuming it's not just this, this thing is going to require quite a bit of trial and error and without the hardware this will be ...
Mar 17, 3:00 pm 2008
Alasdair G Kergon
Re: [dm-crypt] INFO: task mount:11202 blocked for more t ...
Latest version for everyone to try: From: Milan Broz <mbroz@redhat.com> Fix regression in dm-crypt introduced in commit 3a7f6c990ad04e6f576a159876c602d14d6f7fef (dm crypt: use async crypto). If write requests need to be split into pieces, the code must not process them in parallel because the crypto context cannot be shared. So there can be parallel crypto operations on one part of the write, but only one write bio can be processed at a time. This is not optimal and the workqueue code ...
Mar 17, 10:36 am 2008
Chr
Re: [dm-crypt] INFO: task mount:11202 blocked for more t ...
Tested-by: Christian Lamparter <chunkeey@web.de> Well, the dm-crypt regressions seems to be gone. :) Thanks for your work & time! Regards, Christian --
Mar 17, 11:36 am 2008
Dan Williams
Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient ...
Hi Olof, Looks good, makes me want to go back and cleanup iop-adma a bit. A Ok, it still may not compile in mainline until after 2.6.26-rc1 due to additional dmaengine cleanups like the ack-to-flags change I posted Clients do not submit new operations in their callback routines so it is "ok" to hold this lock over the callback. Also, if your platform will need to support channel switching at some point you can go ahead and add a call to async_tx_run_dependencies() here. --
Mar 17, 11:46 am 2008
Nelson, Shannon
RE: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient ...
Hi Olof, In the future please copy Maciej as one of "the DMA guys" as he has taken over ioatdma for me. Beyond that, one little picky comment Is the number of channels defaulting to 2 or 4? sln --
Mar 17, 1:34 pm 2008
Russell King - ARM Linux
Re: [PATCH] fix signal return code when enable CONFIG_OA ...
Having thought about this, yes, this fix will do. Please submit to the --
Mar 17, 11:39 am 2008
Jeremy Fitzhardinge
Re: [BUG] Linux-2.6.25-rc4 (and also in rc3) Compile Error
What's the command you're using to build? What happens if you build the kernel normally? J --
Mar 17, 7:18 am 2008
Tarkan Erimer
Re: [BUG] Linux-2.6.25-rc4 (and also in rc3) Compile Error
I tried the recently released .rc6 and still the problem is there. I got the same error message which is : echo done > stamp-debian echo done > debian/stamp-conf ====== making target CONFIG-common [new prereqs: stamp-conf]====== This is kernel package version 11.001. ====== making target stamp-arch-conf [new prereqs: CONFIG-common]====== ====== making target CONFIG-arch [new prereqs: stamp-arch-conf]====== ====== making target conf.vars [new prereqs: Makefile ...
Mar 17, 1:56 am 2008
Nick Piggin
Re: Are Linux pipes slower than the FreeBSD ones ?
Seems some people are still concerned about this benchmark. OK I tried with Linux 2.6.25-rc6 (just because it's what I've got on this system). Versus FreeBSD 7.0. Unfortunately, I don't think FreeBSD supports binding a process to a CPU, and on either system when the scheduler is allowed to choose what happens, results are more variable than you would like. That being said, I found that Linux often outscored FreeBSD in all 3 tests of pipe_v3. FreeBSD does appear like it can get a slightly ...
Mar 17, 5:53 am 2008
Linus Torvalds
Re: Linux 2.6.25-rc4
Do you get into ide_error() too? That 176 is WIN_SMART, but you had earlier WIN_SMART commands that worked ok, so it's something specific that triggers it. data_phase = 1 is TASKFILE_IN. So try to see if you get to ide_error(), which is where Bartlomiejs latest patch was in effect - but add a few printk's there to print out the 'stat' variable etc to see if it actually triggers. And maybe a WARN_ON(1) to get the trace.. Linus --
Mar 17, 3:52 pm 2008
Jens Axboe
Re: Linux 2.6.25-rc4
The bisect ends up pointing at IDE bits everytime, plus it's io There's no data to back any such conclusion up, that would be extremely hand wavy (at best). Ingo hit a hang in one boot out of hundreds to thousands. Anders can reproduce easily, should be easy enough to narrow down. -- Jens Axboe --
Mar 17, 12:23 am 2008
Anders Eriksson
Re: Linux 2.6.25-rc4
Tossing a prink in like so: ide_startstop_t do_rw_taskfile (ide_drive_t *drive, ide_task_t *task) { ide_hwif_t *hwif = HWIF(drive); struct ide_taskfile *tf = &task->tf; ide_handler_t *handler = NULL; printk("do_rw_taskfile(task->data_phase=%i, tf->command=%i\n",task->data_phase,tf->command); if (task->data_phase == TASKFILE_MULTI_IN || Yields: Mar 17 21:57:29 tippex smartd[5810]: smartd version 5.37 [i686-pc-linux-gnu] Copyright (C) ...
Mar 17, 2:09 pm 2008
David Brownell
Re: ehci-hcd affects hda speed
Blame VIA for that one. Notice how their descriptions of the fields in that register don't even mention a MAC. :) But the relevant bit is the "sleep time" and that's described in the EHCI specification. It basically means how long it waits, after noticing a "no work for me" async schedule ring, before scanning that schedule again. It seems your system had that set to just 1 usec, meaning it would hardly give anything else a chance to get onto the PCI bus. That's probably why the ...
Mar 17, 2:06 pm 2008
Alessandro Suardi
Re: ehci-hcd affects hda speed
On Sat, Mar 15, 2008 at 11:46 PM, Lev A. Melnikovsky 00:09.2 USB Controller: VIA Technologies, Inc. USB 2.0 (rev 63) heh, I don't even have to... [root@donkey ~]# hdparm -t /dev/hda /dev/hda: Timing buffered disk reads: 54 MB in 3.03 seconds = 17.83 MB/sec [root@donkey ~]# setpci -s 00:09.2 4b.b=29 [root@donkey ~]# hdparm -t /dev/hda /dev/hda: Timing buffered disk reads: 78 MB in 3.06 seconds = 25.53 MB/sec Well, that does look much better. Not on par with the non-EHCI ...
Mar 17, 9:15 am 2008
Atsushi Tsuji
Re: [RFC,PATCH 2/2] kill_pid_info: don't take now unneed ...
Hi Oleg, I tried your patches on vanila kernel 2.6.25-rc3 (ia64). Then, I got the NULL pointer dereference at task_session_nr(t) in check_kill_permission(). That is why t->signal->__session is accessed after t->signal was released. It is reproducible by sending many SIGCONT signals to exiting processes. The trace is as follows: Pid: 7807, CPU 9, comm: kill_sigcont psr : 00001210085a6010 ifs : 800000000000030a ip : [<a0000001000ab441>] Not tainted (2.6.25-rc3-debug) ip ...
Mar 17, 4:30 am 2008
Oleg Nesterov
Re: [RFC,PATCH 2/2] kill_pid_info: don't take now unneed ...
Ah. Indeed!!! Thanks a lot Atsushi. Note that check_kill_permission() is the last user of the deprecated signal->__session/session, I was going to change this code later, but missed the issue you pointed out. I'll make the patch tomorrow. Thanks! Oleg. --
Mar 17, 10:01 am 2008
David Brownell
Re: [linux-pm] Too many timer interrupts in NO_HZ
... you're not accessing EHCI devices at all. Is HAL or something else polling them too often? Or are you maybe That watchdog is a bit messy, but it's got two basic tasks: (a) Take work off the async ring ... bulk and control transfers will leave an empty QH there for a few milliseconds before taking it off, to avoid wasting effort in the common case where another transfer quickly follows the first one. In the extreme case, when there's no more work, that ring ...
Mar 17, 1:44 am 2008
Alan Stern
Re: [linux-pm] Too many timer interrupts in NO_HZ
The largest entry is for ehci_watchdog. This timer won't run at all if your EHCI controllers are allowed to autosuspend, which will happen automatically if (1) You enable CONFIG_USB_SUSPEND, and (2) You have no high-speed USB devices attached, or the ones that are attached have all been suspended. On the other hand, if you were actively using some high-speed USB device during the test then it's understandable that there should be lots of timer interrupts as a result. Alan ...
Mar 16, 7:34 pm 2008
Avi Kivity
Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
I'm okay with switching away from the file-based refcounts to a refcount embedded in the kvm structures, though I'm not particularly thrilled by it. Any reason not to use krefs for this? -- error compiling committee.c: too many arguments to function --
Mar 17, 3:48 am 2008
Christoph Hellwig
Re: [PATCH/RFC 1/2] anon-inodes: Remove fd_install() fro ...
Indeed. Any comments from the kvm developers in this approach? The current multi-level file refcounting seems rather bogus so I'd like to make some progress on this. --
Mar 17, 3:40 am 2008
nickcheng
RE: Aborted commands with arcmsr and 2xWD1500ADFD in RAID1
Hi Aron, We have two WDWD1500ADFD and a MSI motherboard which is not exactly the same as what you have. I have tested your case two weeks ago, and do it with copy-compare test program but I find nothing as you describe. Could you give me your experimental directory to let me try again?? BTW, what is your FW version? The latest FW version is v1.44. Please check it out, -----Original Message----- From: Aron Stansvik [mailto:elvstone@gmail.com] Sent: Saturday, March 15, 2008 1:26 AM To: ...
Mar 16, 6:56 pm 2008
Chris Wright
Re: [stable] 2.6.24.3 broke "make headers_install".
Yup, fix is queued up. thanks, -chris --
Mar 16, 9:04 pm 2008
Christoph Hellwig
Re: 2.6.25-rc1/2 regression: first-time login into gnome fails
Just upgraded my laptop to 2.6.25-rc6 and I see the same. A little instrumentation shows that there is no socket to connect to aka the server side process (whatever that is) didn't start. --
Mar 17, 5:06 am 2008
Ray Lee
Re: 2.6.25-rc1/2 regression: first-time login into gnome fails
Hmm. Okay, mind if I ask some stupid questions? I'm assuming you upgraded from 2.6.24, correct? (not .25-rcX). Are you running either debian or ubuntu? If so, do you have the dbus-x11 package installed? Alternately, does /usr/bin/dbus-launch exist? If no, try installing dbus-x11 and try again. I think a side-effect of installing is to start dbus earlier, and may perhaps avoid the race (if it is a race that's causing all this, which I still think it is). References if you're bored: ...
Mar 17, 8:47 am 2008
Bongani Hlope
Re: 2.6.25-rc[12] Video4Linux Bttv Regression
More info... The Oops seems to be caused by a size mismatch that causes memset to write over other variables in the stack... The following debug hack moved oops to another point in the v4l1-compact code.. So memset(&tun2,0,sizeof(tun2)) seems to be overwriting btv->lock->wait_list: --- drivers/media/video/v4l1-compat.c~ 2007-11-13 10:25:52.000000000 +0200 +++ drivers/media/video/v4l1-compat.c 2008-03-17 23:17:38.000000000 +0200 @@ -688,7 +688,7 @@ { struct ...
Mar 17, 2:51 pm 2008
Jan Kasprzak
Re: Regression: kernel 2.6.24{,.1} ahci problem, does no ...
I have the same problem (ASUS M2R32-MVP board with SB600 chipset, Athlon64 X2), but I am already using the latest BIOS for this mainboard. 2.6.22.19 works 2.6.24.3 does not work 2.6.25-rc6 does not work I can try to bisect it (maybe tomorrow). I use AHCI mode, maybe I should try the legacy mode as well. -Yenya -- | Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> | | GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E | --
Mar 17, 2:00 pm 2008
Richard Purdie
Re: LED naming standard for LED class
It is not an new ABI, its an extension as per the way it was documented The problem is the "bad" ABI has existed in that form since somewhere around 2.6.15 and it is therefore too late to drop things from it or rearrange it. The ABI described additions being allowed so we're taking advantage of that to gain something which should have really been there originally. Short term there is some complexity with some limits but they're going away so there is no problem. The whole point of the ...
Mar 17, 2:51 am 2008
Henrique de Moraes H ...
LED naming standard for LED class
(changing the subject. Newcomers, the context is given by commit 6c152beefbf90579d21afc4f7e075b1f801f9a75). Ok, I looked at it from various angles, and did some heavy thinking about it. Richard, isn't there *any* way to change this new ABI? It has not been in any stable mainline release yet, so it is not too late if we do it now. Even if the lenght limit for sysfs entries (19 chars + NULL) is lifted in 2.6.26, the current proposal that would become stable in 2.6.25 is still ugly, and ...
Mar 16, 8:34 pm 2008
Tobias Diedrich
Re: dst cache overflow
Hi all, just a reminder, the server is now running 2.6.24 and the leak is still there. I noticed there is a slab leak debug option and turned it on, results should be visible in a few days I guess. Offenders: Slabs TCPv6, size_2048 and size_512 grow over time. I also noticed that the machine stops responding to pings after some time, which seems to coincide with a slight increase in leak speed. Interstingly IPv4 pings give out first, IPv6 pings continue to work a bit longer, but ...
Mar 16, 6:25 pm 2008
Andrey Borzenkov
Re: [possible regression] 2.6.22 reiserfs/libata sporadi ...
As Alan pointed, the patch is likely to cause other issues; also I had the issue with libata as well :(
Mar 16, 9:00 pm 2008
previous daytodaynext day
March 16, 2008March 17, 2008March 18, 2008