login
Header Space

 
 

[PATCH 08 of 31] x86: move pgalloc pud and pgd operations into common place

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: LKML <linux-kernel@...>, Ian Campbell <ijc@...>
Date: Monday, March 17, 2008 - 7:36 pm

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
---
 arch/x86/mm/init_64.c        |    5 ----
 arch/x86/mm/pgtable.c        |    7 +++++
 include/asm-x86/pgalloc.h    |   52 +++++++++++++++++++++++++++++++++++++-----
 include/asm-x86/pgalloc_32.h |   24 -------------------
 include/asm-x86/pgalloc_64.h |   29 -----------------------
 5 files changed, 53 insertions(+), 64 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -847,8 +847,3 @@
 	return 0;
 }
 #endif
-
-void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud)
-{
-	tlb_remove_page(tlb, virt_to_page(pud));
-}
diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
--- a/arch/x86/mm/pgtable.c
+++ b/arch/x86/mm/pgtable.c
@@ -34,6 +34,13 @@
 	paravirt_release_pd(__pa(pmd) >> PAGE_SHIFT);
 	tlb_remove_page(tlb, virt_to_page(pmd));
 }
+
+#if PAGETABLE_LEVELS > 3
+void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud)
+{
+	tlb_remove_page(tlb, virt_to_page(pud));
+}
+#endif	/* PAGETABLE_LEVELS > 3 */
 #endif	/* PAGETABLE_LEVELS > 2 */
 
 #ifdef CONFIG_X86_64
diff --git a/include/asm-x86/pgalloc.h b/include/asm-x86/pgalloc.h
--- a/include/asm-x86/pgalloc.h
+++ b/include/asm-x86/pgalloc.h
@@ -71,12 +71,52 @@
 }
 
 extern void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd);
+
+#ifdef CONFIG_X86_PAE
+static inline void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd)
+{
+	paravirt_alloc_pd(mm, __pa(pmd) >> PAGE_SHIFT);
+
+	/* Note: almost everything apart from _PAGE_PRESENT is
+	   reserved at the pmd (PDPT) level. */
+	set_pud(pudp, __pud(__pa(pmd) | _PAGE_PRESENT));
+
+	/*
+	 * According to Intel App note "TLBs, Paging-Structure Caches,
+	 * and Their Invalidation", April 2007, document 317080-001,
+	 * section 8.1: in PAE mode we explicitly have to flush the
+	 * TLB via cr3 if the top-level pgd is changed...
+	 */
+	if (mm == current->active_mm)
+		write_cr3(read_cr3());
+}
+#else	/* !CONFIG_X86_PAE */
+static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd)
+{
+	paravirt_alloc_pd(mm, __pa(pmd) >> PAGE_SHIFT);
+	set_pud(pud, __pud(_PAGE_TABLE | __pa(pmd)));
+}
+#endif	/* CONFIG_X86_PAE */
+
+#if PAGETABLE_LEVELS > 3
+static inline void pgd_populate(struct mm_struct *mm, pgd_t *pgd, pud_t *pud)
+{
+	set_pgd(pgd, __pgd(_PAGE_TABLE | __pa(pud)));
+}
+
+static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr)
+{
+	return (pud_t *)get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
+}
+
+static inline void pud_free(struct mm_struct *mm, pud_t *pud)
+{
+	BUG_ON((unsigned long)pud & (PAGE_SIZE-1));
+	free_page((unsigned long)pud);
+}
+
+extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
+#endif	/* PAGETABLE_LEVELS > 3 */
 #endif	/* PAGETABLE_LEVELS > 2 */
 
-#ifdef CONFIG_X86_32
-# include "pgalloc_32.h"
-#else
-# include "pgalloc_64.h"
-#endif
-
 #endif	/* _ASM_X86_PGALLOC_H */
diff --git a/include/asm-x86/pgalloc_32.h b/include/asm-x86/pgalloc_32.h
deleted file mode 100644
--- a/include/asm-x86/pgalloc_32.h
+++ /dev/null
@@ -1,24 +0,0 @@
-#ifndef _I386_PGALLOC_H
-#define _I386_PGALLOC_H
-
-#ifdef CONFIG_X86_PAE
-static inline void pud_populate(struct mm_struct *mm, pud_t *pudp, pmd_t *pmd)
-{
-	paravirt_alloc_pd(mm, __pa(pmd) >> PAGE_SHIFT);
-
-	/* Note: almost everything apart from _PAGE_PRESENT is
-	   reserved at the pmd (PDPT) level. */
-	set_pud(pudp, __pud(__pa(pmd) | _PAGE_PRESENT));
-
-	/*
-	 * According to Intel App note "TLBs, Paging-Structure Caches,
-	 * and Their Invalidation", April 2007, document 317080-001,
-	 * section 8.1: in PAE mode we explicitly have to flush the
-	 * TLB via cr3 if the top-level pgd is changed...
-	 */
-	if (mm == current->active_mm)
-		write_cr3(read_cr3());
-}
-#endif	/* CONFIG_X86_PAE */
-
-#endif /* _I386_PGALLOC_H */
diff --git a/include/asm-x86/pgalloc_64.h b/include/asm-x86/pgalloc_64.h
deleted file mode 100644
--- a/include/asm-x86/pgalloc_64.h
+++ /dev/null
@@ -1,29 +0,0 @@
-#ifndef _X86_64_PGALLOC_H
-#define _X86_64_PGALLOC_H
-
-#include <asm/pda.h>
-
-static inline void pud_populate(struct mm_struct *mm, pud_t *pud, pmd_t *pmd)
-{
-	set_pud(pud, __pud(_PAGE_TABLE | __pa(pmd)));
-}
-
-static inline void pgd_populate(struct mm_struct *mm, pgd_t *pgd, pud_t *pud)
-{
-	set_pgd(pgd, __pgd(_PAGE_TABLE | __pa(pud)));
-}
-
-static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr)
-{
-	return (pud_t *)get_zeroed_page(GFP_KERNEL|__GFP_REPEAT);
-}
-
-static inline void pud_free(struct mm_struct *mm, pud_t *pud)
-{
-	BUG_ON((unsigned long)pud & (PAGE_SIZE-1));
-	free_page((unsigned long)pud);
-}
-
-extern void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud);
-
-#endif /* _X86_64_PGALLOC_H */


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 13 of 31] x86/pgtable.h: demacro ptep_test_and_clear_..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 03 of 31] x86: convert pgalloc_64.h from macros to in..., Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 20 of 31] xen: unify pte operations on machine frames, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 01 of 31] xen: fix RMW when unmasking events, Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 31 of 31] xen: jump to iret fixup, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 05 of 31] x86: put paravirt stubs into common asm/pga..., Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 24 of 31] xen: add support for callbackops hypercall, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 28 of 31] xen: make sure retriggered events are set p..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 18 of 31] xen: unify pte operations, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 25 of 31] x86: only enable interrupts when kernel sta..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 09 of 31] x86: move all the pgd_list handling to one ..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 29 of 31] xen: short-cut for recursive event handling, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 22 of 31] x86: unify KERNEL_PGD_PTRS, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 10 of 31] x86: rename paravirt_alloc_pt etc after the..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 19 of 31] xen: use phys_addr_t when referring to phys..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 02 of 31] xen: fix UP setup of shared_info, Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 27 of 31] xen: implement a debug-interrupt handler, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 17 of 31] xen: make use of pte_t union, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 06 of 31] x86: move pte functions into common asm/pga..., Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 23 of 31] x86: unify pgd ctor/dtor, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 12 of 31] x86/pgtable.h: demacro ptep_set_access_flags, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 21 of 31] xen: make sure iret faults are trapped, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 14 of 31] x86/pgtable.h: demacro ptep_clear_flush_young, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 15 of 31] x86: demacro pgalloc paravirt stubs, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 04 of 31] x86: add common mm/pgtable.c, Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
[PATCH 08 of 31] x86: move pgalloc pud and pgd operations in..., Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 3:05 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 3:46 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 4:02 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 4:09 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 5:12 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 5:33 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 5:54 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 6:00 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 5:58 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 6:04 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 6:15 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 7:52 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Thu Mar 20, 4:24 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Fri Mar 21, 9:17 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Fri Mar 21, 10:35 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Fri Mar 21, 11:15 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Fri Mar 21, 11:25 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Fri Mar 21, 10:34 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ian Campbell, (Wed Mar 19, 5:22 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 11:11 am)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ingo Molnar, (Wed Mar 19, 3:07 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 3:19 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Ian Campbell, (Wed Mar 19, 12:50 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Wed Mar 19, 2:45 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Zachary Amsden, (Tue Mar 18, 5:33 pm)
Re: [PATCH 00 of 31] x86: unification and xen updates, Jeremy Fitzhardinge, (Tue Mar 18, 5:37 pm)
[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 26 of 31] xen: support sysenter/sysexit if hypervisor..., Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 11 of 31] x86: add pud_alloc for 4-level pagetables, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 16 of 31] xen: use appropriate pte types, Jeremy Fitzhardinge, (Mon Mar 17, 7:37 pm)
[PATCH 07 of 31] x86: move pmd functions into common asm/pga..., Jeremy Fitzhardinge, (Mon Mar 17, 7:36 pm)
speck-geostationary