Home » Mailing list archives » linux-kernel » 2008 » March » 17

[PATCH] drivers/net/wireless/atmel.c: Use time_* macros

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: S.Çağlar Onur
Subject: [PATCH] drivers/net/wireless/atmel.c: Use time_* macros
Date: Monday, March 17, 2008 - 2:36 am

The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values.

So following patch implements usage of the time_after() macro, defined at linux/jiffies.h, which deals with wrapping correctly

Cc: linux-wireless@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>
---
 drivers/net/wireless/atmel.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/atmel.c b/drivers/net/wireless/atmel.c
index 63ec7a7..ef2da40 100644
--- a/drivers/net/wireless/atmel.c
+++ b/drivers/net/wireless/atmel.c
@@ -66,6 +66,7 @@
 #include <linux/device.h>
 #include <linux/moduleparam.h>
 #include <linux/firmware.h>
+#include <linux/jiffies.h>
 #include <net/ieee80211.h>
 #include "atmel.h"
 
@@ -516,7 +517,7 @@ struct atmel_private {
 		SITE_SURVEY_IN_PROGRESS,
 		SITE_SURVEY_COMPLETED
 	} site_survey_state;
-	time_t last_survey;
+	unsigned long last_survey;
 
 	int station_was_associated, station_is_associated;
 	int fast_scan;
@@ -2283,7 +2284,7 @@ static int atmel_set_scan(struct net_device *dev,
 		return -EAGAIN;
 
 	/* Timeout old surveys. */
-	if ((jiffies - priv->last_survey) > (20 * HZ))
+	if (time_after(jiffies, priv->last_survey + 20 * HZ))
 		priv->site_survey_state = SITE_SURVEY_IDLE;
 	priv->last_survey = jiffies;
 
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] arch/alpha/kernel/traps.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] arch/ia64/kernel/: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] arch/parisc/kernel/unaligned.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] arch/powerpc/platforms/iseries/pci.c: Use time_* m ..., S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] drivers/net/arcnet/arcnet.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] drivers/net/ax88796.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] net/mac80211/: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] drivers/net/tokenring/3c359.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] drivers/net/wireless/atmel.c: Use time_* macros, S.Çağlar Onur, (Mon Mar 17, 2:36 am)
[PATCH] fs/binfmt_aout.c: Use printk_ratelimit(), S.Çağlar Onur, (Mon Mar 17, 2:36 am)
Re: [PATCH] arch/ia64/kernel/: Use time_* macros, KOSAKI Motohiro, (Mon Mar 17, 2:59 am)
Re: [PATCH] arch/parisc/kernel/unaligned.c: Use time_* macros, Kyle McMartin, (Mon Mar 17, 8:40 am)
Re: [PATCH] arch/powerpc/platforms/iseries/pci.c: Use time ..., Stephen Rothwell, (Mon Mar 17, 4:31 pm)
Re: [PATCH] net/mac80211/: Use time_* macros, John W. Linville, (Tue Mar 25, 11:32 am)