Home » Mailing list archives » linux-kernel » 2008 » March » 17

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator
Date: Monday, March 17, 2008 - 12:41 am

> when node_boot_start is 512M alignment, and align is 1024M, offset

It's possible that there are better fixes for this, but at least
my simple patch seems to work here. I admit I was banging my
head against this for some time and when I did the fix I just
wanted the bug to go away and didn't really go for subtleness.

The bootmem allocator is quite spaghetti in fact, it could
really need some general clean up (although it's' not quite
as bad yet as page_alloc.c)

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [1/18] Convert hugeltlb.c over to pass global stat ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [2/18] Add basic support for more than one hstate ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [3/18] Convert /proc output code over to report mu ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [4/18] Add basic support for more than one hstate ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [5/18] Expand the hugetlbfs sysctls to handle arra ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [6/18] Add support to have individual hstates for ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [7/18] Abstract out the NUMA node round robin code ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [8/18] Add a __alloc_bootmem_node_nopanic, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [9/18] Export prep_compound_page to the hugetlb al ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [10/18] Factor out new huge page preparation code ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [12/18] Add support to allocate hugetlb pages that ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [13/18] Add support to allocate hugepages of diffe ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [14/18] Clean up hugetlb boot time printk, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [15/18] Add support to x86-64 to allocate and look ..., Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [16/18] Add huge pud support to hugetlbfs, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [17/18] Add huge pud support to mm/memory.c, Andi Kleen, (Sun Mar 16, 6:58 pm)
[PATCH] [18/18] Implement hugepagesz= option for x86-64, Andi Kleen, (Sun Mar 16, 6:58 pm)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Sun Mar 16, 7:19 pm)
Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Sun Mar 16, 8:11 pm)
Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Sun Mar 16, 10:35 pm)
Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Sun Mar 16, 11:58 pm)
Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Mon Mar 17, 12:00 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 12:00 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 12:02 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 12:17 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 12:29 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 12:31 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 12:41 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 12:53 am)
Re: [PATCH] [4/18] Add basic support for more than one hst ..., Paul Jackson, (Mon Mar 17, 1:09 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 1:10 am)
Re: [PATCH] [4/18] Add basic support for more than one hst ..., Andi Kleen, (Mon Mar 17, 1:15 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 1:17 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 1:56 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Mon Mar 17, 2:26 am)
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Paul Jackson, (Mon Mar 17, 2:29 am)
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Andi Kleen, (Mon Mar 17, 2:59 am)
Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Paul Jackson, (Mon Mar 17, 3:02 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Adam Litke, (Mon Mar 17, 8:05 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 8:33 am)
Re: [PATCH] [0/18] GB pages hugetlb support, Adam Litke, (Mon Mar 17, 8:59 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 11:52 am)
Re: [PATCH] [1/18] Convert hugeltlb.c over to pass global ..., Adam Litke, (Mon Mar 17, 1:15 pm)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., Adam Litke, (Mon Mar 17, 1:22 pm)
Re: [PATCH] [4/18] Add basic support for more than one hst ..., Adam Litke, (Mon Mar 17, 1:28 pm)
Re: [PATCH] [10/18] Factor out new huge page preparation c ..., Adam Litke, (Mon Mar 17, 1:31 pm)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., Andi Kleen, (Mon Mar 17, 1:44 pm)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 2:27 pm)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 7:06 pm)
Re: [PATCH] [1/18] Convert hugeltlb.c over to pass global ..., Mel Gorman, (Tue Mar 18, 5:05 am)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., Mel Gorman, (Tue Mar 18, 5:23 am)
Re: [PATCH] [3/18] Convert /proc output code over to repor ..., Mel Gorman, (Tue Mar 18, 5:28 am)
Re: [PATCH] [6/18] Add support to have individual hstates ..., Adam Litke, (Tue Mar 18, 7:10 am)
Re: [PATCH] [4/18] Add basic support for more than one hst ..., Mel Gorman, (Tue Mar 18, 7:11 am)
Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ..., Mel Gorman, (Tue Mar 18, 7:34 am)
Re: [PATCH] [6/18] Add support to have individual hstates ..., Mel Gorman, (Tue Mar 18, 8:02 am)
Re: [PATCH] [7/18] Abstract out the NUMA node round robin ..., Mel Gorman, (Tue Mar 18, 8:42 am)
Re: [PATCH] [7/18] Abstract out the NUMA node round robin ..., Andi Kleen, (Tue Mar 18, 8:47 am)
Re: [PATCH] [8/18] Add a __alloc_bootmem_node_nopanic, Mel Gorman, (Tue Mar 18, 8:54 am)
Re: [PATCH] [10/18] Factor out new huge page preparation c ..., Mel Gorman, (Tue Mar 18, 9:02 am)
Re: [PATCH] [7/18] Abstract out the NUMA node round robin ..., Mel Gorman, (Tue Mar 18, 9:04 am)
Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Mel Gorman, (Tue Mar 18, 9:18 am)
Re: [PATCH] [12/18] Add support to allocate hugetlb pages ..., Mel Gorman, (Tue Mar 18, 9:27 am)
Re: [PATCH] [13/18] Add support to allocate hugepages of d ..., Mel Gorman, (Tue Mar 18, 9:32 am)
Re: [PATCH] [14/18] Clean up hugetlb boot time printk, Mel Gorman, (Tue Mar 18, 9:37 am)
Re: [PATCH] [13/18] Add support to allocate hugepages of d ..., Andi Kleen, (Tue Mar 18, 9:45 am)
Re: [PATCH] [13/18] Add support to allocate hugepages of d ..., Mel Gorman, (Tue Mar 18, 9:46 am)
Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ..., Andi Kleen, (Tue Mar 18, 9:49 am)
Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ..., Mel Gorman, (Tue Mar 18, 10:01 am)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., KOSAKI Motohiro, (Sun Mar 23, 3:38 am)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., Andi Kleen, (Sun Mar 23, 4:28 am)
Re: [PATCH] [2/18] Add basic support for more than one hst ..., KOSAKI Motohiro, (Sun Mar 23, 4:30 am)
Re: [PATCH] [12/18] Add support to allocate hugetlb pages ..., Andrew Hastings, (Wed Apr 9, 9:05 am)
Re: [PATCH] [12/18] Add support to allocate hugetlb pages ..., Andi Kleen, (Wed Apr 9, 10:56 am)