Home » Mailing list archives » linux-kernel » 2008 » March » 16

[PATCH] i810fb: Fix console switch regression

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stefan Bauer <stefan.bauer@...>
To: <linux-fbdev-devel@...>, <linux-kernel@...>, Antonino Daplas <adaplas@...>
Subject: [PATCH] i810fb: Fix console switch regression
Date: Sunday, March 16, 2008 - 2:42 pm

From: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>

Commit eaa0ff15c30dc9799eb4d12660edb73aeb6d32c5 ("fix ! versus & precedence in 
various places") introduced a regression in console switching when using 
i810fb. Every 5th to 10th console switch causes 'pixel waste' - the same line 
of multi-colored pixels repeated over the whole screen.
This reverts eaa0ff1 for i810_main.c.

Signed-off-by: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>
Cc: Antonino Daplas <adaplas@pol.net>

---
As I'm not subscribed to the LKML, please CC me, thanks.

--- linux-2.6/drivers/video/i810/i810_main.c.orig
+++ linux-2.6/drivers/video/i810/i810_main.c
@@ -1476,7 +1476,7 @@ static int i810fb_cursor(struct fb_info 
	struct i810fb_par *par = info->par;
	u8 __iomem *mmio = par->mmio_start_virtual;

-	if (!(par->dev_flags & LOCKUP))
+	if (!par->dev_flags & LOCKUP)
		return -ENXIO;

	if (cursor->image.width > 64 || cursor->image.height > 64)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Sun Mar 16, 2:42 pm)
Re: [PATCH] i810fb: Fix console switch regression, Henrique de Moraes Holschuh..., (Sun Mar 16, 3:57 pm)
Re: [PATCH] i810fb: Fix console switch regression, Henrique de Moraes Holschuh..., (Sun Mar 16, 4:02 pm)
Re: [Linux-fbdev-devel] [PATCH] i810fb: Fix console switch r..., Geert Uytterhoeven, (Sun Mar 16, 3:48 pm)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Mon Mar 17, 4:20 am)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Mon Mar 17, 11:41 am)
Re: [PATCH] i810fb: Fix console switch regression, Andrew Morton, (Mon Mar 17, 11:48 pm)
Re: [PATCH] i810fb: Fix console switch regression, Stefan Bauer, (Tue Mar 18, 3:09 am)