login
Header Space

 
 

Re: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable

Previous thread: [PATCH 6/7] drivers/net/ipg.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:04 pm. (2 messages)

Next thread: YOUR ATM CARD IS READY!!!!!!!! by mrs linda Hill on Saturday, March 15, 2008 - 11:20 am. (1 message)
To: <jcliburn@...>, <csnook@...>, <atl1-devel@...>, <jgarzik@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 12:05 pm

From: Julia Lawall &lt;julia@diku.dk&gt;

The variable update_rx is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
---
 drivers/net/atl1/atl1_main.c |    3 ---
 1 file changed, 3 deletions(-)

diff -u -p a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
--- a/drivers/net/atl1/atl1_main.c	2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/atl1/atl1_main.c	2008-03-15 16:18:08.000000000 +0100
@@ -1765,15 +1765,12 @@ static irqreturn_t atl1_intr(int irq, vo
 {
 	struct atl1_adapter *adapter = netdev_priv(data);
 	u32 status;
-	u8 update_rx;
 	int max_ints = 10;
 
 	status = adapter-&gt;cmb.cmb-&gt;int_stats;
 	if (!status)
 		return IRQ_NONE;
 
-	update_rx = 0;
-
 	do {
 		/* clear CMB interrupt status at once */
 		adapter-&gt;cmb.cmb-&gt;int_stats = 0;
--
To: Julia Lawall <julia@...>
Cc: <jcliburn@...>, <csnook@...>, <atl1-devel@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Monday, March 17, 2008 - 7:58 am

applied


--
To: Julia Lawall <julia@...>
Cc: <csnook@...>, <atl1-devel@...>, <jgarzik@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 6:16 pm

On Sat, 15 Mar 2008 17:05:02 +0100 (CET)

--
Previous thread: [PATCH 6/7] drivers/net/ipg.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:04 pm. (2 messages)

Next thread: YOUR ATM CARD IS READY!!!!!!!! by mrs linda Hill on Saturday, March 15, 2008 - 11:20 am. (1 message)
speck-geostationary