login
Header Space

 
 

Re: [PATCH 1/7] drivers/net/wireless/b43/lo.c: remove unused variable

Previous thread: TCP stack optimization for high number of connections [OT] by Marc Perkel on Saturday, March 15, 2008 - 11:47 am. (2 messages)

Next thread: [PATCH 2/7] net/9p/trans_fd.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:02 pm. (2 messages)
To: <linux-wireless@...>, <linville@...>, <jgarzik@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 12:02 pm

From: Julia Lawall &lt;julia@diku.dk&gt;

The variable trsw_rx is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
---
 drivers/net/wireless/b43/lo.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff -u -p a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
--- a/drivers/net/wireless/b43/lo.c	2008-03-12 14:13:14.000000000 +0100
+++ b/drivers/net/wireless/b43/lo.c	2008-03-15 15:56:58.000000000 +0100
@@ -493,15 +493,12 @@ static void lo_measure_gain_values(struc
 		max_rx_gain = 0;
 
 	if (has_loopback_gain(phy)) {
-		int trsw_rx = 0;
 		int trsw_rx_gain;
 
 		if (use_trsw_rx) {
 			trsw_rx_gain = phy-&gt;trsw_rx_gain / 2;
-			if (max_rx_gain &gt;= trsw_rx_gain) {
+			if (max_rx_gain &gt;= trsw_rx_gain)
 				trsw_rx_gain = max_rx_gain - trsw_rx_gain;
-				trsw_rx = 0x20;
-			}
 		} else
 			trsw_rx_gain = max_rx_gain;
 		if (trsw_rx_gain &lt; 9) {
--
To: Julia Lawall <julia@...>
Cc: <linux-wireless@...>, <linville@...>, <jgarzik@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 12:40 pm

You get a NACK for now. Most likely this is a bug and the variable


-- 
Greetings Michael.
--
Previous thread: TCP stack optimization for high number of connections [OT] by Marc Perkel on Saturday, March 15, 2008 - 11:47 am. (2 messages)

Next thread: [PATCH 2/7] net/9p/trans_fd.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:02 pm. (2 messages)
speck-geostationary