login
Header Space

 
 

[PATCH 6/7] drivers/net/ipg.c: remove unused variable

Previous thread: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:04 pm. (2 messages)

Next thread: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:05 pm. (3 messages)
To: <jesse@...>, <jgarzik@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 12:04 pm

From: Julia Lawall &lt;julia@diku.dk&gt;

The variable gig is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
---
 drivers/net/ipg.c |    3 ---
 1 file changed, 3 deletions(-)

diff -u -p a/drivers/net/ipg.c b/drivers/net/ipg.c
--- a/drivers/net/ipg.c 2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/net/ipg.c 2008-03-15 11:17:14.000000000 +0100
@@ -472,7 +472,6 @@ static int ipg_config_autoneg(struct net
 	unsigned int txflowcontrol;
 	unsigned int rxflowcontrol;
 	unsigned int fullduplex;
-	unsigned int gig;
 	u32 mac_ctrl_val;
 	u32 asicctrl;
 	u8 phyctrl;
@@ -489,7 +488,6 @@ static int ipg_config_autoneg(struct net
 	fullduplex = 0;
 	txflowcontrol = 0;
 	rxflowcontrol = 0;
-	gig = 0;
 
 	/* To accomodate a problem in 10Mbps operation,
 	 * set a global flag if PHY running in 10Mbps mode.
@@ -511,7 +509,6 @@ static int ipg_config_autoneg(struct net
 		break;
 	case IPG_PC_LINK_SPEED_1000MBPS:
 		printk("1000Mbps.\n");
-		gig = 1;
 		break;
 	default:
 		printk("undefined!\n");
--
To: Julia Lawall <julia@...>
Cc: <jesse@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Monday, March 17, 2008 - 7:58 am

applied


--
Previous thread: [PATCH 5/7] drivers/net/ixgb/ixgb_main.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:04 pm. (2 messages)

Next thread: [PATCH 7/7] drivers/net/atl1/atl1_main.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:05 pm. (3 messages)
speck-geostationary