login
Header Space

 
 

[PATCH 3/7] net/ipv6/ndisc.c: remove unused variable

Previous thread: [PATCH 2/7] net/9p/trans_fd.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:02 pm. (2 messages)

Next thread: [PATCH 4/7] sound/pci: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:03 pm. (2 messages)
To: <davem@...>, <pekkas@...>, <netdev@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 15, 2008 - 12:03 pm

From: Julia Lawall &lt;julia@diku.dk&gt;

The variable hlen is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// &lt;smpl&gt;
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  &lt;+... when != i
- i = C;
  ...+&gt;
)
// &lt;/smpl&gt;

Signed-off-by: Julia Lawall &lt;julia@diku.dk&gt;
---
 net/ipv6/ndisc.c |    2 --
 1 file changed, 2 deletions(-)

diff -u -p a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
--- a/net/ipv6/ndisc.c 2008-03-12 14:13:15.000000000 +0100
+++ b/net/ipv6/ndisc.c 2008-03-15 07:30:11.000000000 +0100
@@ -1420,7 +1420,6 @@ void ndisc_send_redirect(struct sk_buff 
 	u8 *opt;
 	int rd_len;
 	int err;
-	int hlen;
 	u8 ha_buf[MAX_ADDR_LEN], *ha = NULL;
 
 	dev = skb-&gt;dev;
@@ -1491,7 +1490,6 @@ void ndisc_send_redirect(struct sk_buff 
 		return;
 	}
 
-	hlen = 0;
 
 	skb_reserve(buff, LL_RESERVED_SPACE(dev));
 	ip6_nd_hdr(sk, buff, dev, &amp;saddr_buf, &amp;ipv6_hdr(skb)-&gt;saddr,
--
To: <julia@...>
Cc: <pekkas@...>, <netdev@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Saturday, March 22, 2008 - 9:04 pm

From: Julia Lawall &lt;julia@diku.dk&gt;

Applied, thanks.
--
Previous thread: [PATCH 2/7] net/9p/trans_fd.c: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:02 pm. (2 messages)

Next thread: [PATCH 4/7] sound/pci: remove unused variable by Julia Lawall on Saturday, March 15, 2008 - 12:03 pm. (2 messages)
speck-geostationary