login
Header Space

 
 

[PATCH] Remove superfluous include of string.h from percpu.h.

Previous thread: [PATCH] x86: traps_32.c - use KSYM_NAME_LEN instead of numeric value by Cyrill Gorcunov on Saturday, March 15, 2008 - 4:34 am. (2 messages)

Next thread: vmlinuz resume=/dev/md0 borks swap ( unlike /dev/sda1 ) by Antryg Revok on Saturday, March 15, 2008 - 4:47 am. (1 message)
To: Linux Kernel Mailing List <linux-kernel@...>
Cc: Andrew Morton <akpm@...>
Date: Saturday, March 15, 2008 - 5:02 am

There's nothing in percpu.h that requires an explicit inclusion of
string.h.

Signed-off-by: Robert P. J. Day &lt;rpjday@crashcourse.ca&gt;

---

  after how hideously i embarrassed myself with that earlier exchange,
i am by god going to get a patch out of this.  :-)

  compile-tested on x86 after "make allyesconfig", so that deletion
did not appear to cause any breakage anywhere in the tree.

  p.s.  for the [PATCH] subject line, what kernel subsystem would be
used for things like the header files?

diff --git a/include/linux/percpu.h b/include/linux/percpu.h
index 1ac9697..d746a2a 100644
--- a/include/linux/percpu.h
+++ b/include/linux/percpu.h
@@ -4,7 +4,6 @@
 #include &lt;linux/preempt.h&gt;
 #include &lt;linux/slab.h&gt; /* For kmalloc() */
 #include &lt;linux/smp.h&gt;
-#include &lt;linux/string.h&gt; /* For memset() */
 #include &lt;linux/cpumask.h&gt;

 #include &lt;asm/percpu.h&gt;



========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
Previous thread: [PATCH] x86: traps_32.c - use KSYM_NAME_LEN instead of numeric value by Cyrill Gorcunov on Saturday, March 15, 2008 - 4:34 am. (2 messages)

Next thread: vmlinuz resume=/dev/md0 borks swap ( unlike /dev/sda1 ) by Antryg Revok on Saturday, March 15, 2008 - 4:47 am. (1 message)
speck-geostationary