login
Header Space

 
 

[PATCH 4/6] Introduce down_killable()

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>, <sfr@...>, <lenb@...>, <dhowells@...>, <peterz@...>, <mingo@...>, <harvey.harrison@...>
Cc: Matthew Wilcox <matthew@...>, Matthew Wilcox <willy@...>
Date: Friday, March 14, 2008 - 4:44 pm

down_killable() is the functional counterpart of mutex_lock_killable.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
 include/linux/semaphore.h |    6 ++++++
 kernel/semaphore.c        |   22 ++++++++++++++++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/include/linux/semaphore.h b/include/linux/semaphore.h
index b3c691b..88f2a28 100644
--- a/include/linux/semaphore.h
+++ b/include/linux/semaphore.h
@@ -62,6 +62,12 @@ extern void down(struct semaphore *sem);
 extern int __must_check down_interruptible(struct semaphore *sem);
 
 /*
+ * As down_interruptible(), except the sleep may only be interrupted by
+ * signals which are fatal to this process.
+ */
+extern int __must_check down_killable(struct semaphore *sem);
+
+/*
  * As down(), except this function will not sleep.  It will return 0 if it
  * acquired the semaphore and 1 if the semaphore was contended.  This
  * function may be called from any context, including interrupt and softirq.
diff --git a/kernel/semaphore.c b/kernel/semaphore.c
index d5a7270..2da2aed 100644
--- a/kernel/semaphore.c
+++ b/kernel/semaphore.c
@@ -34,6 +34,7 @@
 
 static noinline void __down(struct semaphore *sem);
 static noinline int __down_interruptible(struct semaphore *sem);
+static noinline int __down_killable(struct semaphore *sem);
 static noinline void __up(struct semaphore *sem);
 
 void down(struct semaphore *sem)
@@ -61,6 +62,20 @@ int down_interruptible(struct semaphore *sem)
 }
 EXPORT_SYMBOL(down_interruptible);
 
+int down_killable(struct semaphore *sem)
+{
+	unsigned long flags;
+	int result = 0;
+
+	spin_lock_irqsave(&sem->lock, flags);
+	if (unlikely(sem->count-- <= 0))
+		result = __down_killable(sem);
+	spin_unlock_irqrestore(&sem->lock, flags);
+
+	return result;
+}
+EXPORT_SYMBOL(down_killable);
+
 /**
  * down_trylock - try to acquire the semaphore, without waiting
  * @sem: the semaphore to be acquired
@@ -143,6 +158,8 @@ static inline int __sched __down_common(struct semaphore *sem, long state)
 	for (;;) {
 		if (state == TASK_INTERRUPTIBLE && signal_pending(task))
 			goto interrupted;
+		if (state == TASK_KILLABLE && fatal_signal_pending(task))
+			goto interrupted;
 		__set_task_state(task, state);
 		spin_unlock_irq(&sem->lock);
 		schedule();
@@ -178,6 +195,11 @@ static noinline int __sched __down_interruptible(struct semaphore *sem)
 	return __down_common(sem, TASK_INTERRUPTIBLE);
 }
 
+static noinline int __sched __down_killable(struct semaphore *sem)
+{
+	return __down_common(sem, TASK_KILLABLE);
+}
+
 static noinline void __sched __up(struct semaphore *sem)
 {
 	if (unlikely(list_empty(&sem->wait_list)))
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Updated generic semaphore patch set, Matthew Wilcox, (Fri Mar 14, 4:42 pm)
Re: Updated generic semaphore patch set, Harvey Harrison, (Fri Mar 14, 5:23 pm)
Re: Updated generic semaphore patch set, Johannes Weiner, (Fri Mar 14, 7:37 pm)
Re: Updated generic semaphore patch set, Harvey Harrison, (Fri Mar 14, 4:59 pm)
[PATCH 1/6] Fix quota.h includes, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 2/6] Add semaphore.h to kernel_lock.c, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 3/6] Generic semaphore implementation, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 4/6] Introduce down_killable(), Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 5/6] Add down_timeout and change ACPI to use it, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 6/6] Simplify semaphore implementation, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
speck-geostationary