login
Header Space

 
 

[PATCH 1/6] Fix quota.h includes

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>, <sfr@...>, <lenb@...>, <dhowells@...>, <peterz@...>, <mingo@...>, <harvey.harrison@...>
Cc: Matthew Wilcox <matthew@...>, Matthew Wilcox <willy@...>
Date: Friday, March 14, 2008 - 4:44 pm

quota.h currently relies on asm/semaphore.h (through some chain; it
doesn't actually include semaphore.h itself) to include wait.h.  As
well as being bad practice to rely on an implicit include, subsequent
patches will break this.  While I'm in this file, add atomic.h and
list.h, and sort the list of includes.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
---
 include/linux/quota.h |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/linux/quota.h b/include/linux/quota.h
index 6e0393a..eb560d0 100644
--- a/include/linux/quota.h
+++ b/include/linux/quota.h
@@ -160,14 +160,18 @@ enum {
 
 
 #ifdef __KERNEL__
-#include <linux/spinlock.h>
-#include <linux/rwsem.h>
+#include <linux/list.h>
 #include <linux/mutex.h>
+#include <linux/rwsem.h>
+#include <linux/spinlock.h>
+#include <linux/wait.h>
 
 #include <linux/dqblk_xfs.h>
 #include <linux/dqblk_v1.h>
 #include <linux/dqblk_v2.h>
 
+#include <asm/atomic.h>
+
 extern spinlock_t dq_data_lock;
 
 /* Maximal numbers of writes for quota operation (insert/delete/update)
-- 
1.5.4.3

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Updated generic semaphore patch set, Matthew Wilcox, (Fri Mar 14, 4:42 pm)
Re: Updated generic semaphore patch set, Harvey Harrison, (Fri Mar 14, 5:23 pm)
Re: Updated generic semaphore patch set, Johannes Weiner, (Fri Mar 14, 7:37 pm)
Re: Updated generic semaphore patch set, Harvey Harrison, (Fri Mar 14, 4:59 pm)
[PATCH 1/6] Fix quota.h includes, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 2/6] Add semaphore.h to kernel_lock.c, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 3/6] Generic semaphore implementation, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 4/6] Introduce down_killable(), Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 5/6] Add down_timeout and change ACPI to use it, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
[PATCH 6/6] Simplify semaphore implementation, Matthew Wilcox, (Fri Mar 14, 4:44 pm)
speck-geostationary