Re: [PATCH] x86: simplify sync_test_bit()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jan Beulich
Date: Friday, March 14, 2008 - 8:20 am

>#define sync_test_bit(nr, addr) test_bit(nr, addr)

I'm usually intentionally using just the names, without parameters and
not as inline, in such alias definitions so that in case the name gets used
as a function pointer (arguably unlikely here) there's not going to be
any missing definition or duplicate function instantiation. But from a
functionality point of view, either of the alternatives you suggest is
of course as good.

Jan

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: simplify sync_test_bit(), Jan Beulich, (Fri Mar 14, 12:56 am)
Re: [PATCH] x86: simplify sync_test_bit(), Jeremy Fitzhardinge, (Fri Mar 14, 8:03 am)
Re: [PATCH] x86: simplify sync_test_bit(), Jan Beulich, (Fri Mar 14, 8:20 am)
Re: [PATCH] x86: simplify sync_test_bit(), Jeremy Fitzhardinge, (Fri Mar 14, 8:43 am)
Re: [PATCH] x86: simplify sync_test_bit(), Ingo Molnar, (Fri Mar 21, 4:18 am)
Re: [PATCH] x86: simplify sync_test_bit(), Jeremy Fitzhardinge, (Sat Mar 22, 1:27 pm)
Re: [PATCH] x86: simplify sync_test_bit(), Ingo Molnar, (Wed Mar 26, 12:27 am)