On Tue, 2008-03-11 at 18:19 -0700, akepner@sgi.com wrote:
quoted text
> I have a new proposal for the documentation portion of this=20
> patchset. The code changes essentially amount to=20
> s/DMA_ATTR_SYNC_ON_WRITE/DMA_ATTR_BARRIER/ so thought I'd send=20
> just the doc change for comments now.
>=20
> The description of the DMA_ATTR_BARRIER is now very short and=20
> generic - no particular architecture is even mentioned. I can add=20
> a sentence or two near the architecture-specific changes in=20
> arch/ia64/sn/pci/pci_dma.c about why the implementation works=20
> on ia64/sn, etc.

I like this better, sorry to keep nitpicking, but just a few comments
below ..

quoted text
> diff --git a/Documentation/DMA-attributes.txt b/Documentation/DMA-attribu=
tes.txt
quoted text
> index e69de29..a4106ec 100644
> --- a/Documentation/DMA-attributes.txt
> +++ b/Documentation/DMA-attributes.txt
> @@ -0,0 +1,24 @@
> +			DMA attributes
> +			=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> +
> +This document describes the semantics of the DMA attributes that are=20
> +defined in linux/dma-attrs.h.=20
> +
> +DMA_ATTR_BARRIER
> +----------------
> +
> +DMA_ATTR_BARRIER is a barrier attribute for DMA.  DMA to a memory=20
> +region with the DMA_ATTR_BARRIER attribute forces all pending DMA=20
> +writes to complete, and thus provides a mechanism to strictly order=20
> +DMA from a device across all intervening busses and bridges.  This=20
> +barrier is not specific to a particular type of interconnect, it=20
> +applies to the system as a whole, and so its implementation must=20
> +account for the idiosyncracies of the system all the way from the=20
> +DMA device to memory.=20

You say a "DMA to a memory region with the DMA_ATTR_BARRIER attribute
forces all pending DMA writes to complete". Does it force _all_ DMA
writes to complete, or just writes to the region, or just writes coming
from devices? What if something is writing to a device?

Does DMA_ATTR_BARRIER have any effect on reads?

cheers

--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person