Home » Mailing list archives » linux-kernel » 2008 » March » 13

Re: [PATCH 4/4] ide: constify struct ide_dma_ops

Previous thread: [PATCH 2/4] ide: add IDE_HFLAG_SERIALIZE_DMA host flag by Bartlomiej Zolnierkiewicz on Sunday, March 9, 2008 - 8:59 am. (1 message)

Next thread: [PATCH 3/4] ide: add struct ide_dma_ops by Bartlomiej Zolnierkiewicz on Sunday, March 9, 2008 - 9:00 am. (6 messages)
[view original message]
From: Bartlomiej Zolnierkiewicz
Subject: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Sunday, March 9, 2008 - 9:02 am

* Export ide_dma_exec_cmd() and __ide_dma_test_irq().

* Constify struct ide_dma_ops.

* Always set hwif->dma_ops to &sff_dma_ops in ide_setup_dma()
  (it is later overriden by ide_init_port() if needed) and drop
  'const struct ide_port_info *d' argument.

While at it:

* Rename __ide_dma_test_irq() to __ide_dma_test_irq().

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/arm/icside.c       |    2 +-
 drivers/ide/arm/palm_bk3710.c  |    2 +-
 drivers/ide/cris/ide-cris.c    |    4 ++--
 drivers/ide/ide-dma.c          |   33 ++++++++-------------------------
 drivers/ide/ide-taskfile.c     |    2 +-
 drivers/ide/mips/au1xxx-ide.c  |    2 +-
 drivers/ide/pci/alim15x3.c     |   11 +++++++++--
 drivers/ide/pci/cmd64x.c       |   25 ++++++++++++++++++++++---
 drivers/ide/pci/cs5520.c       |    9 ++++++++-
 drivers/ide/pci/hpt366.c       |   26 ++++++++++++++++++++++----
 drivers/ide/pci/ns87415.c      |    8 +++++++-
 drivers/ide/pci/pdc202xx_old.c |   12 ++++++++++--
 drivers/ide/pci/sc1200.c       |    9 ++++++++-
 drivers/ide/pci/scc_pata.c     |    7 ++++++-
 drivers/ide/pci/sgiioc4.c      |    2 +-
 drivers/ide/pci/sl82c105.c     |    6 +++++-
 drivers/ide/pci/tc86c001.c     |    9 ++++++++-
 drivers/ide/pci/trm290.c       |    2 ++
 drivers/ide/ppc/pmac.c         |    4 ++--
 drivers/ide/setup-pci.c        |    2 +-
 include/linux/ide.h            |    8 +++++---
 21 files changed, 130 insertions(+), 55 deletions(-)

Index: b/drivers/ide/arm/icside.c
===================================================================
--- a/drivers/ide/arm/icside.c
+++ b/drivers/ide/arm/icside.c
@@ -392,7 +392,7 @@ static int icside_dma_init(ide_hwif_t *h
 	return 0;
 }
 
-static struct ide_dma_ops icside_v6_dma_ops = {
+static const struct ide_dma_ops icside_v6_dma_ops = {
 	.dma_host_set		= icside_dma_host_set,
 	.dma_setup		= icside_dma_setup,
 	.dma_exec_cmd		= icside_dma_exec_cmd,
Index: ...
[ message continues ]
[view original message]
From: Sergei Shtylyov
Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Sunday, March 9, 2008 - 10:01 am

Hello.



MBR, Sergei
--


[ message continues ]
[view original message]
From: Bartlomiej Zolnierkiewicz
Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Monday, March 10, 2008 - 2:53 pm

Hi,


thanks, fixed (the latter should be ide_dma_test_irq() of course)
--


[ message continues ]
[view original message]
From: Sergei Shtylyov
Subject: Re: [PATCH 4/4] ide: constify struct ide_dma_ops
Date: Thursday, March 13, 2008 - 11:44 am

Hello.



Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei
--


[ message continues ]
Previous thread: [PATCH 2/4] ide: add IDE_HFLAG_SERIALIZE_DMA host flag by Bartlomiej Zolnierkiewicz on Sunday, March 9, 2008 - 8:59 am. (1 message)

Next thread: [PATCH 3/4] ide: add struct ide_dma_ops by Bartlomiej Zolnierkiewicz on Sunday, March 9, 2008 - 9:00 am. (6 messages)