Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Badari Pulavarty
Date: Thursday, March 13, 2008 - 10:40 am

On Thu, 2008-03-13 at 09:09 -0800, Badari Pulavarty wrote:

Further narrowed it down to following patch in git-sched.patch.
When I back out this patch from rc5-mm1, my amd64 box boots fine.

commit 60befbc1c0b6d141c9c26e61ddd303aedd1e7396
Author: Guillaume Chazarain <guichaz@yahoo.fr>
Date:   Mon Mar 10 08:16:41 2008 +0100

    sched: make sure jiffies is up to date before calling
__update_rq_clock()

    Now that __update_rq_clock() uses jiffies to detect clock overflows,
    make sure jiffies are up to date before touch_softlockup_watchdog().

    Removed a touch_softlockup_watchdog() call becoming redundant with
the
    added tick_nohz_update_jiffies().

    Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/kernel/sched.c b/kernel/sched.c
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -66,6 +66,7 @@
 #include <linux/unistd.h>
 #include <linux/pagemap.h>
 #include <linux/hrtimer.h>
+#include <linux/tick.h>
 
 #include <asm/tlb.h>
 #include <asm/irq_regs.h>
@@ -913,7 +914,7 @@ void sched_clock_idle_wakeup_event(u64 delta_ns)
        rq->prev_clock_raw = now;
        rq->clock += delta_ns;
        spin_unlock(&rq->lock);
-       touch_softlockup_watchdog();
+       tick_nohz_update_jiffies();
 }
 EXPORT_SYMBOL_GPL(sched_clock_idle_wakeup_event);


Thanks,
Badari

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc5-mm1, Andrew Morton, (Tue Mar 11, 1:14 am)
[Build Faliure] 2.6.25-rc5-mm1 build fails , Kamalesh Babulal, (Tue Mar 11, 3:16 am)
Re: [Build Faliure] 2.6.25-rc5-mm1 build fails, Edward Shishkin, (Tue Mar 11, 3:56 am)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Randy Dunlap, (Tue Mar 11, 10:09 am)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Jeremy Fitzhardinge, (Tue Mar 11, 11:18 am)
Re: [Build Failure] 2.6.25-rc5-mm1 Build fails with allmod ..., Bartlomiej Zolnierki ..., (Tue Mar 11, 12:35 pm)
Re: [Build Failure] 2.6.25-rc5-mm1 Build fails with allmod ..., Bartlomiej Zolnierki ..., (Tue Mar 11, 12:36 pm)
Re: 2.6.25-rc5-mm1, serge, (Tue Mar 11, 1:23 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Tue Mar 11, 1:39 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Ravikiran G Thirumalai, (Tue Mar 11, 5:10 pm)
Re: 2.6.25-rc5-mm1, Dave Young, (Tue Mar 11, 6:14 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Randy Dunlap, (Tue Mar 11, 6:42 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Jeremy Fitzhardinge, (Tue Mar 11, 6:51 pm)
Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI), Ingo Molnar, (Wed Mar 12, 12:14 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem ?, Badari Pulavarty, (Wed Mar 12, 11:10 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem ?, Andrew Morton, (Wed Mar 12, 11:15 am)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Wed Mar 12, 12:33 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Wed Mar 12, 12:44 pm)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Wed Mar 12, 1:01 pm)
Re: [BUG] 2.6.25-rc5-mm1 kernel panic with &quot;Exception: 501 ..., Benjamin Herrenschmidt, (Wed Mar 12, 1:40 pm)
[2.6.25-rc5-mm1] BUG: spinlock bad magic early during boot, Tilman Schmidt, (Wed Mar 12, 4:54 pm)
[2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Wed Mar 12, 5:15 pm)
Re: 2.6.25-rc5-mm1 shutdown crash, Helge Hafting, (Thu Mar 13, 7:03 am)
Re: 2.6.25-rc5-mm1 shutdown crash, Andrew Morton, (Thu Mar 13, 9:12 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 10:09 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 10:40 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Guillaume Chazarain, (Thu Mar 13, 10:55 am)
Re: 2.6.25-rc5-mm1 - x86_64 boot problem with git-sched.patch, Badari Pulavarty, (Thu Mar 13, 11:20 am)
Re: 2.6.25-rc5-mm1, Torsten Kaiser, (Thu Mar 13, 3:05 pm)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Laurent Riffard, (Thu Mar 13, 3:07 pm)
Re: 2.6.25-rc5-mm1, Andrew Morton, (Thu Mar 13, 3:35 pm)
Re: 2.6.25-rc5-mm1, Badari Pulavarty, (Thu Mar 13, 4:10 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Thu Mar 13, 5:01 pm)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Oleg Nesterov, (Thu Mar 13, 10:26 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Fri Mar 14, 2:58 am)
Re: 2.6.25-rc5-mm1: &quot;consolechars&quot; hangs on boot, Laurent Riffard, (Fri Mar 14, 2:06 pm)
Re: [2.6.25-rc5-mm1] WARNING: at drivers/base/sys.c:173, Tilman Schmidt, (Sat Mar 15, 5:16 am)
Re: 2.6.25-rc5-mm1 build failure of pcsp.c, Mariusz Kozlowski, (Sun Mar 16, 2:38 pm)
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix sendma ..., Rafael J. Wysocki, (Thu Mar 20, 3:21 am)
Re: [2.6.25-rc5-mm1] regression: cannot run Postfix sendma ..., Rafael J. Wysocki, (Thu Mar 20, 7:38 am)
Re: 2.6.25-rc5-mm1, Ingo Molnar, (Fri Mar 21, 5:12 am)
Re: 2.6.25-rc5-mm1 shutdown crash, Helge Hafting, (Tue Mar 25, 5:23 am)
Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pc ..., Mariusz Kozlowski, (Fri Mar 28, 3:52 pm)
Re: 2.6.25-rc5-mm1 sparc64 boot problems due to generic pc ..., Benjamin Herrenschmidt, (Fri Mar 28, 5:44 pm)