login
Header Space

 
 

[PATCH] Terminate hugetlbfs mount argument list

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <akpm@...>, <wli@...>, <linux-kernel@...>
Date: Tuesday, March 11, 2008 - 6:42 pm

Terminate hugetlbfs mount argument list

[2.6.25 candidate I believe]

The match_table_t for the mount arguments in hugetlbfs wasn't 
terminated as match_tokens expect. I didn't see a crash just code
audit, but it's still safer to terminate it in case the variables after
that in .data are not NULL.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux/fs/hugetlbfs/inode.c
===================================================================
--- linux.orig/fs/hugetlbfs/inode.c
+++ linux/fs/hugetlbfs/inode.c
@@ -63,6 +63,7 @@ static match_table_t tokens = {
 	{Opt_uid,	"uid=%u"},
 	{Opt_gid,	"gid=%u"},
 	{Opt_err,	NULL},
+	{},
 };
 
 static void huge_pagevec_release(struct pagevec *pvec)
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Terminate hugetlbfs mount argument list, Andi Kleen, (Tue Mar 11, 6:42 pm)
Re: [PATCH] Terminate hugetlbfs mount argument list, Roland Dreier, (Tue Mar 11, 6:48 pm)
Re: [PATCH] Terminate hugetlbfs mount argument list, Andi Kleen, (Tue Mar 11, 6:56 pm)
Re: [PATCH] Terminate hugetlbfs mount argument list, Roland Dreier, (Tue Mar 11, 7:26 pm)
speck-geostationary